GitLabgitlab-org
cli
main
1package utils
3import (
4 "os"
5 "path/filepath"
6 "testing"
8 "github.com/stretchr/testify/assert"
9 "github.com/stretchr/testify/require"
10)
12func TestDestinationRoot(t *testing.T) {
13 t.Run("absolute path creates missing parents and is addressed by base name", func(t *testing.T) {
14 base := t.TempDir()
15 path := filepath.Join(base, "a", "b", "file.zip")
17 root, name, err := EnsureDestinationRoot(path)
18 require.NoError(t, err)
19 defer root.Close()
21 assert.Equal(t, "file.zip", name)
22 assert.DirExists(t, filepath.Join(base, "a", "b"))
24 // The returned name must address the file through the returned root.
25 // filepath.Dir of an absolute path is itself absolute, and os.Root
26 // rejects absolute names, so a full path here would fail.
27 f, err := root.Create(name)
28 require.NoError(t, err)
29 require.NoError(t, f.Close())
30 assert.FileExists(t, path)
31 })
33 t.Run("relative path is created under the working directory", func(t *testing.T) {
34 wd := t.TempDir()
35 t.Chdir(wd)
37 root, name, err := EnsureDestinationRoot(filepath.Join("downloads", "nested", "file.zip"))
38 require.NoError(t, err)
39 defer root.Close()
41 assert.Equal(t, "file.zip", name)
42 assert.DirExists(t, filepath.Join(wd, "downloads", "nested"))
43 })
45 t.Run("bare file name resolves to the working directory", func(t *testing.T) {
46 wd := t.TempDir()
47 t.Chdir(wd)
49 root, name, err := EnsureDestinationRoot("file.zip")
50 require.NoError(t, err)
51 defer root.Close()
53 assert.Equal(t, "file.zip", name)
55 f, err := root.Create(name)
56 require.NoError(t, err)
57 require.NoError(t, f.Close())
58 assert.FileExists(t, filepath.Join(wd, "file.zip"))
59 })
61 t.Run("relative path cannot escape the working directory", func(t *testing.T) {
62 parent := t.TempDir()
63 wd := filepath.Join(parent, "work")
64 require.NoError(t, os.Mkdir(wd, 0o755))
65 t.Chdir(wd)
67 _, _, err := EnsureDestinationRoot(filepath.Join("..", "escaped", "file.zip"))
68 require.Error(t, err)
69 assert.NoDirExists(t, filepath.Join(parent, "escaped"))
70 })
72 t.Run("existing directory is reused rather than failing", func(t *testing.T) {
73 base := t.TempDir()
74 require.NoError(t, os.MkdirAll(filepath.Join(base, "a"), 0o755))
76 root, name, err := EnsureDestinationRoot(filepath.Join(base, "a", "file.zip"))
77 require.NoError(t, err)
78 defer root.Close()
80 assert.Equal(t, "file.zip", name)
81 })
83 t.Run("absolute path whose parent is a file is rejected", func(t *testing.T) {
84 conflictFile := filepath.Join(t.TempDir(), "conflict")
85 require.NoError(t, os.WriteFile(conflictFile, []byte("conflict"), 0o600))
87 _, _, err := EnsureDestinationRoot(filepath.Join(conflictFile, "subdir", "file.txt"))
89 require.Error(t, err)
90 assert.Contains(t, err.Error(), "error creating directory")
91 })
92}
Diagnostics6 git calls · 37 ms
CallStatusSizeTime037 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=1 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchtree:0200307 B · hit1 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=31 git.response.bytes=307 git.response.cache=HIT git.response.duration_ms=1 git.fetch.filter=tree:0 git.fetch.wants=a37f1d670e91d25a83dd8509fb549df805c58f38 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=307 git.pkt.payload.max=280 git.sideband.band1.bytes=280 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=280 git.pack.trailer=1d8da1d6ced05f2d435b7a3203f70deda031ad4aOpen pack map
fetch200841 B · hit31 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=841 git.response.cache=HIT git.response.duration_ms=31 git.fetch.wants=05b52921118c07afb9e6136588d4802dd64af5d3 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=841 git.pkt.payload.max=814 git.sideband.band1.bytes=814 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e15343ba6a0acb
- Request
- 6e4b6b46…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format