GitLabgitlab-org
cli
main
1//go:build !integration
3package oauth2
5import (
6 "net/http"
7 "net/http/httptest"
8 "os"
9 "path/filepath"
10 "testing"
11 "time"
13 "github.com/stretchr/testify/assert"
14 "github.com/stretchr/testify/require"
15 "github.com/zalando/go-keyring"
17 "gitlab.com/gitlab-org/cli/internal/config"
18)
20// The refresh must not be attempted at all when the write would fail, because
21// the network call spends the refresh token.
22func TestConfigTokenSource_DoesNotConsumeRefreshTokenWhenItCannotPersist(t *testing.T) {
23 keyring.MockInit()
24 t.Cleanup(keyring.MockInit)
26 // Parent is a regular file, so MkdirAll fails with ENOTDIR even as root.
27 blocker := filepath.Join(t.TempDir(), "blocker")
28 require.NoError(t, os.WriteFile(blocker, nil, 0o600))
30 cfg := config.NewFromStringInDir(`
31---
32hosts:
33 gitlab.com:
34 is_oauth2: "true"
35 token: access-old
36 oauth2_refresh_token: refresh-old
37 oauth2_expiry_date: `+time.Now().Add(-time.Hour).Format(time.RFC3339)+`
38`, filepath.Join(blocker, "glab-cli"))
40 srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
41 // assert, not require: this runs in the server's handler goroutine.
42 assert.Fail(t, "the token endpoint must not be called when the rotated token cannot be persisted")
43 w.WriteHeader(http.StatusBadRequest)
44 }))
45 defer srv.Close()
47 _, err := tokenSourceForServer(cfg, srv).Token()
48 require.Error(t, err)
49 assert.Contains(t, err.Error(), "could not be saved")
51 // Still unspent: the user recovers by fixing the directory, not re-logging in.
52 refresh, err := cfg.Get(testHost, "oauth2_refresh_token")
53 require.NoError(t, err)
54 assert.Equal(t, "refresh-old", refresh)
55}
57// The probe must not stand in the way of a refresh that would have succeeded.
58func TestConfigTokenSource_RefreshesNormallyWhenCredentialsCanBePersisted(t *testing.T) {
59 dir := t.TempDir()
60 cfg := newKeyringConfigInDir(t, dir, "access-old", "refresh-old", time.Now().Add(-time.Hour))
62 var refreshed bool
63 srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
64 refreshed = true
65 w.Header().Set("Content-Type", "application/json")
66 _, _ = w.Write([]byte(`{"access_token":"access-new","refresh_token":"refresh-new","token_type":"bearer","expires_in":7200}`))
67 }))
68 defer srv.Close()
70 token, err := tokenSourceForServer(cfg, srv).Token()
71 require.NoError(t, err)
72 require.True(t, refreshed, "expected the expired token to be refreshed")
73 assert.Equal(t, "access-new", token.AccessToken)
75 entries, err := os.ReadDir(dir)
76 require.NoError(t, err)
77 for _, e := range entries {
78 assert.NotEqual(t, ".glab-write-probe", e.Name(), "probe file left behind")
79 }
80}
Diagnostics6 git calls · 43 ms
CallStatusSizeTime043 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=15 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0200468 B · hit15 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=22 git.response.bytes=468 git.response.cache=HIT git.response.duration_ms=15 git.fetch.filter=tree:0 git.fetch.wants=c498f09dbd0cebbc59f9eff3b3ef8be66186fac6 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=468 git.pkt.payload.max=441 git.sideband.band1.bytes=441 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=441 git.pack.trailer=6420a98b3b2e923a6b61c550c00de326d620e479Open pack map
fetch2001.3 KiB · hit22 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1286 git.response.cache=HIT git.response.duration_ms=22 git.fetch.wants=55e5d262f4c53ab59bbea2873be79e5dce05c713 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1286 git.pkt.payload.max=1259 git.sideband.band1.bytes=1259 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2638a0dca224d
- Request
- 5385467f…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format