GitLabgitlab-org
cli
main
1//go:build !integration
3package proxy
5import (
6 "bytes"
7 "encoding/json"
8 "maps"
9 "slices"
10 "strings"
11 "testing"
13 "github.com/stretchr/testify/assert"
14 "github.com/stretchr/testify/require"
15)
17func TestScanPackumentReadsPublishFields(t *testing.T) {
18 t.Parallel()
19 body := ` {"_id":"left-pad","name":"left-pad","description":"pad \"left\" \\ {not a brace}",` +
20 `"dist-tags":{"latest":"1.3.0"},"versions":{"1.3.0":{"name":"left-pad","keywords":["a",["b"]]}},` +
21 `"access":null,"private":false,"n":-1.5e3,"_attachments":{"left-pad-1.3.0.tgz":{"data":"H4sI\"AA"}}} `
22 got, err := scanPackument(strings.NewReader(body), 1024)
23 require.NoError(t, err)
24 assert.Equal(t, packument{name: "left-pad", versions: []string{"1.3.0"}, attachments: true}, got)
25}
27func TestScanPackumentLaterKeyWins(t *testing.T) {
28 t.Parallel()
29 // The registry's JSON parser keeps the last occurrence of a key, so the
30 // scanner must too, including a key spelled with a unicode escape.
31 body := `{"name":"benign","versions":{"1.0.0":{}},"_attachments":{"x.tgz":{"data":"AAAA"}},` +
32 `"na\u006de":"evil","versions":{"6.6.6":{}}}`
33 got, err := scanPackument(strings.NewReader(body), 1024)
34 require.NoError(t, err)
35 assert.Equal(t, "evil", got.name)
36 assert.Equal(t, []string{"6.6.6"}, got.versions)
37}
39func TestScanPackumentKeysAreCaseSensitive(t *testing.T) {
40 t.Parallel()
41 // encoding/json matches struct fields case-insensitively; the registry
42 // does not, so "NAME" must not replace "name".
43 body := `{"name":"benign","versions":{"1.0.0":{}},"_attachments":{},"NAME":"evil","Versions":{"6.6.6":{}}}`
44 got, err := scanPackument(strings.NewReader(body), 1024)
45 require.NoError(t, err)
46 assert.Equal(t, "benign", got.name)
47 assert.Equal(t, []string{"1.0.0"}, got.versions)
48}
50func TestScanPackumentNullAttachmentsIsNotAPublish(t *testing.T) {
51 t.Parallel()
52 got, err := scanPackument(strings.NewReader(`{"name":"left-pad","_attachments":null}`), 1024)
53 require.NoError(t, err)
54 assert.False(t, got.attachments)
55}
57func TestScanPackumentRejectsMalformed(t *testing.T) {
58 t.Parallel()
59 cases := map[string]string{
60 "not an object": `["left-pad"]`,
61 "unquoted key": `{name:"left-pad"}`,
62 "missing colon": `{"name" "left-pad"}`,
63 "truncated value": `{"name":"left-pad","_attachments":{"x.tgz":{"data":"AAA`,
64 "truncated object": `{"name":"left-pad"`,
65 "non-string name": `{"name":42}`,
66 "name over the cap": `{"name":"` + strings.Repeat("a", 64) + `"}`,
67 "garbage after pair": `{"name":"left-pad" x}`,
68 }
69 for name, body := range cases {
70 t.Run(name, func(t *testing.T) {
71 t.Parallel()
72 _, err := scanPackument(strings.NewReader(body), 32)
73 assert.Error(t, err)
74 })
75 }
76}
78// decodePackumentReference decodes body the way the registry does: keys are
79// case-sensitive and a repeated key replaces the earlier one.
80func decodePackumentReference(body []byte) (packument, bool) {
81 var top map[string]json.RawMessage
82 if json.Unmarshal(body, &top) != nil || top == nil {
83 return packument{}, false
84 }
85 var p packument
86 if raw, ok := top["name"]; ok && json.Unmarshal(raw, &p.name) != nil {
87 return packument{}, false
88 }
89 if raw, ok := top["versions"]; ok {
90 var versions map[string]json.RawMessage
91 if json.Unmarshal(raw, &versions) != nil {
92 return packument{}, false
93 }
94 p.versions = slices.Sorted(maps.Keys(versions))
95 }
96 if raw, ok := top["_attachments"]; ok {
97 p.attachments = raw[0] == '{'
98 }
99 return p, true
100}
102func FuzzScanPackumentMatchesReference(f *testing.F) {
103 for _, s := range []string{
104 `{"name":"a","versions":{"1.0.0":{}},"_attachments":{"a.tgz":{"data":"x\"y\\z"}}}`,
105 `{"na\u006de":"b","name":"a","versions":{"1":{},"2":[1,{"x":"}"}]}}`,
106 `{"_attachments":null,"name":"\ud83d\ude00","versions":{"\u0031":true}}`,
107 `{"x":[[[{"y":"]"}]]],"name":"c","n":-0.5e-3,"t":true,"f":false,"z":null}`,
108 `{"name":"d","NAME":"e"}`,
109 ` { "name" : "d" , "versions" : { } } `,
110 `{}`,
111 } {
112 f.Add([]byte(s))
113 }
114 f.Fuzz(func(t *testing.T, body []byte) {
115 want, ok := decodePackumentReference(body)
116 if !ok {
117 return
118 }
119 got, err := scanPackument(bytes.NewReader(body), 1<<20)
120 require.NoError(t, err, "scanner rejected valid JSON %q", body)
121 assert.Equal(t, want, got, "body %q", body)
122 })
123}
Diagnostics7 git calls · 221 ms
CallStatusSizeTime0221 ms
discover200185 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit6 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=6 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=6 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0200361 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=361 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=361 git.pkt.payload.max=334 git.sideband.band1.bytes=334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=334 git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32Open pack map
fetchtree:02001.0 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=1051 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=7a2a90605315ba5b37f63c08726e6b2caa26e48d git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1051 git.pkt.payload.max=1024 git.sideband.band1.bytes=1024 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1024 git.pack.trailer=7503ef36a75d3595b473035c69e639fd0ce41598Open pack map
fetch2001.6 KiB208 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=208 git.response.bytes=1623 git.response.cache=MISS git.response.duration_ms=208 git.fetch.wants=46074e6a5c834ceb6c587314fd4377d47cc8137a git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1623 git.pkt.payload.max=1596 git.sideband.band1.bytes=1596 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e24669b9dfee28
- Request
- 9422ee9a…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format