GitLabgitlab-org
cli
main
1//go:build !integration
3package proxy
5import (
6 "net/http"
7 "net/http/httptest"
8 "testing"
10 "github.com/stretchr/testify/assert"
12 "gitlab.com/gitlab-org/cli/internal/dependencyfirewall/policy"
13)
15func rubygem(method, path string) *http.Request {
16 return httptest.NewRequest(method, "https://rubygems.org"+path, http.NoBody)
17}
19func TestGemMatchDownload(t *testing.T) {
20 t.Parallel()
21 m := GemMatcher{}.Match(rubygem(http.MethodGet, "/gems/rails-7.1.3.gem"))
22 assert.True(t, m.Matched)
23 assert.Equal(t, policy.Coordinate{Ecosystem: "gem", Name: "rails", Version: "7.1.3"}, m.Coordinate)
24 assert.Equal(t, policy.Download, m.Operation)
25}
27func TestGemMatchPlatformSuffix(t *testing.T) {
28 t.Parallel()
29 m := GemMatcher{}.Match(rubygem(http.MethodGet, "/gems/nokogiri-1.16.0-x86_64-linux.gem"))
30 assert.True(t, m.Matched)
31 assert.Equal(t, "nokogiri", m.Coordinate.Name)
32 assert.Equal(t, "1.16.0", m.Coordinate.Version)
33}
35func TestGemInfoEndpointIsNoMatch(t *testing.T) {
36 t.Parallel()
37 m := GemMatcher{}.Match(rubygem(http.MethodGet, "/info/rails"))
38 assert.False(t, m.Matched)
39}
41func TestGemUploadIsMatchWithoutVersion(t *testing.T) {
42 t.Parallel()
43 m := GemMatcher{}.Match(rubygem(http.MethodPost, "/api/v1/gems"))
44 assert.True(t, m.Matched)
45 assert.Equal(t, policy.Upload, m.Operation)
46 assert.Empty(t, m.Coordinate.Name)
47}
49func TestGemDownloadRequiresGemsAsImmediateParent(t *testing.T) {
50 t.Parallel()
51 // "gems" must be the .gem file's immediate parent directory. A path where
52 // "gems" is only an ancestor (here, a "subdir" sits between) is not a
53 // genuine RubyGems download coordinate and must not match, otherwise
54 // unrelated ".gem" traffic under any "gems/" ancestor bypasses the check.
55 m := GemMatcher{}.Match(rubygem(http.MethodGet, "/vendor/gems/subdir/rails-7.1.3.gem"))
56 assert.False(t, m.Matched, "gems must be the immediate parent directory of the .gem file")
57}
59func TestGemDownloadUnparseableFilenameFailsClosed(t *testing.T) {
60 t.Parallel()
61 // The ".gem" file sits directly under a "gems/" directory, so it is a
62 // recognized gem download; a filename with no name/version boundary must
63 // fail closed rather than being forwarded uninspected.
64 m := GemMatcher{}.Match(rubygem(http.MethodGet, "/gems/rails.gem"))
65 assert.True(t, m.Matched)
66 assert.False(t, m.Pass, "an unparseable gem filename must fail closed (Pass = false)")
67 assert.Equal(t, "gem", m.Coordinate.Ecosystem)
68 assert.Equal(t, policy.Download, m.Operation)
69}
71func TestGemDownloadAllowsMountPrefix(t *testing.T) {
72 t.Parallel()
73 // An arbitrary mount prefix before "gems/" is still a valid download as
74 // long as "gems" is the immediate parent of the .gem file.
75 m := GemMatcher{}.Match(rubygem(http.MethodGet, "/mirror/rubygems/gems/rails-7.1.3.gem"))
76 assert.True(t, m.Matched)
77 assert.Equal(t, policy.Coordinate{Ecosystem: "gem", Name: "rails", Version: "7.1.3"}, m.Coordinate)
78}
80func TestGemDoesNotDoubleDecodePath(t *testing.T) {
81 t.Parallel()
82 // req.URL.Path is already decoded once by Go's parser. The matcher must
83 // evaluate that once-decoded path and not decode it a second time. Simulate
84 // a parser output where the file segment still contains a literal "%2e":
85 // upstream sees "...rails-7.1.3%2egem" (not a ".gem"), so it must not match.
86 // A second PathUnescape would turn "%2egem" into ".gem" and wrongly match.
87 req := rubygem(http.MethodGet, "/gems/rails-7.1.3.gem")
88 req.URL.Path = "/gems/rails-7.1.3%2egem"
89 m := GemMatcher{}.Match(req)
90 assert.False(t, m.Matched, "matcher must not perform a second percent-decode of req.URL.Path")
91}
93func TestGemUploadPathBoundary(t *testing.T) {
94 t.Parallel()
95 // The upload match must anchor on a path-segment boundary: a path that
96 // merely ends in "api/v1/gems" without a preceding "/" (or being the whole
97 // path) is not the upload endpoint and must not match.
98 m := GemMatcher{}.Match(rubygem(http.MethodPost, "/notapi/v1/gems"))
99 assert.False(t, m.Matched)
100}
Diagnostics7 git calls · 337 ms
CallStatusSizeTime0337 ms
discover200185 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit1 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=1 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=1 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0200361 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=361 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=361 git.pkt.payload.max=334 git.sideband.band1.bytes=334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=334 git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32Open pack map
fetchtree:02001.0 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=329 git.response.bytes=1051 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=7a2a90605315ba5b37f63c08726e6b2caa26e48d git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1051 git.pkt.payload.max=1024 git.sideband.band1.bytes=1024 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1024 git.pack.trailer=7503ef36a75d3595b473035c69e639fd0ce41598Open pack map
fetch2001.4 KiB329 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1410 git.response.cache=MISS git.response.duration_ms=329 git.fetch.wants=5fdd3956bded77baf223fb0c49685151dc68948b git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1410 git.pkt.payload.max=1383 git.sideband.band1.bytes=1383 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e22c2efb0b2a83
- Request
- 2f52678f…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format