GitLabgitlab-org
cli
main
1package proxy
3import (
4 "net/http"
5 "strings"
7 "gitlab.com/gitlab-org/cli/internal/dependencyfirewall/policy"
8)
10// GemMatcher recognizes RubyGems downloads ("/gems/<name>-<version>.gem")
11// and pushes (POST "/api/v1/gems"). The push body carries the gem binary,
12// so the upload coordinate has an empty Name/Version; the checker still
13// receives an Upload request for a package-level decision.
14type GemMatcher struct{}
16const gemSuffix = ".gem"
18func (GemMatcher) Match(req *http.Request) Match {
19 if req == nil {
20 return Match{}
21 }
22 // req.URL.Path is already percent-decoded once by Go's parser. Decoding
23 // again would let a double-encoded request present the matcher a different
24 // path than the upstream RubyGems server sees, and because an unmatched
25 // request bypasses the firewall that is a policy-bypass vector. Match
26 // against the once-decoded path the origin actually receives.
27 path := strings.Trim(req.URL.Path, "/")
29 if req.Method == http.MethodPost && (path == "api/v1/gems" || strings.HasSuffix(path, "/api/v1/gems")) {
30 return Match{
31 Matched: true,
32 Pass: true,
33 Coordinate: policy.Coordinate{Ecosystem: "gem"},
34 Operation: policy.Upload,
35 }
36 }
38 if !strings.HasSuffix(path, gemSuffix) {
39 return Match{}
40 }
41 file := path
42 if _, after, ok := strings.CutLast(path, "/"); ok {
43 file = after
44 }
45 // Only the "gems/" directory serves .gem downloads; guard against
46 // matching unrelated ".gem" paths. Require "gems" to be the file's
47 // immediate parent directory, not merely present anywhere in the path,
48 // so a path like "vendor/gems/subdir/rails-7.1.3.gem" does not match.
49 dir := strings.TrimSuffix(strings.TrimSuffix(path, file), "/")
50 if dir != "gems" && !strings.HasSuffix(dir, "/gems") {
51 return Match{}
52 }
53 base := strings.TrimSuffix(file, gemSuffix)
54 name, version, ok := splitGemNameVersion(base)
55 if !ok {
56 // The ".gem" file sits directly under a "gems/" directory, so it is a
57 // recognized gem download; a filename this heuristic cannot split
58 // fails closed rather than forwarding it uninspected.
59 return unparseableMatch("gem", policy.Download, "unparseable gem download filename")
60 }
61 return Match{
62 Matched: true,
63 Pass: true,
64 Coordinate: policy.Coordinate{Ecosystem: "gem", Name: name, Version: version},
65 Operation: policy.Download,
66 }
67}
69// splitGemNameVersion splits "<name>-<version>[-<platform>...]" into name
70// and version. The name ends at the first hyphen whose following character
71// is a digit (the version start). The version then runs up to the next
72// hyphen that begins a non-digit segment (the platform suffix), so
73// "nokogiri-1.16.0-x86_64-linux" yields name "nokogiri", version "1.16.0".
74//
75// This is a heuristic: a gem whose name ends in a hyphen followed by a digit
76// (for example "a1-2fast") mis-splits, because the first "-<digit>" boundary
77// is taken as the version start. Gem filenames do not encode the name/version
78// boundary unambiguously, so this cannot be fully correct from the path alone;
79// the mis-split names are rare and the resulting coordinate still fails closed
80// or over-blocks rather than allowing an unintended package.
81func splitGemNameVersion(base string) (string, string, bool) {
82 for idx := 0; idx < len(base); idx++ {
83 if base[idx] != '-' {
84 continue
85 }
86 if idx+1 < len(base) && base[idx+1] >= '0' && base[idx+1] <= '9' {
87 name := base[:idx]
88 version := base[idx+1:]
89 if name == "" {
90 return "", "", false
91 }
92 for vi := 0; vi < len(version); vi++ {
93 if version[vi] == '-' && (vi+1 >= len(version) || version[vi+1] < '0' || version[vi+1] > '9') {
94 version = version[:vi]
95 break
96 }
97 }
98 return name, version, true
99 }
100 }
101 return "", "", false
102}
Diagnostics7 git calls · 226 ms
CallStatusSizeTime0226 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0200361 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=361 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=361 git.pkt.payload.max=334 git.sideband.band1.bytes=334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=334 git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32Open pack map
fetchtree:02001.0 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=212 git.response.bytes=1051 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=7a2a90605315ba5b37f63c08726e6b2caa26e48d git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1051 git.pkt.payload.max=1024 git.sideband.band1.bytes=1024 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1024 git.pack.trailer=7503ef36a75d3595b473035c69e639fd0ce41598Open pack map
fetch2001.7 KiB212 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1738 git.response.cache=MISS git.response.duration_ms=212 git.fetch.wants=cf830d62741a33b8279cc5d1c26306955d50b0a3 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1738 git.pkt.payload.max=1711 git.sideband.band1.bytes=1711 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e21424cb96984a
- Request
- 648f6347…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format