GitLabgitlab-org
cli
main
1//go:build !integration
3package proxy
5import (
6 "io"
7 "net/http"
8 "net/http/httptest"
9 "net/url"
10 "sync/atomic"
11 "testing"
13 "github.com/stretchr/testify/assert"
14 "github.com/stretchr/testify/require"
16 "gitlab.com/gitlab-org/cli/internal/dependencyfirewall/policy"
17 "gitlab.com/gitlab-org/cli/internal/dependencyfirewall/verdict"
18)
20// startJobProxy starts a proxy configured like the job-level one and returns
21// a client that sends plain HTTP through it, as a job's tools do once
22// HTTP_PROXY points at it.
23func startJobProxy(t *testing.T, checker policy.Checker) (*Proxy, *http.Client, *atomic.Int32) {
24 t.Helper()
25 var hooked atomic.Int32
26 p, err := New(DefaultMatchers(), checker, "group/proj",
27 WithVerdictHook(func(verdict.Entry) { hooked.Add(1) }))
28 require.NoError(t, err)
29 require.NoError(t, p.Start())
30 t.Cleanup(p.Stop)
31 proxyURL, err := url.Parse("http://" + p.Addr())
32 require.NoError(t, err)
33 return p, &http.Client{Transport: &http.Transport{Proxy: http.ProxyURL(proxyURL)}}, &hooked
34}
36func TestJobProxyBlocksPlainHTTPPackageDownloads(t *testing.T) {
37 t.Parallel()
38 // RubyGems and PyPI tools follow only the generic proxy variables, so
39 // without HTTP_PROXY a plain-HTTP registry for them would go uninspected.
40 for _, path := range []string{
41 "/left-pad/-/left-pad-1.3.0.tgz",
42 "/gems/rails-7.1.3.gem",
43 "/packages/ab/cd/requests-2.31.0-py3-none-any.whl",
44 } {
45 t.Run(path, func(t *testing.T) {
46 t.Parallel()
47 var hits atomic.Int32
48 upstream := httptest.NewServer(http.HandlerFunc(func(http.ResponseWriter, *http.Request) { hits.Add(1) }))
49 t.Cleanup(upstream.Close)
50 p, client, hooked := startJobProxy(t, stubChecker{result: policy.Result{Verdict: verdict.Blocked, Reason: "malicious"}})
52 resp, err := client.Get(upstream.URL + path)
53 require.NoError(t, err)
54 resp.Body.Close()
56 assert.Equal(t, http.StatusForbidden, resp.StatusCode)
57 assert.Zero(t, hits.Load(), "a blocked download must not reach the registry")
58 require.Len(t, p.Verdicts(), 1)
59 assert.Equal(t, verdict.Blocked, p.Verdicts()[0].Verdict)
60 assert.Equal(t, int32(1), hooked.Load(), "the verdict reaches the CI log hook before the 403")
61 })
62 }
63}
65func TestJobProxyForwardsOtherPlainHTTPTraffic(t *testing.T) {
66 t.Parallel()
67 // Such as a job calling a service container: not a package, so no policy
68 // check and no verdict, just forwarded.
69 upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
70 _, _ = io.WriteString(w, "ok "+r.Method+" "+r.URL.Path)
71 }))
72 t.Cleanup(upstream.Close)
73 p, client, hooked := startJobProxy(t, stubChecker{result: policy.Result{Verdict: verdict.Blocked}})
75 resp, err := client.Get(upstream.URL + "/health")
76 require.NoError(t, err)
77 defer resp.Body.Close()
78 body, err := io.ReadAll(resp.Body)
79 require.NoError(t, err)
81 assert.Equal(t, http.StatusOK, resp.StatusCode)
82 assert.Equal(t, "ok GET /health", string(body))
83 assert.Empty(t, p.Verdicts())
84 assert.Zero(t, hooked.Load())
85}
Diagnostics7 git calls · 219 ms
CallStatusSizeTime0219 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0200361 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=361 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=361 git.pkt.payload.max=334 git.sideband.band1.bytes=334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=334 git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32Open pack map
fetchtree:02001.0 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=206 git.response.bytes=1051 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=7a2a90605315ba5b37f63c08726e6b2caa26e48d git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1051 git.pkt.payload.max=1024 git.sideband.band1.bytes=1024 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1024 git.pack.trailer=7503ef36a75d3595b473035c69e639fd0ce41598Open pack map
fetch2001.3 KiB206 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1361 git.response.cache=MISS git.response.duration_ms=206 git.fetch.wants=e1c1004750ca1b504848f3ac44a8ba955db96f76 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1361 git.pkt.payload.max=1334 git.sideband.band1.bytes=1334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5ea932b1f54a87d
- Request
- 911a96b2…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format