GitLabgitlab-org
cli
main
1//go:build !integration
3package policy
5import (
6 "os"
7 "strings"
8 "testing"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
13 "gitlab.com/gitlab-org/cli/internal/dependencyfirewall/verdict"
14)
16func TestResultAllowIsZeroVerdict(t *testing.T) {
17 t.Parallel()
18 var r Result
19 assert.Equal(t, verdict.Allowed, r.Verdict)
20 assert.True(t, r.Allowed())
21 assert.False(t, r.Blocked())
22 assert.False(t, r.Warned())
23}
25func TestResultBlockedHelper(t *testing.T) {
26 t.Parallel()
27 r := Result{Verdict: verdict.Blocked}
28 assert.True(t, r.Blocked())
29 assert.False(t, r.Allowed())
30 assert.False(t, r.Warned())
31}
33func TestResultWarnedHelper(t *testing.T) {
34 t.Parallel()
35 r := Result{Verdict: verdict.Warning}
36 assert.True(t, r.Warned())
37 assert.False(t, r.Allowed())
38 assert.False(t, r.Blocked())
39}
41func TestCoordinateKey(t *testing.T) {
42 t.Parallel()
43 c := Coordinate{Ecosystem: "npm", Name: "left-pad", Version: "1.3.0"}
44 assert.Equal(t, "npm:left-pad@1.3.0", c.Key())
45}
47func TestOperationString(t *testing.T) {
48 t.Parallel()
49 assert.Equal(t, "download", Download.String())
50 assert.Equal(t, "upload", Upload.String())
51}
53func TestOperationStringUnknown(t *testing.T) {
54 t.Parallel()
55 // An out-of-range operation renders through the default branch rather than
56 // panicking or printing a bare integer, so a stray value stays legible in
57 // logs and cache keys.
58 assert.Equal(t, "operation(99)", Operation(99).String())
59}
61func TestRequestKey(t *testing.T) {
62 t.Parallel()
63 // The key must include project and operation so verdicts don't leak
64 // across projects or between download and upload.
65 base := Request{
66 Coordinate: Coordinate{Ecosystem: "npm", Name: "left-pad", Version: "1.3.0"},
67 ProjectID: "group/app",
68 Operation: Download,
69 }
70 assert.Equal(t, "npm:left-pad@1.3.0|group/app|download", base.Key())
72 // Same coordinate, different operation -> different key.
73 upload := base
74 upload.Operation = Upload
75 assert.NotEqual(t, base.Key(), upload.Key())
77 // Same coordinate, different project -> different key.
78 otherProject := base
79 otherProject.ProjectID = "group/other"
80 assert.NotEqual(t, base.Key(), otherProject.Key())
81}
83func TestNewSelectsFakeWhenConfigured(t *testing.T) {
84 t.Setenv("GITLAB_CI", "")
85 t.Setenv("GLAB_DF_FAKE_DEFAULT", "block")
87 c, err := New(nil)
88 require.NoError(t, err)
89 _, isFake := c.(fakeChecker)
90 assert.True(t, isFake, "expected the fake checker when GLAB_DF_FAKE_* is set")
91}
93func TestNewRefusesFakeInCI(t *testing.T) {
94 t.Setenv("GITLAB_CI", "true")
95 t.Setenv("GLAB_DF_FAKE_DEFAULT", "allow")
97 c, err := New(nil)
98 require.Error(t, err, "fake mode must be refused under GITLAB_CI=true")
99 assert.Nil(t, c)
100 assert.Contains(t, err.Error(), fakeEnvPrefix)
101}
103func TestNewSelectsNonFakeWhenUnconfigured(t *testing.T) {
104 // t.Setenv can only set, not unset; clear any ambient GLAB_DF_FAKE_*
105 // so the non-fake branch is exercised.
106 for _, e := range os.Environ() {
107 if k, _, ok := strings.Cut(e, "="); ok && strings.HasPrefix(k, fakeEnvPrefix) {
108 t.Setenv(k, "")
109 os.Unsetenv(k)
110 }
111 }
113 c, err := New(nil)
114 require.NoError(t, err)
115 _, isFake := c.(fakeChecker)
116 assert.False(t, isFake, "expected the non-fake checker when no GLAB_DF_FAKE_* is set")
117 assert.NotNil(t, c)
118}
Diagnostics7 git calls · 187 ms
CallStatusSizeTime0187 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit1 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=1 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=1 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchtree:0200361 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=361 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=361 git.pkt.payload.max=334 git.sideband.band1.bytes=334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=334 git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32Open pack map
fetchtree:0200332 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=332 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=cb813f0d675e9dca14f167e8c7788d61eb19627f git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=332 git.pkt.payload.max=305 git.sideband.band1.bytes=305 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=305 git.pack.trailer=5e210c1831ecf78390a6fe6e1784efd898336da0Open pack map
fetch2001.2 KiB179 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=179 git.response.bytes=1221 git.response.cache=MISS git.response.duration_ms=179 git.fetch.wants=ac21e78cd16c0a0e02782b1597842d9ab8148f18 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1221 git.pkt.payload.max=1194 git.sideband.band1.bytes=1194 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2c2b40c54aedd
- Request
- 09ad179f…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format