GitLabgitlab-org
cli
main
1//go:build !integration
3package pm
5import (
6 "os"
7 "path/filepath"
8 "strings"
9 "testing"
11 "github.com/stretchr/testify/assert"
12 "github.com/stretchr/testify/require"
13)
15// TestMavenCATrustRoutesThroughProxy pins the security-critical routing path:
16// Maven ignores HTTP(S)_PROXY and the JVM proxy properties, so the generated
17// settings.xml passed via MAVEN_ARGS (-s) is the only thing sending mvn
18// traffic through the inspection proxy. A regression that dropped it would
19// silently fail open, so assert the exact wiring.
20func TestMavenCATrustRoutesThroughProxy(t *testing.T) {
21 t.Setenv("MAVEN_ARGS", "")
22 t.Chdir(t.TempDir())
23 ca := selfSignedTestCA(t)
24 caPath := filepath.Join(t.TempDir(), "ca.pem")
25 require.NoError(t, os.WriteFile(caPath, caPEM(t, ca), 0o600))
27 m := mavenWithoutInstall(t)
28 // An empty user.home keeps the machine's own ~/.m2/settings.xml out.
29 a, ok := m.(argsManager)
30 require.True(t, ok)
31 a.SetArgs([]string{"-Duser.home=" + t.TempDir()})
32 m.Environment("http://127.0.0.1:52999")
33 env := m.CATrustEnviron(caPath)
35 var mavenArgs string
36 for _, e := range env {
37 if v, ok := strings.CutPrefix(e, "MAVEN_ARGS="); ok {
38 mavenArgs = v
39 }
40 }
41 require.NotEmpty(t, mavenArgs, "MAVEN_ARGS must carry the -s settings.xml that routes mvn through the proxy")
43 settingsPath := caPath + ".settings.xml"
44 assert.Equal(t, "-s "+settingsPath, mavenArgs)
46 raw, err := os.ReadFile(settingsPath)
47 require.NoError(t, err, "the proxy settings.xml must be written")
48 settings := string(raw)
49 assert.Contains(t, settings, "<host>127.0.0.1</host>")
50 assert.Contains(t, settings, "<port>52999</port>")
51}
53// TestMavenCATrustFailOpenIsSilentButOmitsArgs guards the fail path: when the
54// proxy URL is missing or unparsable, writeMavenProxySettings fails and no
55// MAVEN_ARGS -s entry is added (the failure is logged via dbg, exercised by
56// the debug build). The truststore MAVEN_OPTS is still emitted.
57func TestMavenCATrustFailOpenOmitsProxyArgs(t *testing.T) {
58 ca := selfSignedTestCA(t)
59 caPath := filepath.Join(t.TempDir(), "ca.pem")
60 require.NoError(t, os.WriteFile(caPath, caPEM(t, ca), 0o600))
62 m := Maven() // Environment never called, so proxyURL is empty.
63 env := m.CATrustEnviron(caPath)
65 for _, e := range env {
66 assert.False(t, strings.HasPrefix(e, "MAVEN_ARGS="),
67 "no MAVEN_ARGS -s entry when the proxy settings.xml could not be written")
68 }
69}
Diagnostics7 git calls · 35 ms
CallStatusSizeTime035 ms
discover200185 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit5 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=5 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=5 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0200361 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=361 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=361 git.pkt.payload.max=334 git.sideband.band1.bytes=334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=334 git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32Open pack map
fetchtree:02001.3 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=1327 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=2758711b27b3e124482ce287b5df86092bb20d62 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1327 git.pkt.payload.max=1300 git.sideband.band1.bytes=1300 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1300 git.pack.trailer=c83fc6004a9a1360845513c0fb16272b5c14a3e4Open pack map
fetch2001.1 KiB · hit23 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=23 git.response.bytes=1159 git.response.cache=HIT git.response.duration_ms=23 git.fetch.wants=f5c233380a8235eaa5ac7ec22350b98d9f8ff0c1 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1159 git.pkt.payload.max=1132 git.sideband.band1.bytes=1132 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e25673ca191ae0
- Request
- ac25e003…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format