GitLabgitlab-org
cli
main
1//go:build !integration
3package pm
5import (
6 "fmt"
7 "os"
8 "path/filepath"
9 "testing"
11 "github.com/stretchr/testify/assert"
12 "github.com/stretchr/testify/require"
13)
15// Not parallel: it sets PATH and changes the working directory.
16func TestMavenJobArgsEnvKeepsTheInstallGlobalMirror(t *testing.T) {
17 withSystemMavenRC(t)
18 home := filepath.Join(t.TempDir(), "maven")
19 mvn := fakeMavenInstall(t, home)
20 global := `<settings><mirrors><mirror><id>corp</id><mirrorOf>*</mirrorOf><url>https://nexus.corp.example/repository/maven</url></mirror></mirrors></settings>`
21 require.NoError(t, os.WriteFile(filepath.Join(home, "conf", "settings.xml"), []byte(global), 0o600))
22 t.Setenv("PATH", filepath.Dir(mvn))
23 t.Setenv("MAVEN_ARGS", "")
24 // Maven reads user.home from the passwd database, not HOME; pin it so the
25 // user-proxy check can't read the running dev's real ~/.m2/settings.xml.
26 t.Setenv("MAVEN_OPTS", "-Duser.home="+t.TempDir())
27 t.Chdir(t.TempDir())
29 path := filepath.Join(t.TempDir(), "job-settings.xml")
30 env, err := MavenJobArgsEnv(path, "http://127.0.0.1:9999", func(string, ...any) {})
31 require.NoError(t, err)
32 assert.Equal(t, "MAVEN_ARGS=-gs "+path, env)
34 settings, err := os.ReadFile(path)
35 require.NoError(t, err)
36 assert.Contains(t, string(settings), "https://nexus.corp.example/repository/maven")
37 assert.Contains(t, string(settings), "<host>127.0.0.1</host>")
38}
40// Not parallel: it sets PATH and MAVEN_ARGS.
41func TestMavenJobArgsEnvWithoutMaven(t *testing.T) {
42 t.Setenv("PATH", t.TempDir())
43 t.Setenv("MAVEN_ARGS", "-B")
44 // Pin Maven's user.home (not HOME) so the user-proxy check ignores the dev's
45 // real ~/.m2/settings.xml.
46 t.Setenv("MAVEN_OPTS", "-Duser.home="+t.TempDir())
48 path := filepath.Join(t.TempDir(), "job-settings.xml")
49 env, err := MavenJobArgsEnv(path, "http://127.0.0.1:9999", func(string, ...any) {})
50 require.NoError(t, err)
51 assert.Equal(t, "MAVEN_ARGS=-gs "+path+" -B", env)
52 settings, err := os.ReadFile(path)
53 require.NoError(t, err)
54 assert.Contains(t, string(settings), "<host>127.0.0.1</host>")
55}
57func TestMavenJobArgsEnvRejectsABadProxyURL(t *testing.T) {
58 t.Parallel()
59 _, err := MavenJobArgsEnv(filepath.Join(t.TempDir(), "s.xml"), "not a url", func(string, ...any) {})
60 assert.Error(t, err)
61}
63// Not parallel: it sets PATH, MAVEN_BASEDIR and changes the working directory.
64func TestMavenJobArgsEnvWarnsWhenTheGlobalSettingsCantBeResolved(t *testing.T) {
65 withSystemMavenRC(t)
66 mvn := fakeMavenInstall(t, filepath.Join(t.TempDir(), "maven"))
67 t.Setenv("PATH", filepath.Dir(mvn))
68 t.Setenv("MAVEN_ARGS", "")
69 // glab can't tell which .mvn/maven.config the launcher reads from here.
70 t.Setenv("MAVEN_BASEDIR", t.TempDir())
71 // Pin Maven's user.home (not HOME) so the user-proxy check can't read the
72 // dev's real ~/.m2/settings.xml and add a second warning.
73 t.Setenv("MAVEN_OPTS", "-Duser.home="+t.TempDir())
74 t.Chdir(t.TempDir())
76 var warned []string
77 warnf := func(format string, a ...any) { warned = append(warned, fmt.Sprintf(format, a...)) }
78 _, err := MavenJobArgsEnv(filepath.Join(t.TempDir(), "s.xml"), "http://127.0.0.1:9999", warnf)
79 require.NoError(t, err)
80 require.Len(t, warned, 1)
81 assert.Contains(t, warned[0], "could not resolve the maven global settings")
82}
84// Not parallel: it sets PATH and MAVEN_ARGS.
85func TestMavenJobArgsEnvWarnsWhenUserSettingsHaveAProxy(t *testing.T) {
86 t.Setenv("PATH", t.TempDir()) // no mvn: skip global-settings resolution
87 userSettings := filepath.Join(t.TempDir(), "settings.xml")
88 require.NoError(t, os.WriteFile(userSettings, []byte(
89 `<settings><proxies><proxy><id>corp</id><active>true</active><protocol>https</protocol><host>proxy.corp</host><port>8080</port></proxy></proxies></settings>`), 0o600))
90 t.Setenv("MAVEN_ARGS", "-s "+userSettings)
92 var warned []string
93 warnf := func(format string, a ...any) { warned = append(warned, fmt.Sprintf(format, a...)) }
94 _, err := MavenJobArgsEnv(filepath.Join(t.TempDir(), "job.xml"), "http://127.0.0.1:9999", warnf)
95 require.NoError(t, err)
96 require.Len(t, warned, 1)
97 assert.Contains(t, warned[0], "may bypass the firewall")
98}
100func TestMavenUserSettingsHasActiveProxy(t *testing.T) {
101 t.Parallel()
102 write := func(t *testing.T, body string) string {
103 t.Helper()
104 p := filepath.Join(t.TempDir(), "settings.xml")
105 require.NoError(t, os.WriteFile(p, []byte(body), 0o600))
106 return p
107 }
108 cases := []struct {
109 name string
110 body string
111 want bool
112 }{
113 {"active proxy", `<settings><proxies><proxy><active>true</active><host>h</host></proxy></proxies></settings>`, true},
114 {"omitted active counts as active", `<settings><proxies><proxy><host>h</host></proxy></proxies></settings>`, true},
115 {"inactive proxy", `<settings><proxies><proxy><active>false</active><host>h</host></proxy></proxies></settings>`, false},
116 {"no proxies", `<settings><mirrors></mirrors></settings>`, false},
117 }
118 for _, tc := range cases {
119 t.Run(tc.name, func(t *testing.T) {
120 t.Parallel()
121 assert.Equal(t, tc.want, mavenUserSettingsHasActiveProxy(write(t, tc.body)))
122 })
123 }
124 t.Run("missing file", func(t *testing.T) {
125 t.Parallel()
126 assert.False(t, mavenUserSettingsHasActiveProxy(filepath.Join(t.TempDir(), "nope.xml")))
127 })
128 t.Run("empty path", func(t *testing.T) {
129 t.Parallel()
130 assert.False(t, mavenUserSettingsHasActiveProxy(""))
131 })
132}
Diagnostics7 git calls · 471 ms
CallStatusSizeTime0471 ms
discover200185 B17 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=17 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB177 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=174 git.response.bytes=59849 git.response.cache=EXPIRED git.response.duration_ms=177 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0200361 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=361 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=361 git.pkt.payload.max=334 git.sideband.band1.bytes=334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=334 git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32Open pack map
fetchtree:02001.3 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=1327 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=2758711b27b3e124482ce287b5df86092bb20d62 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1327 git.pkt.payload.max=1300 git.sideband.band1.bytes=1300 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1300 git.pack.trailer=c83fc6004a9a1360845513c0fb16272b5c14a3e4Open pack map
fetch2001.5 KiB285 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=285 git.response.bytes=1586 git.response.cache=MISS git.response.duration_ms=285 git.fetch.wants=2c8ae3eae099fd87b9a8913216d732fb2bd499e4 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1586 git.pkt.payload.max=1559 git.sideband.band1.bytes=1559 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e1bfe3c80d6c75
- Request
- ddbaf533…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format