GitLabgitlab-org
cli
main
1//go:build !integration
3package pm
5import (
6 "os"
7 "path/filepath"
8 "strings"
9 "testing"
11 "github.com/stretchr/testify/assert"
12 "github.com/stretchr/testify/require"
13)
15// gradleOpts runs Environment then CATrustEnviron and returns the resulting
16// GRADLE_OPTS value (or "" if none was produced).
17func gradleOpts(t *testing.T, proxyURL, caPath string) (string, bool) {
18 t.Helper()
19 m := Gradle()
20 m.Environment(proxyURL)
21 for _, e := range m.CATrustEnviron(caPath) {
22 if v, ok := strings.CutPrefix(e, "GRADLE_OPTS="); ok {
23 return v, true
24 }
25 }
26 return "", false
27}
29// TestGradleCATrustRoutesThroughProxy pins the security-critical routing path.
30// Gradle honors the JVM proxy system properties, so GRADLE_OPTS must carry the
31// -Dhttp(s).proxyHost/proxyPort that route gradle through the inspection proxy
32// as well as the truststore that makes it trust the proxy CA. A regression that
33// dropped the proxy args would fail open, so assert the exact wiring.
34func TestGradleCATrustRoutesThroughProxy(t *testing.T) {
35 ca := selfSignedTestCA(t)
36 caPath := filepath.Join(t.TempDir(), "ca.pem")
37 require.NoError(t, os.WriteFile(caPath, caPEM(t, ca), 0o600))
39 opts, ok := gradleOpts(t, "http://127.0.0.1:52999", caPath)
40 require.True(t, ok, "GRADLE_OPTS must be produced when the proxy resolves")
42 assert.Contains(t, opts, "-Dhttp.proxyHost=127.0.0.1")
43 assert.Contains(t, opts, "-Dhttp.proxyPort=52999")
44 assert.Contains(t, opts, "-Dhttps.proxyHost=127.0.0.1")
45 assert.Contains(t, opts, "-Dhttps.proxyPort=52999")
46 assert.Contains(t, opts, "-Djavax.net.ssl.trustStore=",
47 "the truststore must be trusted alongside the proxy routing")
48}
50// TestGradleCATrustFailsClosedWithoutProxy guards against the fail-open bug:
51// if the proxy URL is missing or unparsable, CATrustEnviron must not emit a
52// truststore-only GRADLE_OPTS (which would make gradle trust the proxy CA while
53// connecting directly, silently bypassing the firewall). It must return nothing.
54func TestGradleCATrustFailsClosedWithoutProxy(t *testing.T) {
55 ca := selfSignedTestCA(t)
56 caPath := filepath.Join(t.TempDir(), "ca.pem")
57 require.NoError(t, os.WriteFile(caPath, caPEM(t, ca), 0o600))
59 // Environment never called: proxyURL is empty.
60 m := Gradle()
61 assert.Empty(t, m.CATrustEnviron(caPath),
62 "no proxy means no GRADLE_OPTS at all, not truststore-only (fail-closed)")
64 // Unparsable / hostless proxy URLs must also fail closed.
65 for _, bad := range []string{"", "://nope", "http://", "not a url"} {
66 _, ok := gradleOpts(t, bad, caPath)
67 assert.Falsef(t, ok, "proxy %q must not yield GRADLE_OPTS", bad)
68 }
69}
Diagnostics7 git calls · 213 ms
CallStatusSizeTime0213 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB10 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=10 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit5 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=5 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchtree:0200361 B · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=361 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=361 git.pkt.payload.max=334 git.sideband.band1.bytes=334 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=334 git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32Open pack map
fetchtree:02001.3 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=1327 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=2758711b27b3e124482ce287b5df86092bb20d62 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1327 git.pkt.payload.max=1300 git.sideband.band1.bytes=1300 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1300 git.pack.trailer=c83fc6004a9a1360845513c0fb16272b5c14a3e4Open pack map
fetch2001.1 KiB194 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=194 git.response.bytes=1175 git.response.cache=MISS git.response.duration_ms=194 git.fetch.wants=982afb74284e96a264b5638c7328bca8f210bbd7 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1175 git.pkt.payload.max=1148 git.sideband.band1.bytes=1148 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e299bffca52407
- Request
- a92f0fbd…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format