GitLabgitlab-org

cli

main
ply7 git calls224 ms96 KiB4 cachedprotocol v2
47 lines1.6 KiBRaw
1//go:build !windows
3package fsx
5import (
6 "os"
7 "path/filepath"
8 "syscall"
9)
11// WithLock runs fn while holding an exclusive advisory lock on a sidecar lock
12// file at lockPath, creating the lock file (and its parent directory) if
13// needed. The lock is released when fn returns.
14//
15// This serializes a read-modify-write sequence across processes. The
16// Dependency Firewall's CI log is updated Load -> Append -> Save, and Save is
17// a whole-file atomic rename; without a lock two concurrent "glab df run"
18// invocations in one job race last-writer-wins, so the losing run's Blocked
19// entries vanish and ci-summary exits 0. Holding this lock across the whole
20// sequence makes the update atomic between processes.
21//
22// The lock is flock(2)-based advisory locking: it only coordinates callers
23// that also take this lock (the firewall does, on the same sidecar path), not
24// arbitrary writers. The sidecar is separate from the log itself so locking
25// never conflicts with the atomic rename that replaces the log inode.
26func WithLock(lockPath string, fn func() error) (err error) {
27 if mkErr := os.MkdirAll(filepath.Dir(lockPath), 0o755); mkErr != nil {
28 return mkErr
29 }
30 f, err := os.OpenFile(lockPath, os.O_CREATE|os.O_RDWR, 0o600)
31 if err != nil {
32 return err
33 }
34 defer func() {
35 // Release then close. Report a close error only if fn succeeded, so a
36 // real failure from fn is not masked by a cleanup error.
37 _ = syscall.Flock(int(f.Fd()), syscall.LOCK_UN)
38 if cerr := f.Close(); cerr != nil && err == nil {
39 err = cerr
40 }
41 }()
43 if lerr := syscall.Flock(int(f.Fd()), syscall.LOCK_EX); lerr != nil {
44 return lerr
45 }
46 return fn()
Diagnostics7 git calls · 224 ms
CallStatusSizeTime0224 ms
discover200185 B3 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=UPDATING
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit6 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=6
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchtree:0200361 B · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=361
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=506cba622ceda1473ee3cde63969809c144b7247
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=361
git.pkt.payload.max=334
git.sideband.band1.bytes=334
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=334
git.pack.trailer=26d32585a3a474717e00a318584ccd16918c9d32
Open pack map
fetchtree:0200256 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=211
git.response.bytes=256
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=75748a4e96b6bf353ebfd55a68dfa7e7557dd079
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=256
git.pkt.payload.max=229
git.sideband.band1.bytes=229
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=229
git.pack.trailer=408da6a74c29650ab3e4fdb9be85188528fb026b
Open pack map
fetch200934 B211 ms
git.upload-pack fetch
http.response.status_code=200
git.response.bytes=934
git.response.cache=MISS
git.response.duration_ms=211
git.fetch.wants=14a3cb48070e5f50a681d21a24520ba982dc3099
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=934
git.pkt.payload.max=907
git.sideband.band1.bytes=907
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e2b7cb1d56cf33
Request
70e5174b…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format