GitLabgitlab-org

cli

main
ply6 git calls218 ms98 KiB4 cachedprotocol v2
109 lines3.5 KiBRaw
1//go:build !integration
3package config
5import (
6 "os"
7 "path/filepath"
8 "testing"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
14func seedFile(t *testing.T, dir, name, content string) {
15 t.Helper()
16 require.NoError(t, os.WriteFile(filepath.Join(dir, name), []byte(content), 0o600))
19// ParseConfig reads the aliases file from the same directory as the main config
20// file, not from a global path.
21func Test_ParseConfig_ReadsAliasesFromInstanceDir(t *testing.T) {
22 t.Parallel()
24 dir := t.TempDir()
25 seedFile(t, dir, "config.yml", "git_protocol: ssh\n")
26 seedFile(t, dir, "aliases.yml", "zzcustom: mr checkout --zz\n")
28 cfg, err := ParseConfig(filepath.Join(dir, "config.yml"))
29 require.NoError(t, err)
31 aliases, err := cfg.Aliases()
32 require.NoError(t, err)
33 got, ok := aliases.Get("zzcustom")
34 assert.True(t, ok, "alias from the instance dir must be loaded")
35 assert.Equal(t, "mr checkout --zz", got)
38// The local config file is merged from an explicit path (production passes the
39// git-based path; tests pass a temp file), so the merge is testable without a
40// real git repository or process-global CWD state.
41func Test_parseConfig_MergesLocalFromExplicitPath(t *testing.T) {
42 t.Parallel()
44 dir := t.TempDir()
45 seedFile(t, dir, "config.yml", "git_protocol: ssh\neditor: vim\n")
46 seedFile(t, dir, "local.yml", "editor: nano\n")
48 cfg, err := parseConfig(filepath.Join(dir, "config.yml"), filepath.Join(dir, "local.yml"))
49 require.NoError(t, err)
51 // local overrides global for non-host keys (searchENVVars=false keeps this
52 // deterministic and parallel-safe regardless of the ambient $EDITOR).
53 editor, _, err := cfg.GetWithSource("", "editor", false)
54 require.NoError(t, err)
55 assert.Equal(t, "nano", editor)
57 // keys absent from local fall back to global
58 proto, _, err := cfg.GetWithSource("", "git_protocol", false)
59 require.NoError(t, err)
60 assert.Equal(t, "ssh", proto)
63// Public ParseConfig does not read a separate (git-based) local config file;
64// callers that want local merging pass the path explicitly via parseConfig.
65func Test_ParseConfig_DoesNotReadSeparateLocalFile(t *testing.T) {
66 t.Parallel()
68 dir := t.TempDir()
69 seedFile(t, dir, "config.yml", "editor: vim\n")
71 cfg, err := ParseConfig(filepath.Join(dir, "config.yml"))
72 require.NoError(t, err)
74 local, err := cfg.Local()
75 require.NoError(t, err)
76 assert.Empty(t, local.All(), "ParseConfig must not merge a separate local file")
79// A local config that exists but cannot be parsed must not be swallowed. If it
80// is, glab silently runs on the global config only and the user believes their
81// per-repository overrides are in effect. The aliases file directly below this
82// merge already reports parse errors this way.
83func Test_parseConfig_ReportsBrokenLocalConfig(t *testing.T) {
84 t.Parallel()
86 dir := t.TempDir()
87 seedFile(t, dir, "config.yml", "git_protocol: ssh\neditor: vim\n")
88 seedFile(t, dir, "local.yml", "editor: [unclosed\n")
90 _, err := parseConfig(filepath.Join(dir, "config.yml"), filepath.Join(dir, "local.yml"))
92 require.Error(t, err)
95// A missing local config is normal: most repositories have no per-repository
96// overrides, so it must stay silent.
97func Test_parseConfig_AllowsMissingLocalConfig(t *testing.T) {
98 t.Parallel()
100 dir := t.TempDir()
101 seedFile(t, dir, "config.yml", "editor: vim\n")
103 cfg, err := parseConfig(filepath.Join(dir, "config.yml"), filepath.Join(dir, "does-not-exist.yml"))
105 require.NoError(t, err)
106 editor, _, err := cfg.GetWithSource("", "editor", false)
107 require.NoError(t, err)
108 assert.Equal(t, "vim", editor)
Diagnostics6 git calls · 218 ms
CallStatusSizeTime0218 ms
discover200185 B2 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=HIT
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:02001.4 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=1391
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=e9da9edfdcf44933ee5fa121d411de326220161c
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1391
git.pkt.payload.max=1364
git.sideband.band1.bytes=1364
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1364
git.pack.trailer=bf750bd385ed98d15e1fea1289d3b00caa61d64c
Open pack map
fetch2001.2 KiB208 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=208
git.response.bytes=1268
git.response.cache=MISS
git.response.duration_ms=208
git.fetch.wants=e49d71c13f1b82f8f5f87d07a2355a60e532c054
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1268
git.pkt.payload.max=1241
git.sideband.band1.bytes=1241
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e204b778d1c69c
Request
acae512b…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format