GitLabgitlab-org
cli
main
1//go:build !integration
3package update
5import (
6 "strings"
7 "testing"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
12 "gitlab.com/gitlab-org/cli/internal/commands/skills/bundled"
13 "gitlab.com/gitlab-org/cli/internal/commands/skills/installed"
14 "gitlab.com/gitlab-org/cli/internal/commands/skills/skill"
15 "gitlab.com/gitlab-org/cli/internal/config"
16 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
17)
19func newSkillCheckConfig(t *testing.T, notifySetting string) config.Config {
20 t.Helper()
21 cfg := config.NewBlankConfig()
22 if notifySetting != "" {
23 require.NoError(t, cfg.Set("", "notify_skill_updates", notifySetting))
24 }
25 return cfg
26}
28// stubDiscovered makes the check functions see a deterministic set of
29// installed skills rather than whatever is on the developer's filesystem.
30func stubDiscovered(t *testing.T, skills []installed.Skill) {
31 t.Helper()
32 old := discoverInstalled
33 discoverInstalled = func() ([]installed.Skill, error) { return skills, nil }
34 t.Cleanup(func() { discoverInstalled = old })
35}
37func bundledStale(name string) installed.Skill {
38 stale := map[string][]byte{"SKILL.md": []byte("totally different")}
39 return installed.Skill{
40 Name: name,
41 Source: skill.SourceBundled,
42 Files: stale,
43 Hash: skill.ContentHash(stale),
44 }
45}
47func TestBundledSkillUpdates_flagsDiverged(t *testing.T) {
48 bs, err := bundled.All()
49 require.NoError(t, err)
50 require.NotEmpty(t, bs)
52 stubDiscovered(t, []installed.Skill{bundledStale(bs[0].Name)})
53 got := bundledSkillUpdates(newSkillCheckConfig(t, ""))
54 assert.Equal(t, []string{bs[0].Name}, got)
55}
57func TestBundledSkillUpdates_ignoresUpToDate(t *testing.T) {
58 bs, err := bundled.All()
59 require.NoError(t, err)
60 require.NotEmpty(t, bs)
62 stubDiscovered(t, []installed.Skill{{
63 Name: bs[0].Name,
64 Source: skill.SourceBundled,
65 Files: bs[0].Files,
66 Hash: skill.ContentHash(bs[0].Files),
67 }})
68 got := bundledSkillUpdates(newSkillCheckConfig(t, ""))
69 assert.Empty(t, got)
70}
72func TestBundledSkillUpdates_ignoresRemoteSourceEntries(t *testing.T) {
73 stubDiscovered(t, []installed.Skill{{
74 Name: "orbit",
75 Source: skill.SourceRemote,
76 Files: map[string][]byte{"SKILL.md": []byte("x")},
77 Hash: skill.ContentHash(map[string][]byte{"SKILL.md": []byte("x")}),
78 }})
79 got := bundledSkillUpdates(newSkillCheckConfig(t, ""))
80 assert.Empty(t, got, "remote-sourced skills should not appear in the bundled check")
81}
83func TestBundledSkillUpdates_configOptOut(t *testing.T) {
84 bs, err := bundled.All()
85 require.NoError(t, err)
86 require.NotEmpty(t, bs)
88 stubDiscovered(t, []installed.Skill{bundledStale(bs[0].Name)})
89 got := bundledSkillUpdates(newSkillCheckConfig(t, "false"))
90 assert.Empty(t, got)
91}
93func TestBundledSkillUpdates_envOptOut(t *testing.T) {
94 t.Setenv("GLAB_NOTIFY_SKILL_UPDATES", "false")
95 bs, err := bundled.All()
96 require.NoError(t, err)
97 require.NotEmpty(t, bs)
99 stubDiscovered(t, []installed.Skill{bundledStale(bs[0].Name)})
100 got := bundledSkillUpdates(newSkillCheckConfig(t, ""))
101 assert.Empty(t, got)
102}
104func TestBundledSkillUpdates_deduplicatesAcrossScopes(t *testing.T) {
105 bs, err := bundled.All()
106 require.NoError(t, err)
107 require.NotEmpty(t, bs)
108 stale := map[string][]byte{"SKILL.md": []byte("stale")}
110 stubDiscovered(t, []installed.Skill{
111 {
112 Name: bs[0].Name,
113 Source: skill.SourceBundled,
114 Scope: installed.ScopeProject,
115 Files: stale,
116 Hash: skill.ContentHash(stale),
117 },
118 {
119 Name: bs[0].Name,
120 Source: skill.SourceBundled,
121 Scope: installed.ScopeGlobal,
122 Files: stale,
123 Hash: skill.ContentHash(stale),
124 },
125 })
126 got := bundledSkillUpdates(newSkillCheckConfig(t, ""))
127 assert.Equal(t, []string{bs[0].Name}, got, "same name in two scopes should only appear once")
128}
130func TestWriteSkillUpdateBlock_singularAndPlural(t *testing.T) {
131 ios, _, _, stderr := cmdtest.TestIOStreams(cmdtest.WithTestIOStreamsAsTTY(false))
133 writeSkillUpdateBlock(ios, nil)
134 assert.Empty(t, stderr.String())
136 stderr.Reset()
137 writeSkillUpdateBlock(ios, []string{"glab"})
138 got := stderr.String()
139 assert.Contains(t, got, "Agent skill updates available")
140 assert.Contains(t, got, " glab\n")
141 assert.Contains(t, got, " Run: glab skills update glab\n")
143 stderr.Reset()
144 writeSkillUpdateBlock(ios, []string{"glab", "glab-stack"})
145 got = stderr.String()
146 assert.Contains(t, got, "Agent skill updates available")
147 assert.Contains(t, got, " glab, glab-stack\n")
148 assert.Contains(t, got, " Run: glab skills update --all\n")
149}
151func TestWriteSkillUpdateBlock_leadingBlankLineSeparatesFromPriorOutput(t *testing.T) {
152 ios, _, _, stderr := cmdtest.TestIOStreams(cmdtest.WithTestIOStreamsAsTTY(false))
153 writeSkillUpdateBlock(ios, []string{"glab"})
154 assert.True(t, strings.HasPrefix(stderr.String(), "\n"),
155 "block should begin with a blank line so it doesn't cram against preceding stderr output")
156}
Diagnostics7 git calls · 291 ms
CallStatusSizeTime0291 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200329 B · hit5 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=5 git.response.bytes=329 git.response.cache=HIT git.response.duration_ms=5 git.fetch.filter=tree:0 git.fetch.wants=8b36f3db012b2c3ab0120649b10a85336c3bf03e git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=329 git.pkt.payload.max=302 git.sideband.band1.bytes=302 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=302 git.pack.trailer=616b294f8a6e9b6163f51633333a4ad7b16f0d98Open pack map
fetch2001.3 KiB276 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=276 git.response.bytes=1342 git.response.cache=MISS git.response.duration_ms=276 git.fetch.wants=2111b228bae5f001fc92c3500a495acdfc14b9bb git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1342 git.pkt.payload.max=1315 git.sideband.band1.bytes=1315 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e29bbb089bc465
- Request
- 80b730ab…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format