GitLabgitlab-org
cli
main
1package update
3import (
4 "fmt"
5 "strings"
7 "github.com/hashicorp/go-version"
9 "gitlab.com/gitlab-org/cli/internal/api"
10 "gitlab.com/gitlab-org/cli/internal/config"
11 "gitlab.com/gitlab-org/cli/internal/dbg"
12 "gitlab.com/gitlab-org/cli/internal/iostreams"
13)
15const LastSeenVersionKey = "last_seen_version"
17// MaybeShowPostUpgradeBanner prints a one-time nudge pointing at
18// `glab whatsnew` whenever buildInfo.Version is newer than the recorded
19// LastSeenVersionKey marker. The default for LastSeenVersionKey is seeded
20// in defaultFor() so existing users see the banner the first time they
21// run the release that ships this feature. It stays silent in CI and when
22// stderr is not a terminal, where a fresh config would otherwise print it on
23// every run.
24func MaybeShowPostUpgradeBanner(io *iostreams.IOStreams, cfg config.Config, buildInfo api.BuildInfo) {
25 maybeShowPostUpgradeBanner(io, cfg, buildInfo, config.InCI())
26}
28func maybeShowPostUpgradeBanner(io *iostreams.IOStreams, cfg config.Config, buildInfo api.BuildInfo, inCI bool) {
29 if !isWhatsNewEnabled(cfg) {
30 return
31 }
32 if buildInfo.CodingAgent != "" || inCI || !io.IsErrTTY {
33 return
34 }
36 currentVersion := strings.TrimSpace(buildInfo.Version)
37 current, err := version.NewVersion(currentVersion)
38 if err != nil {
39 dbg.Debugf("post-upgrade banner: skipping unparseable buildInfo.Version %q: %s", currentVersion, err)
40 return
41 }
43 lastSeen, err := cfg.Get("", LastSeenVersionKey)
44 if err != nil {
45 return
46 }
47 lastSeen = strings.TrimSpace(lastSeen)
49 seen, err := version.NewVersion(lastSeen)
50 if err != nil || !current.GreaterThan(seen) {
51 return
52 }
54 c := io.Color()
55 // Leading blank line separates the banner from whatever the user's
56 // actual command printed, so e.g. `glab mr list` output and the nudge
57 // don't run together.
58 io.LogError("")
59 io.LogError(c.Yellow(fmt.Sprintf("What's new in glab %s", currentVersion)))
60 io.LogError(" Run: glab whatsnew")
62 // An upgrade is the only moment a new bundled-skill payload becomes
63 // available, so the skill check piggybacks on the banner.
64 writeSkillUpdateBlock(io, bundledSkillUpdates(cfg))
66 if err := SetLastSeenVersion(cfg, currentVersion); err != nil {
67 // Best-effort: if we can't persist, the banner repeats next run —
68 // don't disrupt the user's actual command for it.
69 io.LogErrorf(" (could not update %s: %s)\n", LastSeenVersionKey, err)
70 }
71}
73func SetLastSeenVersion(cfg config.Config, v string) error {
74 if err := cfg.Set("", LastSeenVersionKey, v); err != nil {
75 return err
76 }
77 return cfg.Write()
78}
80func isWhatsNewEnabled(cfg config.Config) bool {
81 // cfg.Get already consults GLAB_SHOW_WHATS_NEW via EnvKeyEquivalence.
82 val, err := cfg.Get("", "show_whats_new")
83 if err != nil || val == "" {
84 return true
85 }
86 switch strings.ToLower(strings.TrimSpace(val)) {
87 case "false", "no", "n", "0":
88 return false
89 }
90 return true
91}
Diagnostics7 git calls · 227 ms
CallStatusSizeTime0227 ms
discover200185 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=7 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit7 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=7 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200329 B · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=211 git.response.bytes=329 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=8b36f3db012b2c3ab0120649b10a85336c3bf03e git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=329 git.pkt.payload.max=302 git.sideband.band1.bytes=302 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=302 git.pack.trailer=616b294f8a6e9b6163f51633333a4ad7b16f0d98Open pack map
fetch2001.3 KiB211 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1300 git.response.cache=MISS git.response.duration_ms=211 git.fetch.wants=e80acb8685cf4f9a7b901aa8fb0238bd90a50a3c git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1300 git.pkt.payload.max=1273 git.sideband.band1.bytes=1273 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2ac466c72e6b0
- Request
- 3e22e599…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format