GitLabgitlab-org
cli
main
1//go:build !integration
3package done
5import (
6 "net/http"
7 "testing"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
12 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
13 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
15 "gitlab.com/gitlab-org/cli/internal/api"
16 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
17)
19func TestTodoDone(t *testing.T) {
20 t.Parallel()
21 type testCase struct {
22 name string
23 cli string
24 expectedOut string
25 wantErr bool
26 expectedError string
27 setupMock func(tc *gitlabtesting.TestClient)
28 }
30 testCases := []testCase{
31 {
32 name: "marks a single todo as done by ID",
33 cli: "42",
34 expectedOut: "✓ To-do item 42 marked as done.\n",
35 setupMock: func(tc *gitlabtesting.TestClient) {
36 tc.MockTodos.EXPECT().
37 MarkTodoAsDone(int64(42)).
38 Return(&gitlab.Response{Response: &http.Response{StatusCode: http.StatusOK}}, nil)
39 },
40 },
41 {
42 name: "marks all todos as done with --all",
43 cli: "--all",
44 expectedOut: "✓ All to-do items marked as done.\n",
45 setupMock: func(tc *gitlabtesting.TestClient) {
46 tc.MockTodos.EXPECT().
47 MarkAllTodosAsDone().
48 Return(&gitlab.Response{Response: &http.Response{StatusCode: http.StatusNoContent}}, nil)
49 },
50 },
51 {
52 name: "errors when no ID and no --all flag",
53 cli: "",
54 wantErr: true,
55 expectedError: "either a to-do ID or --all is required",
56 setupMock: func(tc *gitlabtesting.TestClient) {},
57 },
58 {
59 name: "errors when both ID and --all are provided",
60 cli: "42 --all",
61 wantErr: true,
62 expectedError: "--all cannot be used with a to-do ID",
63 setupMock: func(tc *gitlabtesting.TestClient) {},
64 },
65 {
66 name: "errors when ID is not a valid number",
67 cli: "not-a-number",
68 wantErr: true,
69 expectedError: `invalid to-do ID: "not-a-number"`,
70 setupMock: func(tc *gitlabtesting.TestClient) {},
71 },
72 }
74 for _, tc := range testCases {
75 t.Run(tc.name, func(t *testing.T) {
76 t.Parallel()
77 // GIVEN
78 testClient := gitlabtesting.NewTestClient(t)
79 tc.setupMock(testClient)
80 exec := cmdtest.SetupCmdForTest(
81 t,
82 NewCmd,
83 false,
84 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(testClient.Client))),
85 )
87 // WHEN
88 out, err := exec(tc.cli)
90 // THEN
91 if tc.wantErr {
92 require.Error(t, err)
93 if tc.expectedError != "" {
94 assert.Contains(t, err.Error(), tc.expectedError)
95 }
96 return
97 }
98 require.NoError(t, err)
99 assert.Equal(t, tc.expectedOut, out.OutBuf.String())
100 assert.Empty(t, out.ErrBuf.String())
101 })
102 }
103}
Diagnostics8 git calls · 226 ms
CallStatusSizeTime0226 ms
discover200185 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200165 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=165 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=c6bf531ba0613331e49d2faa099cd3466613e7b8 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=165 git.pkt.payload.max=138 git.sideband.band1.bytes=138 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=138 git.pack.trailer=a34ae15f8bc51d95314a64e29216fc88a5c857b0Open pack map
fetchtree:0200136 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=136 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=836c5589030d35f1d5bc209023dac04008ed4aef git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=136 git.pkt.payload.max=109 git.sideband.band1.bytes=109 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=109 git.pack.trailer=d8d982a475baca4ad468b62d2e0eee505c54910cOpen pack map
fetch2001.0 KiB211 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=211 git.response.bytes=1028 git.response.cache=MISS git.response.duration_ms=211 git.fetch.wants=f4dce738168347459e0fcd0cad86987b12769cf0 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1028 git.pkt.payload.max=1001 git.sideband.band1.bytes=1001 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2e53f98ac2947
- Request
- 033fb5f9…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format