GitLabgitlab-org

cli

main
ply8 git calls341 ms99 KiB5 cachedprotocol v2
218 lines6.2 KiBRaw
1//go:build !integration
3package delete
5import (
6 "os"
7 "path/filepath"
8 "testing"
10 "git.sr.ht/~timofurrer/ugh"
11 "github.com/stretchr/testify/require"
13 "gitlab.com/gitlab-org/cli/internal/cmdutils"
14 "gitlab.com/gitlab-org/cli/internal/git"
15 "gitlab.com/gitlab-org/cli/internal/iostreams"
16 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
19// stackDir returns the metadata directory a stack of this name would occupy,
20// whether or not it currently exists.
21func stackDir(t *testing.T, name string) string {
22 t.Helper()
24 stackLoc, err := git.StackLocation()
25 require.NoError(t, err)
27 return filepath.Join(stackLoc, name)
30func TestDeleteWithStackName(t *testing.T) {
31 git.InitGitRepo(t)
32 _, err := git.AddStackRefDir("doomed-stack")
33 require.NoError(t, err)
34 _, err = git.AddStackRefDir("keeper-stack")
35 require.NoError(t, err)
37 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true)
39 output, err := exec("doomed-stack --yes")
41 require.NoError(t, err)
42 require.Equal(t, "Deleted stack doomed-stack.\n", output.String())
43 require.NoDirExists(t, stackDir(t, "doomed-stack"))
44 require.DirExists(t, stackDir(t, "keeper-stack"))
47func TestDeleteWithoutPromptsSucceedsWithNameAndConfirmationFlag(t *testing.T) {
48 git.InitGitRepo(t)
49 _, err := git.AddStackRefDir("doomed-stack")
50 require.NoError(t, err)
52 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, false)
54 output, err := exec("doomed-stack --yes")
56 require.NoError(t, err)
57 require.Equal(t, "Deleted stack doomed-stack.\n", output.String())
58 require.NoDirExists(t, stackDir(t, "doomed-stack"))
61func TestDeleteClearsTheCurrentStack(t *testing.T) {
62 git.InitGitRepo(t)
63 _, err := git.AddStackRefDir("current-stack")
64 require.NoError(t, err)
65 require.NoError(t, git.SetCurrentStackTitle("current-stack"))
67 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true)
69 _, err = exec("current-stack --yes")
70 require.NoError(t, err)
72 _, err = git.GetCurrentStackTitle()
73 require.Error(t, err, "current stack should have been cleared")
76func TestDeleteClearsTheLegacyCurrentStack(t *testing.T) {
77 git.InitGitRepo(t)
78 _, err := git.AddStackRefDir("current-stack")
79 require.NoError(t, err)
80 require.NoError(t, git.SetLocalConfig("glab.currentstack", "current-stack"))
82 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true)
84 _, err = exec("current-stack --yes")
85 require.NoError(t, err)
87 _, err = git.GetCurrentStackTitle()
88 require.Error(t, err, "current stack should have been cleared")
90 _, err = git.Config("glab.currentstack")
91 require.Error(t, err, "glab.currentstack should have been unset")
94func TestDeleteKeepsTheCurrentStackWhenDeletingAnother(t *testing.T) {
95 git.InitGitRepo(t)
96 _, err := git.AddStackRefDir("current-stack")
97 require.NoError(t, err)
98 _, err = git.AddStackRefDir("other-stack")
99 require.NoError(t, err)
100 require.NoError(t, git.SetCurrentStackTitle("current-stack"))
102 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true)
104 _, err = exec("other-stack --yes")
105 require.NoError(t, err)
107 currentStack, err := git.GetCurrentStackTitle()
108 require.NoError(t, err)
109 require.Equal(t, "current-stack", currentStack)
112func TestDeleteFailsWhenTheCurrentStackCannotBeRead(t *testing.T) {
113 git.InitGitRepo(t)
114 _, err := git.AddStackRefDir("current-stack")
115 require.NoError(t, err)
116 gitDir, err := git.GitDir()
117 require.NoError(t, err)
118 require.NoError(t, os.Mkdir(filepath.Join(gitDir, "GLAB_CURRENT_STACK"), 0o755))
120 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true)
122 _, err = exec("current-stack --yes")
123 require.ErrorContains(t, err, "reading current stack")
124 require.DirExists(t, stackDir(t, "current-stack"))
127func TestDeletePromptsForStackNameAndConfirmation(t *testing.T) {
128 git.InitGitRepo(t)
129 _, err := git.AddStackRefDir("first-stack")
130 require.NoError(t, err)
131 _, err = git.AddStackRefDir("second-stack")
132 require.NoError(t, err)
134 c := ugh.New(t)
135 c.Expect(ugh.Select("Choose a stack to delete:")).
136 Do(ugh.SelectIndex(1))
137 c.Expect(ugh.Confirm("Delete stack second-stack?")).
138 Do(ugh.Affirm)
140 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true, cmdtest.WithConsole(t, c))
142 output, err := exec("")
144 require.NoError(t, err)
145 require.Contains(t, output.String(), "Deleted stack second-stack.\n")
146 require.NoDirExists(t, stackDir(t, "second-stack"))
147 require.DirExists(t, stackDir(t, "first-stack"))
150func TestDeleteDecliningTheConfirmationKeepsTheStack(t *testing.T) {
151 git.InitGitRepo(t)
152 _, err := git.AddStackRefDir("spared-stack")
153 require.NoError(t, err)
155 c := ugh.New(t)
156 c.Expect(ugh.Confirm("Delete stack spared-stack?")).
157 Do(ugh.Reject)
159 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true, cmdtest.WithConsole(t, c))
161 _, err = exec("spared-stack")
163 require.ErrorIs(t, err, iostreams.ErrUserCancelled)
164 require.EqualError(t, err, "user cancelled")
165 require.DirExists(t, stackDir(t, "spared-stack"))
168func TestDeleteWithoutConfirmationFlagRequiresPrompts(t *testing.T) {
169 git.InitGitRepo(t)
170 _, err := git.AddStackRefDir("a-stack")
171 require.NoError(t, err)
173 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, false)
175 _, err = exec("a-stack")
177 var flagErr cmdutils.FlagError
178 require.ErrorAs(t, err, &flagErr)
179 require.EqualError(t, err, "--yes or -y flag is required when not running interactively")
180 require.DirExists(t, stackDir(t, "a-stack"))
183func TestDeleteWithoutStackNameRequiresPrompts(t *testing.T) {
184 git.InitGitRepo(t)
185 _, err := git.AddStackRefDir("a-stack")
186 require.NoError(t, err)
188 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, false)
190 _, err = exec("--yes")
192 var flagErr cmdutils.FlagError
193 require.ErrorAs(t, err, &flagErr)
194 require.EqualError(t, err, "the <stack-name> argument is required when prompts are disabled")
197func TestDeleteWithUnknownStackName(t *testing.T) {
198 git.InitGitRepo(t)
199 _, err := git.AddStackRefDir("a-stack")
200 require.NoError(t, err)
202 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true)
204 _, err = exec("not-a-stack --yes")
206 require.EqualError(t, err, "deleting stack failed: no stack named \"not-a-stack\" found")
207 require.DirExists(t, stackDir(t, "a-stack"))
210func TestDeleteWithoutAnyStacks(t *testing.T) {
211 git.InitGitRepo(t)
213 exec := cmdtest.SetupCmdForTest(t, NewCmdDeleteStack, true)
215 _, err := exec("--yes")
217 require.EqualError(t, err, "deleting stack failed: no stacks found; create one with \"glab stack create\"")
Diagnostics8 git calls · 341 ms
CallStatusSizeTime0341 ms
discover200185 B3 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=UPDATING
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200432 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=432
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=ff2d1e7abc74964e5679ebdb51f1ac0d0dc3aff0
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=432
git.pkt.payload.max=405
git.sideband.band1.bytes=405
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=405
git.pack.trailer=8f3029a269217d94d12d0671e0490fe3d5506303
Open pack map
fetchtree:0200144 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=325
git.response.bytes=144
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=a9671173857fdf27e1a1fe66cc3b47ec8aaea508
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=144
git.pkt.payload.max=117
git.sideband.band1.bytes=117
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=117
git.pack.trailer=8258e60188cdbd99cac86c39f849cee8a2cf4d7e
Open pack map
fetch2001.3 KiB325 ms
git.upload-pack fetch
http.response.status_code=200
git.response.bytes=1367
git.response.cache=MISS
git.response.duration_ms=325
git.fetch.wants=276302f5382c606de764ba1eec8afd432cb5f51a
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1367
git.pkt.payload.max=1340
git.sideband.band1.bytes=1340
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e197e9286cb86e
Request
6bf0b33b…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format