GitLabgitlab-org

cli

main
ply8 git calls222 ms99 KiB5 cachedprotocol v2
119 lines3.3 KiBRaw
1//go:build !integration
3package create
5import (
6 "path"
7 "testing"
9 "git.sr.ht/~timofurrer/ugh"
10 "github.com/spf13/cobra"
11 "github.com/stretchr/testify/require"
12 "go.uber.org/mock/gomock"
14 "gitlab.com/gitlab-org/cli/internal/cmdutils"
15 "gitlab.com/gitlab-org/cli/internal/config"
16 "gitlab.com/gitlab-org/cli/internal/git"
17 git_testing "gitlab.com/gitlab-org/cli/internal/git/testing"
18 "gitlab.com/gitlab-org/cli/internal/glinstance"
19 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
22func TestCreateNewStack(t *testing.T) {
23 // NOTE: we need to force disable colors, otherwise we'd need ANSI sequences in our test output assertions.
24 t.Setenv("NO_COLOR", "true")
26 tests := []struct {
27 desc string
28 branch string
29 expectedBranch string
30 baseBranch string
31 warning bool
32 needsResponder bool
33 responderInput string
34 }{
35 {
36 desc: "basic method",
37 branch: "test description here",
38 baseBranch: "main",
39 expectedBranch: "test-description-here",
40 warning: false,
41 needsResponder: false,
42 },
43 {
44 desc: "empty string",
45 branch: "",
46 baseBranch: "master",
47 expectedBranch: "oh-ok-fine-how-about-blah-blah",
48 warning: true,
49 needsResponder: true,
50 responderInput: "oh ok fine how about blah blah",
51 },
52 {
53 desc: "weird characters git won't like",
54 branch: "hey@#$!^$#)()*1234hmm",
55 baseBranch: "hello",
56 expectedBranch: "hey-1234hmm",
57 warning: true,
58 needsResponder: false,
59 },
60 }
62 for _, tc := range tests {
63 t.Run(tc.desc, func(t *testing.T) {
64 tempDir := git.InitGitRepo(t)
66 ctrl := gomock.NewController(t)
67 mockCmd := git_testing.NewMockGitRunner(ctrl)
68 mockCmd.EXPECT().Git([]string{"symbolic-ref", "--quiet", "--short", "HEAD"}).Return(tc.baseBranch, nil)
70 opts := []cmdtest.FactoryOption{
71 cmdtest.WithGitLabClient(cmdtest.NewTestApiClient(t, nil, "", glinstance.DefaultHostname).Lab()),
72 }
73 if tc.needsResponder {
74 c := ugh.New(t)
75 c.Expect(ugh.Input("New stack title?")).
76 Do(ugh.Type(tc.responderInput))
77 opts = append(opts, cmdtest.WithConsole(t, c))
78 }
80 exec := cmdtest.SetupCmdForTest(t, func(f cmdutils.Factory) *cobra.Command {
81 return NewCmdCreateStack(f, mockCmd)
82 }, true, opts...)
84 output, err := exec(tc.branch)
86 require.NoError(t, err)
88 // When using responder, output may contain ANSI codes from huh prompt, so use Contains
89 if tc.needsResponder {
90 require.Contains(t, output.String(), "New stack created with title \""+tc.expectedBranch+"\".\n")
91 } else {
92 require.Equal(t, "New stack created with title \""+tc.expectedBranch+"\".\n", output.String())
93 }
95 if tc.warning == true {
96 require.Equal(t, "! warning: invalid characters have been replaced with dashes: "+tc.expectedBranch+"\n", output.Stderr())
97 } else {
98 require.Empty(t, output.Stderr())
99 }
101 configValue, err := git.GetCurrentStackTitle()
102 require.NoError(t, err)
104 createdBaseFile := path.Join(
105 tempDir,
106 "/.git/stacked/",
107 tc.expectedBranch,
108 git.BaseBranchFile,
109 )
111 fileContents, err := config.TrimmedFileContents(createdBaseFile)
112 require.NoError(t, err)
114 require.Equal(t, tc.baseBranch, fileContents)
115 require.Equal(t, tc.expectedBranch, configValue)
116 require.FileExists(t, createdBaseFile)
117 })
118 }
Diagnostics8 git calls · 222 ms
CallStatusSizeTime0222 ms
discover200185 B3 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB3 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=3
git.response.bytes=59849
git.response.cache=UPDATING
git.response.duration_ms=3
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchtree:02001.8 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200432 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=432
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=ff2d1e7abc74964e5679ebdb51f1ac0d0dc3aff0
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=432
git.pkt.payload.max=405
git.sideband.band1.bytes=405
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=405
git.pack.trailer=8f3029a269217d94d12d0671e0490fe3d5506303
Open pack map
fetchtree:0200145 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=208
git.response.bytes=145
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=bb53f04233a657802080a72acbea0331a76f5df4
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=145
git.pkt.payload.max=118
git.sideband.band1.bytes=118
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=118
git.pack.trailer=9aae38fdc630a3d715646e789f20b947a03e45ce
Open pack map
fetch2001.4 KiB208 ms
git.upload-pack fetch
http.response.status_code=200
git.response.bytes=1421
git.response.cache=MISS
git.response.duration_ms=208
git.fetch.wants=834b91b92e28d3dcc8e43d6c2693f3f827341b9f
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1421
git.pkt.payload.max=1394
git.sideband.band1.bytes=1394
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e15a2598bfcf6a
Request
f98dd1e4…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format