GitLabgitlab-org

cli

main
ply8 git calls249 ms98 KiB5 cachedprotocol v2
119 lines3.6 KiBRaw
1//go:build !integration
3package installed
5import (
6 "os"
7 "path/filepath"
8 "testing"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
13 "gitlab.com/gitlab-org/cli/internal/commands/skills/skill"
16// stubLocations points the discovery walker at the supplied scratch
17// dirs instead of the developer's real ~/ and repo root.
18func stubLocations(t *testing.T, locs ...location) {
19 t.Helper()
20 old := candidateLocationsFn
21 candidateLocationsFn = func() []location { return locs }
22 t.Cleanup(func() { candidateLocationsFn = old })
25// writeSkill seeds a single skill directory under dir with the given files.
26func writeSkill(t *testing.T, dir, name string, files map[string]string) {
27 t.Helper()
28 skillDir := filepath.Join(dir, name)
29 require.NoError(t, os.MkdirAll(skillDir, 0o755))
30 for rel, body := range files {
31 p := filepath.Join(skillDir, filepath.FromSlash(rel))
32 require.NoError(t, os.MkdirAll(filepath.Dir(p), 0o755))
33 require.NoError(t, os.WriteFile(p, []byte(body), 0o644))
34 }
37func TestDiscover_findsKnownBundledSkill(t *testing.T) {
38 scratch := t.TempDir()
39 writeSkill(t, scratch, "glab", map[string]string{
40 "SKILL.md": "stale content",
41 "references/x": "extra",
42 })
43 stubLocations(t, location{dir: scratch, scope: ScopeProject})
45 got, err := Discover()
46 require.NoError(t, err)
47 require.Len(t, got, 1)
48 assert.Equal(t, "glab", got[0].Name)
49 assert.Equal(t, ScopeProject, got[0].Scope)
50 assert.Equal(t, skill.SourceBundled, got[0].Source)
51 assert.NotEmpty(t, got[0].Hash)
52 assert.Equal(t, "stale content", string(got[0].Files["SKILL.md"]))
55func TestDiscover_ignoresUnknownDirectories(t *testing.T) {
56 scratch := t.TempDir()
57 writeSkill(t, scratch, "user-authored", map[string]string{"SKILL.md": "anything"})
58 stubLocations(t, location{dir: scratch, scope: ScopeProject})
60 got, err := Discover()
61 require.NoError(t, err)
62 assert.Empty(t, got)
65func TestDiscover_ignoresDotGlabDirectory(t *testing.T) {
66 scratch := t.TempDir()
67 writeSkill(t, scratch, ".glab", map[string]string{"bookkeeping.json": "{}"})
68 stubLocations(t, location{dir: scratch, scope: ScopeProject})
70 got, err := Discover()
71 require.NoError(t, err)
72 assert.Empty(t, got)
75func TestDiscover_missingLocationsAreNotErrors(t *testing.T) {
76 stubLocations(t, location{dir: filepath.Join(t.TempDir(), "does-not-exist"), scope: ScopeProject})
78 got, err := Discover()
79 require.NoError(t, err)
80 assert.Empty(t, got)
83func TestDiscover_walksMultipleLocations(t *testing.T) {
84 project := t.TempDir()
85 global := t.TempDir()
86 writeSkill(t, project, "glab", map[string]string{"SKILL.md": "p"})
87 writeSkill(t, global, "glab-stack", map[string]string{"SKILL.md": "g"})
88 stubLocations(t,
89 location{dir: project, scope: ScopeProject},
90 location{dir: global, scope: ScopeGlobal},
91 )
93 got, err := Discover()
94 require.NoError(t, err)
95 require.Len(t, got, 2)
96 // Sorted by name.
97 assert.Equal(t, "glab", got[0].Name)
98 assert.Equal(t, ScopeProject, got[0].Scope)
99 assert.Equal(t, "glab-stack", got[1].Name)
100 assert.Equal(t, ScopeGlobal, got[1].Scope)
103func TestDiscover_sameNameInBothScopes(t *testing.T) {
104 project := t.TempDir()
105 global := t.TempDir()
106 writeSkill(t, project, "glab", map[string]string{"SKILL.md": "project"})
107 writeSkill(t, global, "glab", map[string]string{"SKILL.md": "global"})
108 stubLocations(t,
109 location{dir: project, scope: ScopeProject},
110 location{dir: global, scope: ScopeGlobal},
111 )
113 got, err := Discover()
114 require.NoError(t, err)
115 require.Len(t, got, 2)
116 // Same name, sorted by scope ("global" < "project" lexicographically).
117 assert.Equal(t, ScopeGlobal, got[0].Scope)
118 assert.Equal(t, ScopeProject, got[1].Scope)
Diagnostics8 git calls · 249 ms
CallStatusSizeTime0249 ms
discover200185 B3 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=3
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB3 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=UPDATING
git.response.duration_ms=3
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchtree:02001.8 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200370 B · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=370
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=290ae7a62f76e23cbbd60697570f19b90ddcece6
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=370
git.pkt.payload.max=343
git.sideband.band1.bytes=343
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=343
git.pack.trailer=0795a26d2b25022c69da2ef2e68cfb92a77ef4bb
Open pack map
fetchtree:0200142 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=142
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=33a5560ee59c30509045038242d8fca78f7aaadf
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=142
git.pkt.payload.max=115
git.sideband.band1.bytes=115
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=115
git.pack.trailer=d610055c1027ea34a793c846e9b4688be22ac34a
Open pack map
fetch2001.1 KiB234 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=234
git.response.bytes=1128
git.response.cache=MISS
git.response.duration_ms=234
git.fetch.wants=f7e0c4ea9ecbb31d49edde3f93eed64a7e2b8d05
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1128
git.pkt.payload.max=1101
git.sideband.band1.bytes=1101
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e2cfef68cdefad
Request
d78de3a6…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format