GitLabgitlab-org
cli
main
1//go:build !integration
3package get
5import (
6 "fmt"
7 "testing"
9 "github.com/spf13/cobra"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
13 "gitlab.com/gitlab-org/cli/internal/cmdutils"
14 "gitlab.com/gitlab-org/cli/internal/commands/skills/bundled"
15 "gitlab.com/gitlab-org/cli/internal/commands/skills/skill"
16 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
17)
19func TestNewCmd_DefaultAndExplicitManifestMatch(t *testing.T) {
20 t.Parallel()
22 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
23 defaultOut, err := exec("glab")
24 require.NoError(t, err)
26 exec = cmdtest.SetupCmdForTest(t, NewCmd, false)
27 explicitOut, err := exec("glab SKILL.md")
28 require.NoError(t, err)
30 assert.Equal(t, defaultOut.String(), explicitOut.String())
31 assert.Contains(t, defaultOut.String(), "name: glab")
32 assert.Empty(t, defaultOut.Stderr())
33}
35func TestNewCmd_SingleFileManifestHasNoFooter(t *testing.T) {
36 t.Parallel()
38 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
39 out, err := exec("glab")
41 require.NoError(t, err)
42 assert.NotContains(t, out.String(), "You are viewing this via `glab`")
43}
45func TestNewCmd_MultiFileFooterOnlyOnManifest(t *testing.T) {
46 t.Parallel()
48 s := skill.Skill{
49 Name: "example",
50 Files: map[string][]byte{
51 "SKILL.md": []byte("manifest\n"),
52 "scripts/run.sh": []byte("#!/bin/sh\necho hello\n"),
53 "references/api.md": []byte("API reference\n"),
54 },
55 }
56 newTestCmd := func(f cmdutils.Factory) *cobra.Command {
57 return newCmd(f,
58 func(name string) (skill.Skill, error) {
59 if name == s.Name {
60 return s, nil
61 }
62 return skill.Skill{}, fmt.Errorf("%w: %s", bundled.ErrNotFound, name)
63 },
64 func() ([]skill.Skill, error) { return []skill.Skill{s}, nil },
65 )
66 }
68 exec := cmdtest.SetupCmdForTest(t, newTestCmd, false)
69 manifestOut, err := exec("example")
70 require.NoError(t, err)
71 assert.Contains(t, manifestOut.String(), "Fetch referenced files with `glab skills get example <path>`.")
72 assert.NotContains(t, manifestOut.String(), "e.g.")
74 exec = cmdtest.SetupCmdForTest(t, newTestCmd, false)
75 scriptOut, err := exec("example scripts/run.sh")
76 require.NoError(t, err)
77 assert.Equal(t, "#!/bin/sh\necho hello\n", scriptOut.String())
78 assert.NotContains(t, scriptOut.String(), "You are viewing this via")
79}
81func TestNewCmd_StartsPagerAfterLookup(t *testing.T) {
82 t.Parallel()
84 for _, tt := range []struct {
85 name string
86 args string
87 wantErr string
88 }{
89 {name: "known file", args: "glab", wantErr: "EOF found when expecting closing quote"},
90 {name: "unknown file", args: "glab missing.md", wantErr: `unknown path "missing.md"`},
91 } {
92 t.Run(tt.name, func(t *testing.T) {
93 t.Parallel()
95 io, _, _, _ := cmdtest.TestIOStreams(cmdtest.WithTestIOStreamsAsTTY(true))
96 io.SetPager(`"`)
97 exec := cmdtest.SetupCmdForTest(t, NewCmd, true, cmdtest.WithIOStreamsOverride(io))
98 out, err := exec(tt.args)
100 require.Error(t, err)
101 assert.Contains(t, err.Error(), tt.wantErr)
102 assert.Empty(t, out.String())
103 })
104 }
105}
107func TestNewCmd_UnknownName(t *testing.T) {
108 t.Parallel()
110 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
111 out, err := exec("unknown")
113 require.Error(t, err)
114 assert.Equal(t, "unknown skill \"unknown\"; only bundled skills can be printed (available: glab, glab-stack), and remote skills from 'glab skills list' can be installed with 'glab skills install <name>'", err.Error())
115 assert.Empty(t, out.String())
116}
118func TestNewCmd_MissingName(t *testing.T) {
119 t.Parallel()
121 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
122 out, err := exec("")
124 require.Error(t, err)
125 assert.Contains(t, err.Error(), "skill name is required")
126 assert.Contains(t, err.Error(), "available bundled skills: glab, glab-stack")
127 assert.Empty(t, out.String())
128}
130func TestNewCmd_UnknownPath(t *testing.T) {
131 t.Parallel()
133 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
134 out, err := exec("glab missing.md")
136 require.Error(t, err)
137 assert.Contains(t, err.Error(), `unknown path "missing.md"`)
138 assert.Contains(t, err.Error(), "available files: SKILL.md")
139 assert.Empty(t, out.String())
140}
142func TestNewCmd_UnknownAbsoluteAndTraversalPaths(t *testing.T) {
143 t.Parallel()
145 for _, filePath := range []string{"../x", "/abs"} {
146 t.Run(filePath, func(t *testing.T) {
147 t.Parallel()
149 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
150 out, err := exec("glab " + filePath)
152 require.Error(t, err)
153 assert.Contains(t, err.Error(), fmt.Sprintf("unknown path %q", filePath))
154 assert.Contains(t, err.Error(), "available files: SKILL.md")
155 assert.Empty(t, out.String())
156 })
157 }
158}
Diagnostics8 git calls · 400 ms
CallStatusSizeTime0400 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200370 B · hit5 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=5 git.response.bytes=370 git.response.cache=HIT git.response.duration_ms=5 git.fetch.filter=tree:0 git.fetch.wants=290ae7a62f76e23cbbd60697570f19b90ddcece6 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=370 git.pkt.payload.max=343 git.sideband.band1.bytes=343 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=343 git.pack.trailer=0795a26d2b25022c69da2ef2e68cfb92a77ef4bbOpen pack map
fetchtree:0200134 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=134 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=7000abd6d60488755d722ac33013da7d82691672 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=134 git.pkt.payload.max=107 git.sideband.band1.bytes=107 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=107 git.pack.trailer=d73c332613bf5e79dd341d7d24aeb952a14e0d50Open pack map
fetch2001.4 KiB383 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=383 git.response.bytes=1405 git.response.cache=MISS git.response.duration_ms=383 git.fetch.wants=490256e21492b23b47fa64e5ce060188587bc5e4 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1405 git.pkt.payload.max=1378 git.sideband.band1.bytes=1378 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2ebc9ab6a4bc2
- Request
- 1753c68f…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format