GitLabgitlab-org
cli
main
1//go:build !integration
3package revoke
5import (
6 "errors"
7 "testing"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
11 "go.uber.org/mock/gomock"
13 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
14 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
16 "gitlab.com/gitlab-org/cli/internal/api"
17 "gitlab.com/gitlab-org/cli/internal/cmdutils"
18 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
19)
21func setupExec(t *testing.T, tc *gitlabtesting.TestClient, opts ...cmdtest.FactoryOption) cmdtest.CmdExecFunc {
22 t.Helper()
24 opts = append(
25 []cmdtest.FactoryOption{
26 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
27 },
28 opts...,
29 )
31 return cmdtest.SetupCmdForTest(t, NewCmd, false, opts...)
32}
34func noMorePages() *gitlab.Response {
35 return &gitlab.Response{NextPage: 0}
36}
38// No list expectation is set: both IDs go straight to the revoke.
39func TestTokenRevoke_ProjectByIDs(t *testing.T) {
40 t.Parallel()
42 tc := gitlabtesting.NewTestClient(t)
43 tc.MockProjects.EXPECT().
44 RevokeProjectServiceAccountPersonalAccessToken("OWNER/REPO", int64(51), int64(7), gomock.Any()).
45 Return(nil, nil)
47 out, err := setupExec(t, tc)("51 7")
48 require.NoError(t, err)
50 assert.Equal(t, "✓ Revoked token 7 of service account 51 in project OWNER/REPO.\n", out.OutBuf.String())
51 assert.Empty(t, out.ErrBuf.String())
52}
54func TestTokenRevoke_Group(t *testing.T) {
55 t.Parallel()
57 tc := gitlabtesting.NewTestClient(t)
58 tc.MockGroups.EXPECT().
59 RevokeServiceAccountPersonalAccessToken("group/sub-group", int64(41), int64(9), gomock.Any()).
60 Return(nil, nil)
62 out, err := setupExec(t, tc)("41 9 --group group/sub-group")
63 require.NoError(t, err)
65 assert.Equal(t, "✓ Revoked token 9 of service account 41 in group group/sub-group.\n", out.OutBuf.String())
66}
68func TestTokenRevoke_ByNames(t *testing.T) {
69 t.Parallel()
71 tc := gitlabtesting.NewTestClient(t)
72 gomock.InOrder(
73 tc.MockProjects.EXPECT().
74 ListProjectServiceAccounts("OWNER/REPO", gomock.Any(), gomock.Any(), gomock.Any()).
75 Return([]*gitlab.ProjectServiceAccount{{ID: 52, Username: "release-bot"}}, noMorePages(), nil),
76 tc.MockProjects.EXPECT().
77 ListProjectServiceAccountPersonalAccessTokens("OWNER/REPO", int64(52), gomock.Cond(func(o *gitlab.ListProjectServiceAccountPersonalAccessTokensOptions) bool {
78 return o.State != nil && *o.State == "active" && o.Search != nil && *o.Search == "ci"
79 }), gomock.Any(), gomock.Any()).
80 Return([]*gitlab.PersonalAccessToken{{ID: 6, Name: "ci-old"}, {ID: 7, Name: "ci"}}, noMorePages(), nil),
81 tc.MockProjects.EXPECT().
82 RevokeProjectServiceAccountPersonalAccessToken("OWNER/REPO", int64(52), int64(7), gomock.Any()).
83 Return(nil, nil),
84 )
86 out, err := setupExec(t, tc)("release-bot ci")
87 require.NoError(t, err)
89 assert.Equal(t, "✓ Revoked token 7 of service account 52 in project OWNER/REPO.\n", out.OutBuf.String())
90}
92func TestTokenRevoke_TokenNameNotFound(t *testing.T) {
93 t.Parallel()
95 tc := gitlabtesting.NewTestClient(t)
96 tc.MockProjects.EXPECT().
97 ListProjectServiceAccountPersonalAccessTokens("OWNER/REPO", int64(51), gomock.Any(), gomock.Any(), gomock.Any()).
98 Return([]*gitlab.PersonalAccessToken{}, noMorePages(), nil)
100 _, err := setupExec(t, tc)("51 ci")
101 require.Error(t, err)
103 var exitErr *cmdutils.ExitError
104 require.ErrorAs(t, err, &exitErr)
105 assert.Equal(t, "failed to revoke service account token", exitErr.Details)
106 assert.Contains(t, err.Error(), `no active token named "ci" for service account 51 in project OWNER/REPO`)
107}
109func TestTokenRevoke_DuplicateTokenName(t *testing.T) {
110 t.Parallel()
112 tc := gitlabtesting.NewTestClient(t)
113 tc.MockProjects.EXPECT().
114 ListProjectServiceAccountPersonalAccessTokens("OWNER/REPO", int64(51), gomock.Any(), gomock.Any(), gomock.Any()).
115 Return([]*gitlab.PersonalAccessToken{{ID: 7, Name: "ci"}, {ID: 8, Name: "ci"}}, noMorePages(), nil)
117 _, err := setupExec(t, tc)("51 ci")
118 require.Error(t, err)
119 assert.Contains(t, err.Error(), `multiple active tokens named "ci" for service account 51; use the token ID instead`)
120}
122func TestTokenRevoke_InvalidTokenID(t *testing.T) {
123 t.Parallel()
125 tc := gitlabtesting.NewTestClient(t)
127 _, err := setupExec(t, tc)("51 0")
128 require.Error(t, err)
129 assert.Contains(t, err.Error(), `invalid token ID "0"`)
130}
132func TestTokenRevoke_InvalidAccountID(t *testing.T) {
133 t.Parallel()
135 tc := gitlabtesting.NewTestClient(t)
137 _, err := setupExec(t, tc)("0 7")
138 require.Error(t, err)
139 assert.Contains(t, err.Error(), `invalid service account ID "0"`)
140}
142func TestTokenRevoke_APIError(t *testing.T) {
143 t.Parallel()
145 tc := gitlabtesting.NewTestClient(t)
146 tc.MockProjects.EXPECT().
147 RevokeProjectServiceAccountPersonalAccessToken("OWNER/REPO", int64(51), int64(7), gomock.Any()).
148 Return(nil, errors.New("404 Not Found"))
150 _, err := setupExec(t, tc)("51 7")
151 require.Error(t, err)
153 var exitErr *cmdutils.ExitError
154 require.ErrorAs(t, err, &exitErr)
155 assert.Equal(t, "failed to revoke service account token", exitErr.Details)
156 assert.Contains(t, err.Error(), "404 Not Found")
157}
159func TestTokenRevoke_RequiresArguments(t *testing.T) {
160 t.Parallel()
162 tc := gitlabtesting.NewTestClient(t)
164 _, err := setupExec(t, tc)("51")
165 require.Error(t, err)
166 assert.Contains(t, err.Error(), "accepts 2 arg(s), received 1")
167}
169func TestTokenRevoke_RepoAndGroupAreMutuallyExclusive(t *testing.T) {
170 t.Parallel()
172 tc := gitlabtesting.NewTestClient(t)
174 _, err := setupExec(t, tc)("51 7 --repo OWNER/REPO --group my-group")
175 require.Error(t, err)
176 assert.Contains(t, err.Error(), "none of the others can be")
177}
179func TestTokenRevoke_OutsideRepositoryWithoutGroup(t *testing.T) {
180 t.Parallel()
182 tc := gitlabtesting.NewTestClient(t)
184 _, err := setupExec(t, tc, cmdtest.WithBaseRepoError(errors.New("not a git repository")))("51 7")
185 require.Error(t, err)
186 assert.Contains(t, err.Error(), "not a git repository")
187}
189func TestTokenRevoke_OutsideRepositoryWithGroup(t *testing.T) {
190 t.Parallel()
192 tc := gitlabtesting.NewTestClient(t)
193 tc.MockGroups.EXPECT().
194 RevokeServiceAccountPersonalAccessToken("my-group", int64(41), int64(9), gomock.Any()).
195 Return(nil, nil)
197 out, err := setupExec(t, tc, cmdtest.WithBaseRepoError(errors.New("not a git repository")))("41 9 --group my-group")
198 require.NoError(t, err)
200 assert.Contains(t, out.OutBuf.String(), "Revoked token 9 of service account 41 in group my-group.")
201}
203// GITLAB_GROUP redirects the command with no flag passed. t.Setenv rules out
204// t.Parallel.
205func TestTokenRevoke_GroupFromEnvironment(t *testing.T) {
206 t.Setenv("GITLAB_GROUP", "env-group")
208 tc := gitlabtesting.NewTestClient(t)
209 tc.MockGroups.EXPECT().
210 RevokeServiceAccountPersonalAccessToken("env-group", int64(41), int64(9), gomock.Any()).
211 Return(nil, nil)
213 out, err := setupExec(t, tc)("41 9")
214 require.NoError(t, err)
216 assert.Equal(t, "✓ Revoked token 9 of service account 41 in group env-group.\n", out.OutBuf.String())
217}
Diagnostics9 git calls · 306 ms
CallStatusSizeTime0306 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200322 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=322 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=ba2caccf6c55211c6b29b98f40c2358479d91b1f git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=322 git.pkt.payload.max=295 git.sideband.band1.bytes=295 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=295 git.pack.trailer=3488e558d4708096e879feba968e084c249dbe22Open pack map
fetchtree:0200223 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=223 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=41d72d07155f99e3acc572f8fe5ad26c802e4ddc git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=223 git.pkt.payload.max=196 git.sideband.band1.bytes=196 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=196 git.pack.trailer=d9c58aac50f427eb21501a81fe28c81c7c49ae44Open pack map
fetchtree:0200138 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=138 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=bc7a44691d1232fb2b11b17fa552e72df113fc88 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=138 git.pkt.payload.max=111 git.sideband.band1.bytes=111 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=111 git.pack.trailer=47b97954622eae14af0f4bcdd0f169b854b41addOpen pack map
fetch2001.6 KiB287 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=287 git.response.bytes=1620 git.response.cache=MISS git.response.duration_ms=287 git.fetch.wants=3e6f7271da650996c74c333dcb2bd8b2e9a34a33 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1620 git.pkt.payload.max=1593 git.sideband.band1.bytes=1593 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e3515f5e6a224d
- Request
- f32711c3…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format