GitLabgitlab-org
cli
main
1//go:build !integration
3package remove
5import (
6 "fmt"
7 "testing"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
12 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
13 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
15 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
16)
18const repoName = "OWNER/REPO"
20func Test_SecurefileRemove(t *testing.T) {
21 type testCase struct {
22 name string
23 cli string
24 expectedMsg []string
25 wantErr bool
26 wantStderr string
27 setupMock func(tc *gitlabtesting.TestClient)
28 }
30 testCases := []testCase{
31 {
32 name: "Conflicting id argument and --id flag is rejected",
33 cli: "1 --id 2 -y",
34 wantErr: true,
35 wantStderr: `the secure file ID argument "1" cannot be combined with --id or --name`,
36 // No API call: the request used to go out for --id (2), silently
37 // ignoring the positional argument (1).
38 setupMock: func(tc *gitlabtesting.TestClient) {},
39 },
40 {
41 name: "Conflicting id argument and --name flag is rejected",
42 cli: "1 --name file.txt -y",
43 wantErr: true,
44 wantStderr: `the secure file ID argument "1" cannot be combined with --id or --name`,
45 setupMock: func(tc *gitlabtesting.TestClient) {},
46 },
47 {
48 name: "Remove a secure file via id arg",
49 cli: "1 -y",
50 expectedMsg: []string{"• Deleting secure file repo=OWNER/REPO fileID=1", "✓ Secure file 1 deleted."},
51 setupMock: func(tc *gitlabtesting.TestClient) {
52 tc.MockSecureFiles.EXPECT().
53 RemoveSecureFile(repoName, int64(1)).
54 Return(nil, nil)
55 },
56 },
57 {
58 name: "Remove a secure file via id flag",
59 cli: "--id 1 -y",
60 expectedMsg: []string{"• Deleting secure file repo=OWNER/REPO fileID=1", "✓ Secure file 1 deleted."},
61 setupMock: func(tc *gitlabtesting.TestClient) {
62 tc.MockSecureFiles.EXPECT().
63 RemoveSecureFile(repoName, int64(1)).
64 Return(nil, nil)
65 },
66 },
67 {
68 name: "Remove a secure file via name flag",
69 cli: "--name file2.txt -y",
70 expectedMsg: []string{"• Deleting secure file repo=OWNER/REPO fileID=2", "✓ Secure file 2 deleted."},
71 setupMock: func(tc *gitlabtesting.TestClient) {
72 tc.MockSecureFiles.EXPECT().
73 ListProjectSecureFiles(repoName, &gitlab.ListProjectSecureFilesOptions{
74 ListOptions: gitlab.ListOptions{Page: 1, PerPage: 100},
75 }, nil).
76 Return([]*gitlab.SecureFile{
77 {ID: 1, Name: "file1.txt"},
78 {ID: 2, Name: "file2.txt"},
79 }, &gitlab.Response{}, nil)
80 tc.MockSecureFiles.EXPECT().
81 RemoveSecureFile(repoName, int64(2)).
82 Return(nil, nil)
83 },
84 },
85 {
86 name: "Remove a secure file but API errors via id arg",
87 cli: "1 -y",
88 setupMock: func(tc *gitlabtesting.TestClient) {
89 tc.MockSecureFiles.EXPECT().
90 RemoveSecureFile("OWNER/REPO", int64(1)).
91 Return(nil, fmt.Errorf("DELETE https://gitlab.com/api/v4/projects/OWNER%%2FREPO/secure_files/1: 400"))
92 },
93 wantErr: true,
94 wantStderr: "error removing secure file: DELETE https://gitlab.com/api/v4/projects/OWNER%2FREPO/secure_files/1: 400",
95 },
96 {
97 name: "Remove a secure file with invalid file ID via id arg",
98 cli: "abc -y",
99 setupMock: func(tc *gitlabtesting.TestClient) {},
100 wantErr: true,
101 wantStderr: "secure file ID must be an integer: abc",
102 },
103 {
104 name: "Remove a secure file without force delete when not running interactively",
105 cli: "1",
106 setupMock: func(tc *gitlabtesting.TestClient) {},
107 wantErr: true,
108 wantStderr: "--yes or -y flag is required when not running interactively",
109 },
110 }
112 for _, tc := range testCases {
113 t.Run(tc.name, func(t *testing.T) {
114 // GIVEN
115 testClient := gitlabtesting.NewTestClient(t)
116 tc.setupMock(testClient)
117 exec := cmdtest.SetupCmdForTest(
118 t,
119 NewCmdRemove,
120 false,
121 cmdtest.WithGitLabClient(testClient.Client),
122 )
124 // WHEN
125 out, err := exec(tc.cli)
127 // THEN
128 if tc.wantErr {
129 require.Error(t, err)
130 assert.Equal(t, tc.wantStderr, err.Error())
131 return
132 }
133 require.NoError(t, err)
134 for _, msg := range tc.expectedMsg {
135 assert.Contains(t, out.String(), msg)
136 }
137 })
138 }
139}
Diagnostics8 git calls · 299 ms
CallStatusSizeTime0299 ms
discover200185 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200353 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=353 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=d9f8b91b7f75f6920fea2e149ed3fba5f61766da git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=353 git.pkt.payload.max=326 git.sideband.band1.bytes=326 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=326 git.pack.trailer=353875a8d3dc1310585685b9eadd95754bcf8d98Open pack map
fetchtree:0200138 B · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=138 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=366709900042748db0b3ac901bbd33b51bebb15e git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=138 git.pkt.payload.max=111 git.sideband.band1.bytes=111 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=111 git.pack.trailer=5121df88ae8e725ec19cea2fd292aa5a6f251113Open pack map
fetch2001.3 KiB281 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=281 git.response.bytes=1309 git.response.cache=MISS git.response.duration_ms=281 git.fetch.wants=4b1267c70ce2dff264c9852ba9329ec85444af64 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1309 git.pkt.payload.max=1282 git.sideband.band1.bytes=1282 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e274260ee6d806
- Request
- c267ebdb…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format