GitLabgitlab-org
cli
main
1//go:build !integration
3package update
5import (
6 "testing"
8 "github.com/stretchr/testify/assert"
9 "github.com/stretchr/testify/require"
10 "go.uber.org/mock/gomock"
12 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
13 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
15 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
16)
18func Test_ScheduleEdit(t *testing.T) {
19 type testCase struct {
20 name string
21 cli string
22 expectedMsg []string
23 wantErr bool
24 wantStderr string
25 setupMock func(tc *gitlabtesting.TestClient)
26 }
28 testCases := []testCase{
29 {
30 name: "Schedule updated",
31 cli: "1 --cron '*0 * * * *' --description 'example pipeline' --ref 'main'",
32 expectedMsg: []string{"Updated schedule with ID 1"},
33 setupMock: func(tc *gitlabtesting.TestClient) {
34 tc.MockPipelineSchedules.EXPECT().
35 EditPipelineSchedule("OWNER/REPO", int64(1), gomock.Any()).
36 Return(&gitlab.PipelineSchedule{ID: 1}, nil, nil)
37 },
38 },
39 {
40 name: "Schedule updated with new variable",
41 cli: "1 --description 'example pipeline' --create-variable 'foo:bar'",
42 expectedMsg: []string{"Updated schedule with ID 1"},
43 setupMock: func(tc *gitlabtesting.TestClient) {
44 tc.MockPipelineSchedules.EXPECT().
45 EditPipelineSchedule("OWNER/REPO", int64(1), gomock.Any()).
46 Return(&gitlab.PipelineSchedule{ID: 1}, nil, nil)
47 tc.MockPipelineSchedules.EXPECT().
48 CreatePipelineScheduleVariable("OWNER/REPO", int64(1), gomock.Any()).
49 Return(&gitlab.PipelineVariable{}, nil, nil)
50 },
51 },
52 {
53 name: "Schedule updated with updated variable",
54 cli: "1 --description 'example pipeline' --update-variable 'foo:bar'",
55 expectedMsg: []string{"Updated schedule with ID 1"},
56 setupMock: func(tc *gitlabtesting.TestClient) {
57 tc.MockPipelineSchedules.EXPECT().
58 EditPipelineSchedule("OWNER/REPO", int64(1), gomock.Any()).
59 Return(&gitlab.PipelineSchedule{ID: 1}, nil, nil)
60 tc.MockPipelineSchedules.EXPECT().
61 EditPipelineScheduleVariable("OWNER/REPO", int64(1), "foo", gomock.Any()).
62 Return(&gitlab.PipelineVariable{}, nil, nil)
63 },
64 },
65 {
66 name: "Schedule updated with deleted variable",
67 cli: "1 --description 'example pipeline' --delete-variable 'foo'",
68 expectedMsg: []string{"Updated schedule with ID 1"},
69 setupMock: func(tc *gitlabtesting.TestClient) {
70 tc.MockPipelineSchedules.EXPECT().
71 EditPipelineSchedule("OWNER/REPO", int64(1), gomock.Any()).
72 Return(&gitlab.PipelineSchedule{ID: 1}, nil, nil)
73 tc.MockPipelineSchedules.EXPECT().
74 DeletePipelineScheduleVariable("OWNER/REPO", int64(1), "foo").
75 Return(nil, nil, nil)
76 },
77 },
78 {
79 name: "Schedule updated with invalid variable format - create",
80 cli: "1 --create-variable 'foo:bar' --create-variable 'foo'",
81 wantErr: true,
82 wantStderr: "invalid format for --create-variable: foo",
83 setupMock: func(tc *gitlabtesting.TestClient) {},
84 },
85 {
86 name: "Schedule updated with invalid variable format - update",
87 cli: "1 --update-variable 'foo:bar' --update-variable 'foo'",
88 wantErr: true,
89 wantStderr: "invalid format for --update-variable: foo",
90 setupMock: func(tc *gitlabtesting.TestClient) {},
91 },
92 {
93 name: "Schedule not changed if no flags are set",
94 cli: "1",
95 expectedMsg: []string{"Updated schedule with ID 1"},
96 setupMock: func(tc *gitlabtesting.TestClient) {},
97 },
98 }
100 for _, tc := range testCases {
101 t.Run(tc.name, func(t *testing.T) {
102 // GIVEN
103 testClient := gitlabtesting.NewTestClient(t)
104 tc.setupMock(testClient)
105 exec := cmdtest.SetupCmdForTest(
106 t,
107 NewCmdUpdate,
108 false,
109 cmdtest.WithGitLabClient(testClient.Client),
110 )
112 // WHEN
113 out, err := exec(tc.cli)
115 // THEN
116 if tc.wantErr {
117 require.Error(t, err)
118 assert.Equal(t, tc.wantStderr, err.Error())
119 return
120 }
121 require.NoError(t, err)
122 for _, msg := range tc.expectedMsg {
123 assert.Contains(t, out.OutBuf.String(), msg)
124 }
125 })
126 }
127}
Diagnostics8 git calls · 218 ms
CallStatusSizeTime0218 ms
discover200185 B4 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200258 B · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=258 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=2c270ec0aade647327d1eadbbb162f93f066af69 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=258 git.pkt.payload.max=231 git.sideband.band1.bytes=231 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=231 git.pack.trailer=09803190b531b8c270ef4ea7e6be0d538e0ee9f5Open pack map
fetchtree:0200139 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=202 git.response.bytes=139 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=2932c519a9d3eddc8f82959dd30999d0ff05bca2 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=139 git.pkt.payload.max=112 git.sideband.band1.bytes=112 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=112 git.pack.trailer=cb684225f2eab5a5bab6fb3ced0b6cb98396ac75Open pack map
fetch2001.0 KiB202 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1036 git.response.cache=MISS git.response.duration_ms=202 git.fetch.wants=ff8ce5080550a7ffe1c0448abfe2e5c5820fd2a9 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1036 git.pkt.payload.max=1009 git.sideband.band1.bytes=1009 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e23e1b0da54bc2
- Request
- b920016c…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format