GitLabgitlab-org
cli
main
1//go:build !integration
3package delete
5import (
6 "errors"
7 "testing"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
11 "go.uber.org/mock/gomock"
13 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
15 "gitlab.com/gitlab-org/cli/internal/api"
16 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
17)
19func TestDeleteInstanceScope(t *testing.T) {
20 t.Parallel()
22 tc := gitlabtesting.NewTestClient(t)
24 exec := cmdtest.SetupCmdForTest(
25 t,
26 NewCmd,
27 false,
28 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
29 )
31 tc.MockRunnerControllerScopes.EXPECT().
32 RemoveRunnerControllerInstanceScope(int64(42), gomock.Any()).
33 Return(nil, nil)
35 out, err := exec("42 --instance --force")
36 require.NoError(t, err)
37 assert.Equal(t, "Removed instance-level scope from runner controller 42\n", out.OutBuf.String())
38}
40func TestDeleteInstanceScopeError(t *testing.T) {
41 t.Parallel()
43 tc := gitlabtesting.NewTestClient(t)
45 exec := cmdtest.SetupCmdForTest(
46 t,
47 NewCmd,
48 false,
49 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
50 )
52 tc.MockRunnerControllerScopes.EXPECT().
53 RemoveRunnerControllerInstanceScope(int64(42), gomock.Any()).
54 Return(nil, errors.New("API error"))
56 _, err := exec("42 --instance --force")
57 require.Error(t, err)
58 assert.Contains(t, err.Error(), "API error")
59}
61func TestDeleteRunnerScope(t *testing.T) {
62 t.Parallel()
64 tc := gitlabtesting.NewTestClient(t)
66 exec := cmdtest.SetupCmdForTest(
67 t,
68 NewCmd,
69 false,
70 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
71 )
73 tc.MockRunnerControllerScopes.EXPECT().
74 RemoveRunnerControllerRunnerScope(int64(42), int64(5), gomock.Any()).
75 Return(nil, nil)
77 out, err := exec("42 --runner 5 --force")
78 require.NoError(t, err)
79 assert.Equal(t, "Removed runner-level scope for runner 5 from runner controller 42\n", out.OutBuf.String())
80}
82func TestDeleteMultipleRunnerScopes(t *testing.T) {
83 t.Parallel()
85 tc := gitlabtesting.NewTestClient(t)
87 exec := cmdtest.SetupCmdForTest(
88 t,
89 NewCmd,
90 false,
91 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
92 )
94 gomock.InOrder(
95 tc.MockRunnerControllerScopes.EXPECT().
96 RemoveRunnerControllerRunnerScope(int64(42), int64(5), gomock.Any()).
97 Return(nil, nil),
98 tc.MockRunnerControllerScopes.EXPECT().
99 RemoveRunnerControllerRunnerScope(int64(42), int64(10), gomock.Any()).
100 Return(nil, nil),
101 )
103 out, err := exec("42 --runner 5 --runner 10 --force")
104 require.NoError(t, err)
105 assert.Equal(t, "Removed runner-level scope for runner 5 from runner controller 42\nRemoved runner-level scope for runner 10 from runner controller 42\n", out.OutBuf.String())
106}
108func TestDeleteMultipleRunnerScopesCommaSeparated(t *testing.T) {
109 t.Parallel()
111 tc := gitlabtesting.NewTestClient(t)
113 exec := cmdtest.SetupCmdForTest(
114 t,
115 NewCmd,
116 false,
117 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
118 )
120 gomock.InOrder(
121 tc.MockRunnerControllerScopes.EXPECT().
122 RemoveRunnerControllerRunnerScope(int64(42), int64(5), gomock.Any()).
123 Return(nil, nil),
124 tc.MockRunnerControllerScopes.EXPECT().
125 RemoveRunnerControllerRunnerScope(int64(42), int64(10), gomock.Any()).
126 Return(nil, nil),
127 )
129 out, err := exec("42 --runner 5,10 --force")
130 require.NoError(t, err)
131 assert.Equal(t, "Removed runner-level scope for runner 5 from runner controller 42\nRemoved runner-level scope for runner 10 from runner controller 42\n", out.OutBuf.String())
132}
134func TestDeleteMultipleRunnerScopesPartialError(t *testing.T) {
135 t.Parallel()
137 tc := gitlabtesting.NewTestClient(t)
139 exec := cmdtest.SetupCmdForTest(
140 t,
141 NewCmd,
142 false,
143 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
144 )
146 gomock.InOrder(
147 tc.MockRunnerControllerScopes.EXPECT().
148 RemoveRunnerControllerRunnerScope(int64(42), int64(5), gomock.Any()).
149 Return(nil, nil),
150 tc.MockRunnerControllerScopes.EXPECT().
151 RemoveRunnerControllerRunnerScope(int64(42), int64(10), gomock.Any()).
152 Return(nil, errors.New("API error")),
153 )
155 _, err := exec("42 --runner 5,10 --force")
156 require.Error(t, err)
157 assert.Contains(t, err.Error(), "API error")
158}
160func TestDeleteRunnerScopeError(t *testing.T) {
161 t.Parallel()
163 tc := gitlabtesting.NewTestClient(t)
165 exec := cmdtest.SetupCmdForTest(
166 t,
167 NewCmd,
168 false,
169 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
170 )
172 tc.MockRunnerControllerScopes.EXPECT().
173 RemoveRunnerControllerRunnerScope(int64(42), int64(5), gomock.Any()).
174 Return(nil, errors.New("API error"))
176 _, err := exec("42 --runner 5 --force")
177 require.Error(t, err)
178 assert.Contains(t, err.Error(), "API error")
179}
181func TestDeleteRequiresScopeType(t *testing.T) {
182 t.Parallel()
184 tc := gitlabtesting.NewTestClient(t)
186 exec := cmdtest.SetupCmdForTest(
187 t,
188 NewCmd,
189 false,
190 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
191 )
193 _, err := exec("42 --force")
194 require.Error(t, err)
195 assert.Contains(t, err.Error(), "at least one of the flags in the group [instance runner] is required")
196}
198func TestDeleteMutuallyExclusive(t *testing.T) {
199 t.Parallel()
201 tc := gitlabtesting.NewTestClient(t)
203 exec := cmdtest.SetupCmdForTest(
204 t,
205 NewCmd,
206 false,
207 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
208 )
210 _, err := exec("42 --instance --runner 5 --force")
211 require.Error(t, err)
212 assert.Contains(t, err.Error(), "if any flags in the group [instance runner] are set none of the others can be")
213}
215func TestDeleteRequiresForceNonInteractive(t *testing.T) {
216 t.Parallel()
218 tc := gitlabtesting.NewTestClient(t)
220 exec := cmdtest.SetupCmdForTest(
221 t,
222 NewCmd,
223 false,
224 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
225 )
227 _, err := exec("42 --instance")
228 require.Error(t, err)
229 assert.Contains(t, err.Error(), "--force required")
230}
232func TestDeleteRunnerScopeRequiresForceNonInteractive(t *testing.T) {
233 t.Parallel()
235 tc := gitlabtesting.NewTestClient(t)
237 exec := cmdtest.SetupCmdForTest(
238 t,
239 NewCmd,
240 false,
241 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
242 )
244 _, err := exec("42 --runner 5")
245 require.Error(t, err)
246 assert.Contains(t, err.Error(), "--force required")
247}
249func TestDeleteInvalidID(t *testing.T) {
250 t.Parallel()
252 tc := gitlabtesting.NewTestClient(t)
254 exec := cmdtest.SetupCmdForTest(
255 t,
256 NewCmd,
257 false,
258 cmdtest.WithApiClient(cmdtest.NewTestApiClient(t, nil, "", "", api.WithGitLabClient(tc.Client))),
259 )
261 _, err := exec("invalid --instance --force")
262 require.Error(t, err)
263 assert.Contains(t, err.Error(), `invalid runner controller ID: "invalid"`)
264}
Diagnostics9 git calls · 269 ms
CallStatusSizeTime0269 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200323 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=323 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=8185a1b139a07a59fba10180a7318233adb22fc3 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=323 git.pkt.payload.max=296 git.sideband.band1.bytes=296 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=296 git.pack.trailer=ac106711ec2e15414437a5964de4b85c86703290Open pack map
fetchtree:0200196 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=196 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=2457618d95f2bcb98ae5f01c872bb42789a59b56 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=196 git.pkt.payload.max=169 git.sideband.band1.bytes=169 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=169 git.pack.trailer=02c3a461145a7ea4fb72afbfd8909e6ed3eedc5aOpen pack map
fetchtree:0200138 B · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=138 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=d0364dda4a4029e1452610cf9430977bfa67ac26 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=138 git.pkt.payload.max=111 git.sideband.band1.bytes=111 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=111 git.pack.trailer=b923cb56c89a2b5ff082f6143c46f5e5370e6777Open pack map
fetch200931 B251 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=251 git.response.bytes=931 git.response.cache=MISS git.response.duration_ms=251 git.fetch.wants=44e0890edfa8d3bcf0f62b4de87f449c5fd5e653 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=931 git.pkt.payload.max=904 git.sideband.band1.bytes=904 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e22c3f8ba22a83
- Request
- b4a7b766…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format