GitLabgitlab-org
cli
main
1//go:build !integration
3package create
5import (
6 "net/http"
7 "testing"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
11 "go.uber.org/mock/gomock"
13 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
14 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
16 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
17)
19func TestReleaseCreate_SemverError(t *testing.T) {
20 t.Parallel()
21 for _, existing := range []bool{false, true} {
22 operation := "create"
23 if existing {
24 operation = "update"
25 }
26 for _, tt := range []struct {
27 name string
28 status int
29 message string
30 hint bool
31 }{
32 {name: "catalog version rejected", status: http.StatusUnprocessableEntity, message: "Semver must follow semantic version", hint: true},
33 {name: "catalog version rejected with mixed case", status: http.StatusUnprocessableEntity, message: "SemVer must follow semantic version", hint: true},
34 {name: "catalog version rejected with lower case", status: http.StatusUnprocessableEntity, message: "semver must follow semantic version", hint: true},
35 {name: "other validation rejected", status: http.StatusUnprocessableEntity, message: "Name is too long"},
36 {name: "server failed", status: http.StatusInternalServerError, message: "Semver must follow semantic version"},
37 } {
38 t.Run(operation+"/"+tt.name, func(t *testing.T) {
39 t.Parallel()
40 tc := gitlabtesting.NewTestClient(t)
41 apiErr := &gitlab.ErrorResponse{StatusCode: tt.status, Message: tt.message}
42 tc.MockTags.EXPECT().GetTag("OWNER/REPO", "1.04", gomock.Any()).Return(&gitlab.Tag{Name: "1.04"}, nil, nil)
43 if existing {
44 tc.MockReleases.EXPECT().GetRelease("OWNER/REPO", "1.04", gomock.Any()).Return(&gitlab.Release{TagName: "1.04"}, &gitlab.Response{Response: &http.Response{StatusCode: http.StatusOK}}, nil)
45 tc.MockReleases.EXPECT().UpdateRelease("OWNER/REPO", "1.04", gomock.Any()).Return(nil, nil, apiErr)
46 } else {
47 tc.MockReleases.EXPECT().GetRelease("OWNER/REPO", "1.04", gomock.Any()).Return(nil, &gitlab.Response{Response: &http.Response{StatusCode: http.StatusNotFound}}, gitlab.ErrNotFound)
48 tc.MockReleases.EXPECT().CreateRelease("OWNER/REPO", gomock.Any()).Return(nil, nil, apiErr)
49 }
50 exec := cmdtest.SetupCmdForTest(t, NewCmdCreate, false, cmdtest.WithGitLabClient(tc.Client))
52 _, err := exec("1.04 --notes release")
54 require.Error(t, err)
55 require.ErrorIs(t, err, apiErr)
56 assert.Contains(t, err.Error(), tt.message)
57 if tt.hint {
58 assert.Contains(t, err.Error(), "MAJOR.MINOR.PATCH")
59 assert.Contains(t, err.Error(), "Only a lowercase v prefix is allowed")
60 assert.Contains(t, err.Error(), "https://docs.gitlab.com/ci/components/#semantic-versioning")
61 } else {
62 assert.NotContains(t, err.Error(), "semantic-versioning")
63 }
64 })
65 }
66 }
67}
Diagnostics8 git calls · 219 ms
CallStatusSizeTime0219 ms
discover200185 B5 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200350 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=350 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=b2a837e646ba305993f35203fafafb109e57a7ca git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=350 git.pkt.payload.max=323 git.sideband.band1.bytes=323 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=323 git.pack.trailer=1232131042f2ba4c9c4dbd99382667a1f0849e15Open pack map
fetchtree:0200245 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=202 git.response.bytes=245 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=cb03b730c0d38e0c25330b8c3edfd648a7c3425b git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=245 git.pkt.payload.max=218 git.sideband.band1.bytes=218 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=218 git.pack.trailer=abcaa1e604d6142de985dae4beacc05f23f3a7b7Open pack map
fetch2001.0 KiB202 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1028 git.response.cache=MISS git.response.duration_ms=202 git.fetch.wants=8639a00b33e7c2f48868b7b3f0822b7825010b8e git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1028 git.pkt.payload.max=1001 git.sideband.band1.bytes=1001 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2aff04890e6b0
- Request
- 17a35062…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format