GitLabgitlab-org

cli

main
ply9 git calls217 ms99 KiB7 cachedprotocol v2
135 lines4.4 KiBRaw
1//go:build !integration
3package add
5import (
6 "testing"
8 "github.com/stretchr/testify/assert"
9 "github.com/stretchr/testify/require"
11 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
12 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
14 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
17func TestMembersAdd(t *testing.T) {
18 t.Parallel()
20 tests := []struct {
21 name string
22 cli string
23 setupMocks func(tc *gitlabtesting.TestClient)
24 expectedOutput string
25 expectedError string
26 }{
27 {
28 name: "add member by username with default role",
29 cli: "--username=john.doe",
30 setupMocks: func(tc *gitlabtesting.TestClient) {
31 tc.MockUsers.EXPECT().
32 ListUsers(&gitlab.ListUsersOptions{Username: new("john.doe")}).
33 Return([]*gitlab.User{{ID: 101, Username: "john.doe"}}, nil, nil)
34 tc.MockProjectMembers.EXPECT().
35 AddProjectMember("OWNER/REPO", &gitlab.AddProjectMemberOptions{
36 UserID: new(101),
37 AccessLevel: new(gitlab.DeveloperPermissions),
38 }).
39 Return(&gitlab.ProjectMember{ID: 101, Username: "john.doe", AccessLevel: gitlab.DeveloperPermissions}, nil, nil)
40 },
41 expectedOutput: "✓ Successfully added john.doe as developer to OWNER/REPO\n",
42 },
43 {
44 name: "add member by username with maintainer role",
45 cli: "--username=jane.smith --role=maintainer",
46 setupMocks: func(tc *gitlabtesting.TestClient) {
47 tc.MockUsers.EXPECT().
48 ListUsers(&gitlab.ListUsersOptions{Username: new("jane.smith")}).
49 Return([]*gitlab.User{{ID: 102, Username: "jane.smith"}}, nil, nil)
50 tc.MockProjectMembers.EXPECT().
51 AddProjectMember("OWNER/REPO", &gitlab.AddProjectMemberOptions{
52 UserID: new(102),
53 AccessLevel: new(gitlab.MaintainerPermissions),
54 }).
55 Return(&gitlab.ProjectMember{ID: 102, Username: "jane.smith", AccessLevel: gitlab.MaintainerPermissions}, nil, nil)
56 },
57 expectedOutput: "✓ Successfully added jane.smith as maintainer to OWNER/REPO\n",
58 },
59 {
60 name: "add member by user ID",
61 cli: "--user-id=123 --role=reporter",
62 setupMocks: func(tc *gitlabtesting.TestClient) {
63 tc.MockProjectMembers.EXPECT().
64 AddProjectMember("OWNER/REPO", &gitlab.AddProjectMemberOptions{
65 UserID: new(123),
66 AccessLevel: new(gitlab.ReporterPermissions),
67 }).
68 Return(&gitlab.ProjectMember{ID: 123, Username: "testuser", AccessLevel: gitlab.ReporterPermissions}, nil, nil)
69 },
70 expectedOutput: "✓ Successfully added testuser as reporter to OWNER/REPO\n",
71 },
72 {
73 name: "error when no username or user-id provided",
74 cli: "",
75 setupMocks: func(tc *gitlabtesting.TestClient) {},
76 expectedError: "either username or user-id must be specified",
77 },
78 {
79 name: "error when both username and user-id provided",
80 cli: "--username=john.doe --user-id=123",
81 setupMocks: func(tc *gitlabtesting.TestClient) {},
82 expectedError: "were all set",
83 },
84 {
85 name: "error when both role and role-id provided",
86 cli: "--username=john.doe --role=developer --role-id=101",
87 setupMocks: func(tc *gitlabtesting.TestClient) {},
88 expectedError: "were all set",
89 },
90 {
91 name: "error with invalid role",
92 cli: "--username=john.doe --role=invalid",
93 setupMocks: func(tc *gitlabtesting.TestClient) {},
94 expectedError: "invalid role: invalid. Valid roles are: guest, reporter, developer, maintainer, owner",
95 },
96 {
97 name: "error when user not found",
98 cli: "--username=nonexistent",
99 setupMocks: func(tc *gitlabtesting.TestClient) {
100 tc.MockUsers.EXPECT().
101 ListUsers(&gitlab.ListUsersOptions{Username: new("nonexistent")}).
102 Return([]*gitlab.User{}, nil, nil)
103 },
104 expectedError: "user nonexistent not found",
105 },
106 }
108 for _, tc := range tests {
109 t.Run(tc.name, func(t *testing.T) {
110 t.Parallel()
111 testClient := gitlabtesting.NewTestClient(t)
112 if tc.setupMocks != nil {
113 tc.setupMocks(testClient)
114 }
116 exec := cmdtest.SetupCmdForTest(
117 t,
118 NewCmd,
119 false,
120 cmdtest.WithBaseRepo("OWNER", "REPO", ""),
121 cmdtest.WithGitLabClient(testClient.Client),
122 )
124 out, err := exec(tc.cli)
126 if tc.expectedError != "" {
127 require.Error(t, err)
128 assert.Contains(t, err.Error(), tc.expectedError)
129 } else if assert.NoErrorf(t, err, "error running command `members add %s`: %v", tc.cli, err) {
130 assert.Equal(t, tc.expectedOutput, out.OutBuf.String())
131 assert.Empty(t, out.Stderr())
132 }
133 })
134 }
Diagnostics9 git calls · 217 ms
CallStatusSizeTime0217 ms
discover200185 B2 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=HIT
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit5 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=5
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=5
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200614 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=614
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=3a89d0cfc8e81880c982180388e42e561a0b7eee
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=614
git.pkt.payload.max=587
git.sideband.band1.bytes=587
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=587
git.pack.trailer=eb8250f8e8340ff2fafc22c5aba90db34fd906a9
Open pack map
fetchtree:0200198 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=198
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=ae4de5db0d32551153085c68d34eb0d395b7df5a
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=198
git.pkt.payload.max=171
git.sideband.band1.bytes=171
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=171
git.pack.trailer=b44c92e9fa6892fac61a2b92ee59f8711c1238cf
Open pack map
fetchtree:0200135 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=135
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=b798cf6d8a774b5f08277273be20975daff0dc4e
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=135
git.pkt.payload.max=108
git.sideband.band1.bytes=108
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=108
git.pack.trailer=5279d342a77d2176a49e3300458c8c67ca7fec29
Open pack map
fetch2001.2 KiB202 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=202
git.response.bytes=1274
git.response.cache=MISS
git.response.duration_ms=202
git.fetch.wants=9c4a0582ff8465cecd553ba725bf3b020f56322b
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1274
git.pkt.payload.max=1247
git.sideband.band1.bytes=1247
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5ea623ddc2decd4
Request
6fbbd3e9…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format