GitLabgitlab-org
cli
main
1//go:build !integration
3package upload
5import (
6 "fmt"
7 "testing"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
11 "go.uber.org/mock/gomock"
13 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
14 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
16 "gitlab.com/gitlab-org/cli/internal/glinstance"
17 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
18)
20func Test_PackagesUpload(t *testing.T) {
21 t.Parallel()
23 testCases := []struct {
24 name string
25 cli string
26 expectedMsg []string
27 wantErr bool
28 wantErrMsg string
29 errContains string
30 setupMock func(tc *gitlabtesting.TestClient)
31 }{
32 {
33 name: "Upload package file",
34 cli: "testdata/localfile.txt --name my-package --version 1.0.0",
35 expectedMsg: []string{
36 "Uploading package file repo=OWNER/REPO package=my-package version=1.0.0 file=localfile.txt",
37 "Package file localfile.txt uploaded.",
38 "url https://gitlab.com/api/v4/projects/OWNER%2FREPO/packages/generic/my-package/1.0.0/localfile.txt",
39 "sha256 abc123",
40 },
41 setupMock: func(tc *gitlabtesting.TestClient) {
42 tc.MockGenericPackages.EXPECT().
43 PublishPackageFile("OWNER/REPO", "my-package", "1.0.0", "localfile.txt", gomock.Any(), gomock.Any(), gomock.Any()).
44 Return(&gitlab.GenericPackagesFile{ID: 1, FileName: "localfile.txt", FileSHA256: "abc123"}, nil, nil)
45 tc.MockGenericPackages.EXPECT().
46 FormatPackageURL("OWNER/REPO", "my-package", "1.0.0", "localfile.txt").
47 Return("projects/OWNER%2FREPO/packages/generic/my-package/1.0.0/localfile.txt", nil)
48 },
49 },
50 {
51 name: "Upload package file with custom filename",
52 cli: "testdata/localfile.txt --name my-package --version 1.0.0 --filename renamed.txt",
53 expectedMsg: []string{
54 "Package file renamed.txt uploaded.",
55 "url https://gitlab.com/api/v4/projects/OWNER%2FREPO/packages/generic/my-package/1.0.0/renamed.txt",
56 "sha256 abc123",
57 },
58 setupMock: func(tc *gitlabtesting.TestClient) {
59 tc.MockGenericPackages.EXPECT().
60 PublishPackageFile("OWNER/REPO", "my-package", "1.0.0", "renamed.txt", gomock.Any(), gomock.Any(), gomock.Any()).
61 Return(&gitlab.GenericPackagesFile{ID: 1, FileName: "renamed.txt", FileSHA256: "abc123"}, nil, nil)
62 tc.MockGenericPackages.EXPECT().
63 FormatPackageURL("OWNER/REPO", "my-package", "1.0.0", "renamed.txt").
64 Return("projects/OWNER%2FREPO/packages/generic/my-package/1.0.0/renamed.txt", nil)
65 },
66 },
67 {
68 name: "Upload package file but API errors",
69 cli: "testdata/localfile.txt --name my-package --version 1.0.0",
70 setupMock: func(tc *gitlabtesting.TestClient) {
71 tc.MockGenericPackages.EXPECT().
72 PublishPackageFile("OWNER/REPO", "my-package", "1.0.0", "localfile.txt", gomock.Any(), gomock.Any(), gomock.Any()).
73 Return(nil, nil, fmt.Errorf("PUT https://gitlab.com/api/v4/projects/OWNER%%2FREPO/packages/generic: 400"))
74 },
75 wantErr: true,
76 wantErrMsg: "failed to upload package file: PUT https://gitlab.com/api/v4/projects/OWNER%2FREPO/packages/generic: 400",
77 },
78 {
79 name: "Upload with invalid file path",
80 cli: "testdata/missingfile.txt --name my-package --version 1.0.0",
81 setupMock: func(tc *gitlabtesting.TestClient) {},
82 wantErr: true,
83 wantErrMsg: "unable to read file at testdata/missingfile.txt: open testdata/missingfile.txt: no such file or directory",
84 },
85 {
86 name: "Upload without required flags",
87 cli: "testdata/localfile.txt",
88 setupMock: func(tc *gitlabtesting.TestClient) {},
89 wantErr: true,
90 errContains: "not set",
91 },
92 }
94 for _, tc := range testCases {
95 t.Run(tc.name, func(t *testing.T) {
96 t.Parallel()
98 testClient := gitlabtesting.NewTestClient(t, gitlab.WithBaseURL("https://"+glinstance.DefaultHostname))
99 tc.setupMock(testClient)
100 exec := cmdtest.SetupCmdForTest(
101 t,
102 NewCmd,
103 false,
104 cmdtest.WithGitLabClient(testClient.Client),
105 )
107 out, err := exec(tc.cli)
109 if tc.wantErr {
110 require.Error(t, err)
111 if tc.errContains != "" {
112 assert.Contains(t, err.Error(), tc.errContains)
113 } else {
114 assert.Equal(t, tc.wantErrMsg, err.Error())
115 }
116 return
117 }
118 require.NoError(t, err)
119 for _, msg := range tc.expectedMsg {
120 assert.Contains(t, out.String(), msg)
121 }
122 })
123 }
124}
Diagnostics8 git calls · 230 ms
CallStatusSizeTime0230 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200263 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=263 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=4445ce4c6a6710742ed094287b245091ae79204f git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=263 git.pkt.payload.max=236 git.sideband.band1.bytes=236 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=236 git.pack.trailer=4126ef8ff4c560b52ccdd91c9d0a185a77d21c2dOpen pack map
fetchtree:0200170 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=170 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=bfc069d2dfe2ce3db69d52f879104796dcf0d973 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=170 git.pkt.payload.max=143 git.sideband.band1.bytes=143 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=143 git.pack.trailer=8c86856ad221ec721b73fe1683288421113cbaedOpen pack map
fetch2001.2 KiB216 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=216 git.response.bytes=1253 git.response.cache=MISS git.response.duration_ms=216 git.fetch.wants=7a268ade87dd2fe05f011a6ab2ada88a929bd06d git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1253 git.pkt.payload.max=1226 git.sideband.band1.bytes=1226 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e26d304a55f4e0
- Request
- ad6bff45…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format