GitLabgitlab-org

cli

main
ply8 git calls270 ms99 KiB5 cachedprotocol v2
244 lines7.5 KiBRaw
1//go:build !integration
3package delete
5import (
6 "fmt"
7 "testing"
9 "git.sr.ht/~timofurrer/ugh"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
12 "go.uber.org/mock/gomock"
14 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
15 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
17 "gitlab.com/gitlab-org/cli/internal/iostreams"
18 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
21func Test_PackagesDelete(t *testing.T) {
22 t.Parallel()
24 const repoName = "OWNER/REPO"
26 type testCase struct {
27 name string
28 cli string
29 expectedMsg []string
30 wantErr bool
31 wantErrMsg string
32 wantErrMsgPart string
33 setupMock func(tc *gitlabtesting.TestClient)
34 }
36 packages := []*gitlab.Package{
37 {ID: 1, Name: "example", Version: "1.0.0", PackageType: "generic"},
38 {ID: 2, Name: "example", Version: "2.0.0", PackageType: "generic"},
39 {ID: 3, Name: "example", Version: "1.0.0", PackageType: "maven"},
40 }
41 expectList := func(tc *gitlabtesting.TestClient) {
42 tc.MockPackages.EXPECT().
43 ListProjectPackages(repoName, gomock.Any(), gomock.Any()).
44 Return(packages, &gitlab.Response{}, nil)
45 }
46 expectDelete := func(tc *gitlabtesting.TestClient, id int64) {
47 tc.MockPackages.EXPECT().
48 DeleteProjectPackage(repoName, id, gomock.Any()).
49 Return(nil, nil)
50 }
51 noMock := func(tc *gitlabtesting.TestClient) {}
53 testCases := []testCase{
54 {
55 name: "Delete package via id arg",
56 cli: "1 -y",
57 expectedMsg: []string{"Deleting package repo=OWNER/REPO packageID=1", "Package 1 deleted."},
58 setupMock: func(tc *gitlabtesting.TestClient) { expectDelete(tc, 1) },
59 },
60 {
61 name: "Delete package via id flag",
62 cli: "--id 1 -y",
63 expectedMsg: []string{"Deleting package repo=OWNER/REPO packageID=1", "Package 1 deleted."},
64 setupMock: func(tc *gitlabtesting.TestClient) { expectDelete(tc, 1) },
65 },
66 {
67 name: "Delete package via name and version defaults to generic type",
68 cli: "--name example --version 2.0.0 -y",
69 expectedMsg: []string{"Deleting package repo=OWNER/REPO packageID=2", "Package 2 deleted."},
70 setupMock: func(tc *gitlabtesting.TestClient) {
71 expectList(tc)
72 expectDelete(tc, 2)
73 },
74 },
75 {
76 name: "Delete package via name, version and explicit type",
77 cli: "--name example --version 1.0.0 --package-type maven -y",
78 expectedMsg: []string{"Deleting package repo=OWNER/REPO packageID=3", "Package 3 deleted."},
79 setupMock: func(tc *gitlabtesting.TestClient) {
80 expectList(tc)
81 expectDelete(tc, 3)
82 },
83 },
84 {
85 name: "Delete package via name but no matching version",
86 cli: "--name example --version 9.9.9 -y",
87 setupMock: expectList,
88 wantErr: true,
89 wantErrMsg: "couldn't locate package \"example\" with package-type \"generic\" and version \"9.9.9\"",
90 },
91 {
92 name: "Delete package via name has no match for an explicit package type",
93 cli: "--name example --version 1.0.0 --package-type npm -y",
94 setupMock: expectList,
95 wantErr: true,
96 wantErrMsg: "couldn't locate package \"example\" with package-type \"npm\" and version \"1.0.0\"",
97 },
98 {
99 name: "Delete package but API errors",
100 cli: "1 -y",
101 setupMock: func(tc *gitlabtesting.TestClient) {
102 tc.MockPackages.EXPECT().
103 DeleteProjectPackage(repoName, int64(1), gomock.Any()).
104 Return(nil, fmt.Errorf("DELETE https://gitlab.com/api/v4/projects/OWNER%%2FREPO/packages/1: 403"))
105 },
106 wantErr: true,
107 wantErrMsg: "failed to delete package: DELETE https://gitlab.com/api/v4/projects/OWNER%2FREPO/packages/1: 403",
108 },
109 {
110 name: "Delete package with non-integer ID",
111 cli: "abc -y",
112 setupMock: noMock,
113 wantErr: true,
114 wantErrMsg: "package ID must be an integer: abc",
115 },
116 {
117 name: "No identifier given",
118 cli: "-y",
119 setupMock: noMock,
120 wantErr: true,
121 wantErrMsg: "provide a package ID argument, or the --id or --name flag",
122 },
123 {
124 name: "Conflicting id argument and --id flag is rejected",
125 cli: "1 --id 2 -y",
126 setupMock: noMock,
127 wantErr: true,
128 wantErrMsg: `the package ID argument "1" cannot be combined with --id or --name`,
129 },
130 {
131 name: "Conflicting id argument and --name flag is rejected",
132 cli: "1 --name example --version 1.0.0 -y",
133 setupMock: noMock,
134 wantErr: true,
135 wantErrMsg: `the package ID argument "1" cannot be combined with --id or --name`,
136 },
137 {
138 name: "--id and --name are mutually exclusive",
139 cli: "--id 1 --name example --version 1.0.0 -y",
140 setupMock: noMock,
141 wantErr: true,
142 wantErrMsgPart: "if any flags in the group [id name] are set none of the others can be; [id name] were all set",
143 },
144 {
145 name: "--name requires --version",
146 cli: "--name example -y",
147 setupMock: noMock,
148 wantErr: true,
149 wantErrMsgPart: "if any flags in the group [name version] are set they must all be set; missing [version]",
150 },
151 {
152 name: "--version requires --name",
153 cli: "--version 1.0.0 -y",
154 setupMock: noMock,
155 wantErr: true,
156 wantErrMsgPart: "if any flags in the group [name version] are set they must all be set; missing [name]",
157 },
158 {
159 name: "--version cannot be combined with an id argument",
160 cli: "1 --version 1.0.0 -y",
161 setupMock: noMock,
162 wantErr: true,
163 wantErrMsgPart: "if any flags in the group [name version] are set they must all be set; missing [name]",
164 },
165 {
166 name: "--package-type cannot be combined with an id",
167 cli: "1 --package-type maven -y",
168 setupMock: noMock,
169 wantErr: true,
170 wantErrMsg: "--package-type can only be used with --name",
171 },
172 {
173 name: "Invalid --package-type is rejected",
174 cli: "--name example --version 1.0.0 --package-type bogus -y",
175 setupMock: noMock,
176 wantErr: true,
177 wantErrMsgPart: `invalid argument "bogus" for "--package-type" flag: must be one of`,
178 },
179 {
180 name: "Delete package non-interactively without -y",
181 cli: "1",
182 setupMock: noMock,
183 wantErr: true,
184 wantErrMsg: "--yes or -y flag is required when not running interactively",
185 },
186 }
188 for _, tc := range testCases {
189 t.Run(tc.name, func(t *testing.T) {
190 t.Parallel()
192 // GIVEN
193 testClient := gitlabtesting.NewTestClient(t)
194 tc.setupMock(testClient)
195 exec := cmdtest.SetupCmdForTest(
196 t,
197 NewCmd,
198 false,
199 cmdtest.WithGitLabClient(testClient.Client),
200 )
202 // WHEN
203 out, err := exec(tc.cli)
205 // THEN
206 if tc.wantErr {
207 require.Error(t, err)
208 if tc.wantErrMsgPart != "" {
209 assert.Contains(t, err.Error(), tc.wantErrMsgPart)
210 } else {
211 assert.Equal(t, tc.wantErrMsg, err.Error())
212 }
213 return
214 }
215 require.NoError(t, err)
216 for _, msg := range tc.expectedMsg {
217 assert.Contains(t, out.String(), msg)
218 }
219 })
220 }
223func Test_PackagesDelete_CancelPrompt(t *testing.T) {
224 testClient := gitlabtesting.NewTestClient(t)
225 // The package must never be deleted when the user declines the prompt.
226 testClient.MockPackages.EXPECT().
227 DeleteProjectPackage(gomock.Any(), gomock.Any(), gomock.Any()).
228 Times(0)
230 c := ugh.New(t)
231 c.Expect(ugh.Confirm("Are you ABSOLUTELY SURE you wish to delete this package 1?")).
232 Do(ugh.Reject)
234 exec := cmdtest.SetupCmdForTest(
235 t,
236 NewCmd,
237 true,
238 cmdtest.WithGitLabClient(testClient.Client),
239 cmdtest.WithConsole(t, c),
240 )
242 _, err := exec("1")
243 require.ErrorIs(t, err, iostreams.ErrUserCancelled)
Diagnostics8 git calls · 270 ms
CallStatusSizeTime0270 ms
discover200185 B3 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=UPDATING
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200263 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=263
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=4445ce4c6a6710742ed094287b245091ae79204f
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=263
git.pkt.payload.max=236
git.sideband.band1.bytes=236
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=236
git.pack.trailer=4126ef8ff4c560b52ccdd91c9d0a185a77d21c2d
Open pack map
fetchtree:0200168 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=256
git.response.bytes=168
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=9d92f1843d9a5bf444d8a7076b49e4947aad98b4
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=168
git.pkt.payload.max=141
git.sideband.band1.bytes=141
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=141
git.pack.trailer=f11d7cf506552a78e18692d286e9d7854ebb7fb6
Open pack map
fetch2002.0 KiB256 ms
git.upload-pack fetch
http.response.status_code=200
git.response.bytes=2007
git.response.cache=MISS
git.response.duration_ms=256
git.fetch.wants=5a16fa737a62bb736d04ac3d32bf1683d670cbbf
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=2007
git.pkt.payload.max=1980
git.sideband.band1.bytes=1980
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e2ba885e7ccf46
Request
e8d1824e…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format