GitLabgitlab-org
cli
main
1//go:build !integration
3package delete_test
5import (
6 "bytes"
7 "testing"
9 "github.com/spf13/cobra"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
12 "go.uber.org/mock/gomock"
14 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
16 "gitlab.com/gitlab-org/cli/internal/cmdutils"
17 "gitlab.com/gitlab-org/cli/internal/commands/packages"
18 packagesDelete "gitlab.com/gitlab-org/cli/internal/commands/packages/delete"
19 "gitlab.com/gitlab-org/cli/internal/mcpannotations"
20 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
21)
23func Test_PackagesDeleteDelAlias(t *testing.T) {
24 t.Parallel()
26 testClient := gitlabtesting.NewTestClient(t)
27 testClient.MockPackages.EXPECT().
28 DeleteProjectPackage("OWNER/REPO", int64(1), gomock.Any()).
29 Return(nil, nil)
31 exec := cmdtest.SetupCmdForTest(t, packages.NewCmd, false, cmdtest.WithGitLabClient(testClient.Client))
33 out, err := exec("del 1 -y")
34 require.NoError(t, err)
35 assert.Contains(t, out.String(), "Package 1 deleted.")
36}
38func Test_PackagesDeleteRmAliasDeprecated(t *testing.T) {
39 t.Parallel()
41 testClient := gitlabtesting.NewTestClient(t)
42 testClient.MockPackages.EXPECT().
43 DeleteProjectPackage("OWNER/REPO", int64(1), gomock.Any()).
44 Return(nil, nil)
46 // Cobra prints the deprecation notice through its own output writer,
47 // which the production root command never wires to the IOStreams, so the
48 // notice lands on stderr. Wire it to a buffer here to assert on it.
49 var cobraOut bytes.Buffer
50 exec := cmdtest.SetupCmdForTest(
51 t,
52 func(f cmdutils.Factory) *cobra.Command {
53 cmd := packages.NewCmd(f)
54 cmd.SetOut(&cobraOut)
55 return cmd
56 },
57 false,
58 cmdtest.WithGitLabClient(testClient.Client),
59 )
61 out, err := exec("rm 1 -y")
62 require.NoError(t, err)
63 assert.Contains(t, out.String(), "Package 1 deleted.")
64 assert.Contains(t, cobraOut.String(), "Command \"rm\" is deprecated, use `glab packages del` instead.")
65}
67func Test_PackagesDeleteRmAliasNotAdvertised(t *testing.T) {
68 t.Parallel()
70 ios, _, _, _ := cmdtest.TestIOStreams()
71 f := cmdtest.NewTestFactory(ios)
73 packagesCmd := packages.NewCmd(f)
74 for _, c := range packagesCmd.Commands() {
75 if c.Name() == "rm" {
76 assert.False(t, c.IsAvailableCommand(), "the deprecated rm command must stay hidden from help, completion, and docs")
77 }
78 }
80 deleteCmd := packagesDelete.NewCmd(f)
81 assert.Equal(t, []string{"del"}, deleteCmd.Aliases)
82}
84func Test_PackagesDeleteRmAliasNotAnMCPTool(t *testing.T) {
85 t.Parallel()
87 ios, _, _, _ := cmdtest.TestIOStreams()
88 f := cmdtest.NewTestFactory(ios)
90 // registerToolsFromCommands registers every annotated command as an MCP
91 // tool and never looks at Hidden/Deprecated, so the rm twin must opt out
92 // via mcp:exclude instead of surfacing as a duplicate of glab_packages_delete.
93 rmCmd := packagesDelete.NewRmCmd(f)
94 assert.Equal(t, "true", rmCmd.Annotations[mcpannotations.Exclude])
95}
Diagnostics8 git calls · 341 ms
CallStatusSizeTime0341 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit5 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=5 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=5 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200263 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=263 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=4445ce4c6a6710742ed094287b245091ae79204f git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=263 git.pkt.payload.max=236 git.sideband.band1.bytes=236 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=236 git.pack.trailer=4126ef8ff4c560b52ccdd91c9d0a185a77d21c2dOpen pack map
fetchtree:0200168 B · hit4 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=4 git.response.bytes=168 git.response.cache=HIT git.response.duration_ms=4 git.fetch.filter=tree:0 git.fetch.wants=9d92f1843d9a5bf444d8a7076b49e4947aad98b4 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=168 git.pkt.payload.max=141 git.sideband.band1.bytes=141 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=141 git.pack.trailer=f11d7cf506552a78e18692d286e9d7854ebb7fb6Open pack map
fetch2001.1 KiB322 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=322 git.response.bytes=1152 git.response.cache=MISS git.response.duration_ms=322 git.fetch.wants=7a60b90074f97e406d40c2f57b82f76e1ab98517 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1152 git.pkt.payload.max=1125 git.sideband.band1.bytes=1125 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2c81998d74b67
- Request
- 0bd70579…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format