GitLabgitlab-org
cli
main
1//go:build !integration
3package update
5import (
6 "testing"
8 "github.com/stretchr/testify/assert"
9 "github.com/stretchr/testify/require"
10 "go.uber.org/mock/gomock"
12 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
13 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
15 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
16)
18func TestUpdateMergeRequest_State(t *testing.T) {
19 for _, tt := range []struct {
20 name string
21 args string
22 state *string
23 ambiguous bool
24 }{
25 {name: "opened", args: "feature --state opened --title changed", state: new("opened")},
26 {name: "closed", args: "feature --state closed --title changed", state: new("closed")},
27 {name: "merged", args: "feature --state merged --title changed", state: new("merged")},
28 {name: "locked", args: "feature --state locked --title changed", state: new("locked")},
29 {name: "default retains ambiguity", args: "feature --title changed", ambiguous: true},
30 {name: "any retains ambiguity", args: "feature --state any --title changed", ambiguous: true},
31 {name: "current branch", args: "--state opened --title changed", state: new("opened")},
32 } {
33 t.Run(tt.name, func(t *testing.T) {
34 tc := gitlabtesting.NewTestClient(t)
35 mrs := []*gitlab.BasicMergeRequest{{IID: 1, Author: &gitlab.BasicUser{Username: "author"}}}
36 if tt.ambiguous {
37 mrs = append(mrs, &gitlab.BasicMergeRequest{IID: 2, Author: &gitlab.BasicUser{Username: "author"}})
38 }
39 calls := []any{tc.MockMergeRequests.EXPECT().ListProjectMergeRequests("OWNER/REPO", gomock.Any()).DoAndReturn(
40 func(_ any, opts *gitlab.ListProjectMergeRequestsOptions, _ ...gitlab.RequestOptionFunc) ([]*gitlab.BasicMergeRequest, *gitlab.Response, error) {
41 assert.Equal(t, tt.state, opts.State)
42 assert.Equal(t, "feature", *opts.SourceBranch)
43 return mrs, nil, nil
44 },
45 ).Call}
46 if !tt.ambiguous {
47 mr := &gitlab.MergeRequest{BasicMergeRequest: gitlab.BasicMergeRequest{IID: 1, Title: "original", State: "opened"}}
48 calls = append(calls,
49 tc.MockMergeRequests.EXPECT().GetMergeRequest("OWNER/REPO", int64(1), gomock.Any()).Return(mr, nil, nil).Call,
50 tc.MockMergeRequests.EXPECT().UpdateMergeRequest("OWNER/REPO", int64(1), gomock.Any()).DoAndReturn(
51 func(_ any, _ int64, opts *gitlab.UpdateMergeRequestOptions, _ ...gitlab.RequestOptionFunc) (*gitlab.MergeRequest, *gitlab.Response, error) {
52 assert.Equal(t, "changed", *opts.Title)
53 mr.Title = *opts.Title
54 return mr, nil, nil
55 },
56 ).Call,
57 )
58 }
59 gomock.InOrder(calls...)
60 exec := cmdtest.SetupCmdForTest(t, NewCmdUpdate, false, cmdtest.WithGitLabClient(tc.Client), cmdtest.WithBranch("feature"))
62 out, err := exec(tt.args)
64 if tt.ambiguous {
65 require.ErrorContains(t, err, "merge request ID number required")
66 return
67 }
68 require.NoError(t, err)
69 assert.Contains(t, out.String(), "changed")
70 })
71 }
72}
74func TestUpdateMergeRequest_StateInvalid(t *testing.T) {
75 tc := gitlabtesting.NewTestClient(t)
76 exec := cmdtest.SetupCmdForTest(t, NewCmdUpdate, false, cmdtest.WithGitLabClient(tc.Client))
78 _, err := exec("feature --state invalid --title changed")
80 require.ErrorContains(t, err, "must be one of")
81}
83func TestUpdateMergeRequest_StateWithIDOrURL(t *testing.T) {
84 for _, target := range []string{"1", "https://gitlab.com/OWNER/REPO/-/merge_requests/1"} {
85 t.Run(target, func(t *testing.T) {
86 tc := gitlabtesting.NewTestClient(t)
87 mr := &gitlab.MergeRequest{BasicMergeRequest: gitlab.BasicMergeRequest{IID: 1, Title: "original", State: "opened"}}
88 gomock.InOrder(
89 tc.MockMergeRequests.EXPECT().GetMergeRequest("OWNER/REPO", int64(1), gomock.Any()).Return(mr, nil, nil).Call,
90 tc.MockMergeRequests.EXPECT().UpdateMergeRequest("OWNER/REPO", int64(1), gomock.Any()).Return(mr, nil, nil).Call,
91 )
92 exec := cmdtest.SetupCmdForTest(t, NewCmdUpdate, false, cmdtest.WithGitLabClient(tc.Client))
94 _, err := exec(target + " --state closed --title changed")
96 require.NoError(t, err)
97 })
98 }
99}
Diagnostics8 git calls · 302 ms
CallStatusSizeTime0302 ms
discover200185 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200746 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=746 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=f3d413a22af5a9c2fe9aa49709b1cb36d1351a7f git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=746 git.pkt.payload.max=719 git.sideband.band1.bytes=719 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=719 git.pack.trailer=330baf80c59a4208b55120dff7dd824b7952b790Open pack map
fetchtree:0200202 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=202 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=fa6643fe030fa248faec6c90791640385205057a git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=202 git.pkt.payload.max=175 git.sideband.band1.bytes=175 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=175 git.pack.trailer=5de59e2c2970b3a7ffbcd12e501883f267881024Open pack map
fetch2001.2 KiB289 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=289 git.response.bytes=1223 git.response.cache=MISS git.response.duration_ms=289 git.fetch.wants=61cfc5f823e430f275e0045d86cd2bf1fee7f8c1 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1223 git.pkt.payload.max=1196 git.sideband.band1.bytes=1196 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2c1901c6a89da
- Request
- 7e858c27…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format