GitLabgitlab-org
cli
main
1//go:build !integration
3package mrutils
5import (
6 "errors"
7 "net/http"
8 "testing"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
12 "go.uber.org/mock/gomock"
14 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
15 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
16)
18func TestCreateUniqueBranch(t *testing.T) {
19 t.Parallel()
21 branchExists := &gitlab.ErrorResponse{StatusCode: http.StatusBadRequest, Message: "{message: Branch already exists}"}
23 tests := []struct {
24 name string
25 branchErrors []error
26 wantBranches []string
27 wantBranch string
28 wantErr string
29 }{
30 {
31 name: "creates the branch",
32 branchErrors: []error{nil},
33 wantBranches: []string{"7-fix-bug"},
34 wantBranch: "7-fix-bug",
35 },
36 {
37 name: "numbers the name while the branch exists",
38 branchErrors: []error{branchExists, branchExists, nil},
39 wantBranches: []string{"7-fix-bug", "7-fix-bug-1", "7-fix-bug-2"},
40 wantBranch: "7-fix-bug-2",
41 },
42 {
43 name: "numbers the name while a branch below it exists",
44 branchErrors: []error{&gitlab.ErrorResponse{StatusCode: http.StatusBadRequest, Message: "{message: Failed to create branch '7-fix-bug': Branch name conflicts with existing branch hierarchy.}"}, nil},
45 wantBranches: []string{"7-fix-bug", "7-fix-bug-1"},
46 wantBranch: "7-fix-bug-1",
47 },
48 {
49 name: "returns an invalid name error",
50 branchErrors: []error{&gitlab.ErrorResponse{StatusCode: http.StatusBadRequest, Message: "{message: Branch name is invalid}"}},
51 wantBranches: []string{"7-fix-bug"},
52 wantErr: `could not create branch "7-fix-bug": 400 {message: Branch name is invalid}`,
53 },
54 {
55 name: "returns an existing branch error with another status",
56 branchErrors: []error{&gitlab.ErrorResponse{StatusCode: http.StatusConflict, Message: "{message: Branch already exists}"}},
57 wantBranches: []string{"7-fix-bug"},
58 wantErr: `could not create branch "7-fix-bug": 409 {message: Branch already exists}`,
59 },
60 {
61 name: "returns a permission error",
62 branchErrors: []error{&gitlab.ErrorResponse{StatusCode: http.StatusForbidden, Message: "{message: 403 Forbidden}"}},
63 wantBranches: []string{"7-fix-bug"},
64 wantErr: `could not create branch "7-fix-bug": 403 {message: 403 Forbidden}`,
65 },
66 {
67 name: "returns an error without a response",
68 branchErrors: []error{errors.New("connection refused")},
69 wantBranches: []string{"7-fix-bug"},
70 wantErr: `could not create branch "7-fix-bug": connection refused`,
71 },
72 }
74 for _, tt := range tests {
75 t.Run(tt.name, func(t *testing.T) {
76 t.Parallel()
78 tc := gitlabtesting.NewTestClient(t)
79 var branches []string
80 tc.MockBranches.EXPECT().
81 CreateBranch("OWNER/REPO", gomock.Any(), gomock.Any()).
82 DoAndReturn(func(_ any, opt *gitlab.CreateBranchOptions, _ ...gitlab.RequestOptionFunc) (*gitlab.Branch, *gitlab.Response, error) {
83 assert.Equal(t, "main", *opt.Ref)
84 branches = append(branches, *opt.Branch)
85 if err := tt.branchErrors[len(branches)-1]; err != nil {
86 return nil, nil, err
87 }
88 return &gitlab.Branch{Name: *opt.Branch}, nil, nil
89 }).
90 Times(len(tt.branchErrors))
92 got, err := CreateUniqueBranch(t.Context(), tc.Client, "OWNER/REPO", "7-fix-bug", "main")
94 assert.Equal(t, tt.wantBranches, branches)
95 if tt.wantErr != "" {
96 require.EqualError(t, err, tt.wantErr)
97 assert.Empty(t, got)
98 return
99 }
100 require.NoError(t, err)
101 assert.Equal(t, tt.wantBranch, got)
102 })
103 }
104}
106func TestCreateUniqueBranch_StopsAfterMaxBranchSuffix(t *testing.T) {
107 t.Parallel()
109 tc := gitlabtesting.NewTestClient(t)
110 var branches []string
111 tc.MockBranches.EXPECT().
112 CreateBranch("OWNER/REPO", gomock.Any(), gomock.Any()).
113 DoAndReturn(func(_ any, opt *gitlab.CreateBranchOptions, _ ...gitlab.RequestOptionFunc) (*gitlab.Branch, *gitlab.Response, error) {
114 branches = append(branches, *opt.Branch)
115 return nil, nil, &gitlab.ErrorResponse{StatusCode: http.StatusBadRequest, Message: "{message: Branch already exists}"}
116 }).
117 Times(maxBranchSuffix + 1)
119 got, err := CreateUniqueBranch(t.Context(), tc.Client, "OWNER/REPO", "7-fix-bug", "main")
121 require.EqualError(t, err, `could not create branch "7-fix-bug-100": 400 {message: Branch already exists}`)
122 assert.Empty(t, got)
123 require.Len(t, branches, maxBranchSuffix+1)
124 assert.Equal(t, "7-fix-bug", branches[0])
125 assert.Equal(t, "7-fix-bug-1", branches[1])
126 assert.Equal(t, "7-fix-bug-100", branches[maxBranchSuffix])
127}
Diagnostics8 git calls · 251 ms
CallStatusSizeTime0251 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200746 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=746 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=f3d413a22af5a9c2fe9aa49709b1cb36d1351a7f git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=746 git.pkt.payload.max=719 git.sideband.band1.bytes=719 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=719 git.pack.trailer=330baf80c59a4208b55120dff7dd824b7952b790Open pack map
fetchtree:0200469 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=469 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=6020159a68b7314d330ee4ac0f7529b651d7accc git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=469 git.pkt.payload.max=442 git.sideband.band1.bytes=442 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=442 git.pack.trailer=97b1fd715810f2e169ed93a75830c9ee2eff1fc0Open pack map
fetch2001.2 KiB237 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=237 git.response.bytes=1263 git.response.cache=MISS git.response.duration_ms=237 git.fetch.wants=fb9ca25804572d40ac0cbbc45c298effaf024598 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1263 git.pkt.payload.max=1236 git.sideband.band1.bytes=1236 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2e1d03b634af4
- Request
- d1a53f17…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format