GitLabgitlab-org

cli

main
ply8 git calls30 ms99 KiB7 cachedprotocol v2
98 lines2.2 KiBRaw
1//go:build !integration
3package close
5import (
6 "testing"
8 "github.com/MakeNowJust/heredoc/v2"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
11 "go.uber.org/mock/gomock"
13 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
14 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
16 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
19func TestMrClose(t *testing.T) {
20 type testCase struct {
21 name string
22 cli string
23 expectedOut string
24 wantErr bool
25 wantStderr string
26 setupMock func(tc *gitlabtesting.TestClient)
27 }
29 testMROpened := &gitlab.MergeRequest{
30 BasicMergeRequest: gitlab.BasicMergeRequest{
31 ID: 123,
32 IID: 123,
33 ProjectID: 3,
34 Title: "test mr title",
35 Description: "test mr description",
36 State: "opened",
37 DetailedMergeStatus: "ci_must_pass",
38 },
39 }
41 testMRClosed := &gitlab.MergeRequest{
42 BasicMergeRequest: gitlab.BasicMergeRequest{
43 ID: 123,
44 IID: 123,
45 ProjectID: 3,
46 Title: "test mr title",
47 Description: "test mr description",
48 State: "closed",
49 },
50 }
52 testCases := []testCase{
53 {
54 name: "when an MR is closed using an MR id",
55 cli: "123",
56 expectedOut: heredoc.Doc(`
57 - Closing merge request...
58 ✓ Closed merge request !123.
60 `),
61 setupMock: func(tc *gitlabtesting.TestClient) {
62 tc.MockMergeRequests.EXPECT().
63 GetMergeRequest("OWNER/REPO", int64(123), gomock.Any()).
64 Return(testMROpened, nil, nil)
65 tc.MockMergeRequests.EXPECT().
66 UpdateMergeRequest("OWNER/REPO", int64(123), gomock.Any()).
67 Return(testMRClosed, nil, nil)
68 },
69 },
70 }
72 for _, tc := range testCases {
73 t.Run(tc.name, func(t *testing.T) {
74 // GIVEN
75 testClient := gitlabtesting.NewTestClient(t)
76 tc.setupMock(testClient)
77 exec := cmdtest.SetupCmdForTest(
78 t,
79 NewCmdClose,
80 false,
81 cmdtest.WithGitLabClient(testClient.Client),
82 )
84 // WHEN
85 out, err := exec(tc.cli)
87 // THEN
88 if tc.wantErr {
89 require.Error(t, err)
90 assert.Contains(t, err.Error(), tc.wantStderr)
91 return
92 }
93 require.NoError(t, err)
94 assert.Equal(t, tc.expectedOut, out.OutBuf.String())
95 assert.Empty(t, out.ErrBuf.String())
96 })
97 }
Diagnostics8 git calls · 30 ms
CallStatusSizeTime030 ms
discover200185 B2 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=HIT
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200746 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=746
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=f3d413a22af5a9c2fe9aa49709b1cb36d1351a7f
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=746
git.pkt.payload.max=719
git.sideband.band1.bytes=719
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=719
git.pack.trailer=330baf80c59a4208b55120dff7dd824b7952b790
Open pack map
fetchtree:0200140 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=18
git.response.bytes=140
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=9061cc971b967da73b96b726a3d56c476e43f9f8
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=140
git.pkt.payload.max=113
git.sideband.band1.bytes=113
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=113
git.pack.trailer=5992c1d03fb3af46d2a45c78c7b1714d3c516226
Open pack map
fetch200957 B · hit18 ms
git.upload-pack fetch
http.response.status_code=200
git.response.bytes=957
git.response.cache=HIT
git.response.duration_ms=18
git.fetch.wants=604389b6ba30cd924174be925b2268cc2c9fd372
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=957
git.pkt.payload.max=930
git.sideband.band1.bytes=930
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5eafa4e1d9fb1bb
Request
0d60a19f…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format