GitLabgitlab-org

cli

main
ply8 git calls194 ms98 KiB6 cachedprotocol v2
97 lines2.5 KiBRaw
1//go:build !integration
3package approve
5import (
6 "testing"
8 "github.com/MakeNowJust/heredoc/v2"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
11 "go.uber.org/mock/gomock"
13 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
14 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
16 "gitlab.com/gitlab-org/cli/internal/glinstance"
17 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
20func TestMrApprove(t *testing.T) {
21 t.Parallel()
23 tc := gitlabtesting.NewTestClient(t)
25 // Mock getting the merge request
26 tc.MockMergeRequests.EXPECT().
27 GetMergeRequest("OWNER/REPO", int64(123), gomock.Any(), gomock.Any()).
28 Return(&gitlab.MergeRequest{
29 BasicMergeRequest: gitlab.BasicMergeRequest{
30 ID: 123,
31 IID: 123,
32 ProjectID: 3,
33 Title: "test mr title",
34 Description: "test mr description",
35 State: "opened",
36 },
37 }, nil, nil)
39 // Mock approving the merge request
40 tc.MockMergeRequestApprovals.EXPECT().
41 ApproveMergeRequest("OWNER/REPO", int64(123), gomock.Any(), gomock.Any()).
42 Return(&gitlab.MergeRequestApprovals{}, nil, nil)
44 exec := cmdtest.SetupCmdForTest(t, NewCmdApprove, false,
45 cmdtest.WithGitLabClient(tc.Client),
46 cmdtest.WithBaseRepo("OWNER", "REPO", glinstance.DefaultHostname),
47 )
49 output, err := exec("123")
51 require.NoError(t, err)
52 assert.Equal(t, heredoc.Doc(`
53 - Approving merge request !123
54 ✓ Approved
55 `), output.String())
56 assert.Empty(t, output.Stderr())
59func TestMrApproveDraft(t *testing.T) {
60 t.Parallel()
62 tc := gitlabtesting.NewTestClient(t)
64 // Mock getting a draft merge request
65 tc.MockMergeRequests.EXPECT().
66 GetMergeRequest("OWNER/REPO", int64(456), gomock.Any(), gomock.Any()).
67 Return(&gitlab.MergeRequest{
68 BasicMergeRequest: gitlab.BasicMergeRequest{
69 ID: 456,
70 IID: 456,
71 ProjectID: 3,
72 Title: "Draft: test mr title",
73 Description: "test mr description",
74 State: "opened",
75 Draft: true,
76 },
77 }, nil, nil)
79 // Mock approving the draft merge request
80 tc.MockMergeRequestApprovals.EXPECT().
81 ApproveMergeRequest("OWNER/REPO", int64(456), gomock.Any(), gomock.Any()).
82 Return(&gitlab.MergeRequestApprovals{}, nil, nil)
84 exec := cmdtest.SetupCmdForTest(t, NewCmdApprove, false,
85 cmdtest.WithGitLabClient(tc.Client),
86 cmdtest.WithBaseRepo("OWNER", "REPO", glinstance.DefaultHostname),
87 )
89 output, err := exec("456")
91 require.NoError(t, err)
92 assert.Equal(t, heredoc.Doc(`
93 - Approving merge request !456
94 ✓ Approved
95 `), output.String())
96 assert.Empty(t, output.Stderr())
Diagnostics8 git calls · 194 ms
CallStatusSizeTime0194 ms
discover200185 B4 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=4
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB · hit4 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=4
git.response.bytes=59849
git.response.cache=HIT
git.response.duration_ms=4
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchtree:02001.8 KiB · hit1 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=1
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=1
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200746 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=746
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=f3d413a22af5a9c2fe9aa49709b1cb36d1351a7f
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=746
git.pkt.payload.max=719
git.sideband.band1.bytes=719
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=719
git.pack.trailer=330baf80c59a4208b55120dff7dd824b7952b790
Open pack map
fetchtree:0200142 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=142
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=3df9b705e1fe70f7120a3eb6dc0898b0054888cf
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=142
git.pkt.payload.max=115
git.sideband.band1.bytes=115
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=115
git.pack.trailer=5501cd973324b32f2d614d042cc1a89780624bee
Open pack map
fetch200798 B181 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=181
git.response.bytes=798
git.response.cache=MISS
git.response.duration_ms=181
git.fetch.wants=feafa9cae8a94804659fe4f714340fc62574f566
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=798
git.pkt.payload.max=771
git.sideband.band1.bytes=771
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e315325c573e6e
Request
5858d861…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format