GitLabgitlab-org

cli

main
ply7 git calls207 ms99 KiB4 cachedprotocol v2
148 lines4.7 KiBRaw
1//go:build !integration
3package minder
5import (
6 "context"
7 "errors"
8 "os"
9 "path/filepath"
10 "testing"
12 "github.com/spf13/cobra"
13 "github.com/stretchr/testify/assert"
14 "github.com/stretchr/testify/require"
16 "gitlab.com/gitlab-org/cli/internal/binarymgr"
17 "gitlab.com/gitlab-org/cli/internal/cmdutils"
18 "gitlab.com/gitlab-org/cli/internal/config"
19 "gitlab.com/gitlab-org/cli/internal/iostreams"
20 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
23func TestNewCmd_PassthroughStructure(t *testing.T) {
24 t.Parallel()
25 ios, _, _, _ := cmdtest.TestIOStreams()
26 f := cmdtest.NewTestFactory(ios)
28 cmd := NewCmd(f)
30 assert.Equal(t, "minder", cmd.Name())
31 assert.True(t, cmd.DisableFlagParsing)
32 assert.Equal(t, "true", cmd.Annotations["mcp:exclude"])
33 assert.NotNil(t, cmd.Flags().Lookup("install"))
34 assert.NotNil(t, cmd.Flags().Lookup("update"))
35 yesFlag := cmd.Flags().Lookup("yes")
36 require.NotNil(t, yesFlag)
37 assert.Equal(t, "y", yesFlag.Shorthand)
39 // Governance subcommands must be attached so they take priority over the
40 // pass-through; everything else forwards to agent-client.
41 subs := map[string]struct{}{}
42 for _, c := range cmd.Commands() {
43 subs[c.Name()] = struct{}{}
44 }
45 assert.Contains(t, subs, "setup", "setup subcommand must be registered")
46 assert.Contains(t, subs, "doctor", "doctor subcommand must be registered")
47 assert.Contains(t, subs, "audit", "audit subcommand must be registered")
48 assert.Contains(t, subs, "update", "update subcommand must be registered")
51func TestValidate_InstallUpdateMutuallyExclusive(t *testing.T) {
52 t.Parallel()
53 opts := &options{flags: binarymgr.SplitFlags([]string{"--install", "--update"})}
55 err := opts.validate()
56 require.Error(t, err)
57 assert.Contains(t, err.Error(), "mutually exclusive")
60func TestValidate_InstallWithCommandErrors(t *testing.T) {
61 t.Parallel()
62 opts := &options{flags: binarymgr.SplitFlags([]string{"--update", "install"})}
64 err := opts.validate()
65 require.Error(t, err)
66 assert.Contains(t, err.Error(), "cannot be combined with a command")
69// The downloaded binary's real feature tree lives under `agent-client agent`,
70// so exec must prepend the literal "agent" subcommand before pass-through args.
71func TestExec_PrependsAgentSubcommand(t *testing.T) {
72 t.Parallel()
73 ios, _, _, _ := cmdtest.TestIOStreams()
75 var gotArgs []string
76 opts := &options{
77 io: ios,
78 execute: func(_ context.Context, _ *iostreams.IOStreams, _ string, args []string) error {
79 gotArgs = args
80 return nil
81 },
82 flags: binarymgr.SplitFlags([]string{"install"}),
83 }
85 require.NoError(t, opts.exec(t.Context(), "/tmp/agent-client", opts.flags.Forwarded))
86 assert.Equal(t, []string{"agent", "install"}, gotArgs)
89func TestNewCmd_HelpShowsGlabTextUntilBinaryIsInstalled(t *testing.T) {
90 t.Setenv("GLAB_MINDER_CLI_BINARY_PATH", filepath.Join(t.TempDir(), "missing-agent"))
91 exec := cmdtest.SetupCmdForTest(t, func(f cmdutils.Factory) *cobra.Command {
92 cmd := NewCmd(f)
93 cmd.SetOut(f.IO().StdOut)
94 return cmd
95 }, false, cmdtest.WithConfig(config.NewBlankConfig()))
97 for _, args := range []string{"", "--help", "-h status"} {
98 out, err := exec(args)
99 require.NoError(t, err, args)
100 assert.Contains(t, out.String(), "GitLab Endpoint Agent Platform", args)
101 }
104func TestRunHelp_ExecsInstalledBinaryWithAgentSubcommand(t *testing.T) {
105 binary := filepath.Join(t.TempDir(), "agent-client")
106 require.NoError(t, os.WriteFile(binary, []byte("#!/bin/sh\n"), 0o755))
107 t.Setenv("GLAB_MINDER_CLI_BINARY_PATH", binary)
108 ios, _, _, _ := cmdtest.TestIOStreams()
109 f := cmdtest.NewTestFactory(ios, cmdtest.WithConfig(config.NewBlankConfig()))
111 var gotPath string
112 var gotArgs []string
113 opts := &options{
114 io: ios,
115 cfg: f.Config(),
116 flags: binarymgr.SplitFlags([]string{"--help"}),
117 help: func() error { return errors.New("glab help must not render") },
118 execute: func(_ context.Context, _ *iostreams.IOStreams, path string, args []string) error {
119 gotPath = path
120 gotArgs = args
121 return nil
122 },
123 }
125 require.NoError(t, opts.runHelp(t.Context()))
126 assert.Equal(t, binary, gotPath)
127 assert.Equal(t, []string{"agent", "--help"}, gotArgs)
130func TestRunHelp_FallsBackToGlabTextWhenBinaryIsMissing(t *testing.T) {
131 t.Setenv("GLAB_MINDER_CLI_BINARY_PATH", filepath.Join(t.TempDir(), "missing-agent"))
132 ios, _, _, _ := cmdtest.TestIOStreams()
133 f := cmdtest.NewTestFactory(ios, cmdtest.WithConfig(config.NewBlankConfig()))
135 helpRendered := false
136 opts := &options{
137 io: ios,
138 cfg: f.Config(),
139 flags: binarymgr.SplitFlags([]string{"--help"}),
140 help: func() error { helpRendered = true; return nil },
141 execute: func(context.Context, *iostreams.IOStreams, string, []string) error {
142 return errors.New("must not exec a missing binary")
143 },
144 }
146 require.NoError(t, opts.runHelp(t.Context()))
147 assert.True(t, helpRendered)
Diagnostics7 git calls · 207 ms
CallStatusSizeTime0207 ms
discover200185 B2 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=UPDATING
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200241 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=241
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=79740b14aefc97e4d2d04e598672322d6dab5cc0
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=241
git.pkt.payload.max=214
git.sideband.band1.bytes=214
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=214
git.pack.trailer=925f2c55d53735f9b92a56b9a91a7277da21e0b5
Open pack map
fetch2001.6 KiB195 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=195
git.response.bytes=1606
git.response.cache=MISS
git.response.duration_ms=195
git.fetch.wants=5d4c81fa1c88cb7996ae721b1496e347eabca037
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1606
git.pkt.payload.max=1579
git.sideband.band1.bytes=1579
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e2c10e1acf89da
Request
29d8d315…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format