GitLabgitlab-org
cli
main
1//go:build !integration
3package artifact
5import (
6 "archive/zip"
7 "bytes"
8 "io"
9 "os"
10 "path/filepath"
11 "strconv"
12 "testing"
14 "github.com/stretchr/testify/require"
15)
17const numTestFiles = 100
19func createTestZipFile(t *testing.T) string {
20 t.Helper()
22 tempFile, err := os.CreateTemp(t.TempDir(), "temp-*.zip")
23 if err != nil {
24 t.Fatalf("Create temp file: %v", err)
25 }
27 zipWriter := zip.NewWriter(tempFile)
29 for i := range numTestFiles {
30 fileName := "file-" + strconv.Itoa(i) + ".txt"
32 fileWriter, err := zipWriter.Create(fileName)
33 if err != nil {
34 t.Fatalf("Create zip: %v", err)
35 }
37 _, err = fileWriter.Write([]byte(fileName))
38 if err != nil {
39 t.Fatalf("Write zip: %v", err)
40 }
41 }
43 if err := zipWriter.Close(); err != nil {
44 t.Fatalf("Close zip: %v", err)
45 }
47 if err := tempFile.Close(); err != nil {
48 t.Fatalf("Close temp: %v", err)
49 }
51 return tempFile.Name()
52}
54func toByteReader(zipFilePath string) (*bytes.Reader, error) {
55 zipBytes, err := os.ReadFile(zipFilePath)
56 if err != nil {
57 return nil, err
58 }
60 return bytes.NewReader(zipBytes), nil
61}
63func listFilesInDir(dirPath string) ([]string, error) {
64 var files []string
65 entries, err := os.ReadDir(dirPath)
66 if err != nil {
67 return nil, err
68 }
70 for _, entry := range entries {
71 if !entry.IsDir() {
72 files = append(files, entry.Name())
73 }
74 }
75 return files, nil
76}
78func TestAcceptableZipFile(t *testing.T) {
79 zipName := createTestZipFile(t)
81 reader, err := toByteReader(zipName)
82 require.NoError(t, err)
84 targetDir := t.TempDir()
86 var buf bytes.Buffer
87 listPaths := true
88 err = readZip(reader, targetDir, listPaths, defaultZIPReadLimit, defaultZIPFileLimit, &buf)
89 stdout := buf.String()
90 require.NoError(t, err)
92 files, err := listFilesInDir(targetDir)
93 require.NoError(t, err)
94 require.Len(t, files, numTestFiles)
96 cwd, err := os.Getwd()
97 require.NoError(t, err)
99 for _, file := range files {
100 path := filepath.Join(targetDir, file)
101 content, err := os.ReadFile(path)
102 require.NoError(t, err)
103 require.Equal(t, file, string(content))
105 // friendlyPath returns a relative path when possible; fall back to absolute.
106 expectedPath := path
107 if rel, err := filepath.Rel(cwd, path); err == nil {
108 expectedPath = rel
109 }
110 require.Contains(t, stdout, expectedPath)
111 }
112}
114func TestFileLimitExceeded(t *testing.T) {
115 zipName := createTestZipFile(t)
117 reader, err := toByteReader(zipName)
118 require.NoError(t, err)
120 err = readZip(reader, t.TempDir(), false, defaultZIPReadLimit, 50, io.Discard)
121 require.Error(t, err)
122 require.Contains(t, err.Error(), "zip archive includes too many files")
123}
125func TestReadLimitExceeded(t *testing.T) {
126 zipName := createTestZipFile(t)
128 reader, err := toByteReader(zipName)
129 require.NoError(t, err)
131 err = readZip(reader, t.TempDir(), false, 50, defaultZIPFileLimit, io.Discard)
132 require.Error(t, err)
133 require.Contains(t, err.Error(), "extracted zip too large")
134}
Diagnostics8 git calls · 287 ms
CallStatusSizeTime0287 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=59849 git.response.cache=UPDATING git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200169 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=169 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=014f8e3d040dd5bbfbad786ad7dada84dc7810ce git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=169 git.pkt.payload.max=142 git.sideband.band1.bytes=142 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=142 git.pack.trailer=47a57f7b9b54feb1a2cb60673fb63b93f55a03c8Open pack map
fetchtree:0200169 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=275 git.response.bytes=169 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=d94ab6b39f4e57708ce09cd3b84c4cc080d0cc18 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=169 git.pkt.payload.max=142 git.sideband.band1.bytes=142 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=142 git.pack.trailer=4bd95bfd76a3b40ee067e0aaec3ca757f3f5feb5Open pack map
fetch2001.1 KiB275 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1076 git.response.cache=MISS git.response.duration_ms=275 git.fetch.wants=149538cc0699e8063655dc088bc539b30e183eb9 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1076 git.pkt.payload.max=1049 git.sideband.band1.bytes=1049 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2ff99799ff3c9
- Request
- 30f77e86…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format