GitLabgitlab-org
cli
main
1//go:build integration
3package update
5import (
6 "fmt"
7 "io"
8 "testing"
9 "time"
11 "github.com/acarl005/stripansi"
12 "github.com/google/shlex"
13 "github.com/stretchr/testify/assert"
14 "github.com/stretchr/testify/require"
16 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
18 "gitlab.com/gitlab-org/cli/internal/api"
19 "gitlab.com/gitlab-org/cli/internal/cmdutils"
20 "gitlab.com/gitlab-org/cli/internal/config"
21 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
22 "gitlab.com/gitlab-org/cli/test"
23)
25func TestNewCmdUpdate_Integration(t *testing.T) {
26 glTestHost := test.GetHostOrSkip(t)
28 oldUpdateIssue := api.UpdateIssue
29 timer, _ := time.Parse(time.RFC3339, "2014-11-12T11:45:26.371Z")
30 testIssue := &gitlab.Issue{
31 ID: 1,
32 IID: 1,
33 State: "closed",
34 Labels: gitlab.Labels{"bug, test, removeable-label"},
35 Description: "Dummy description for issue 1",
36 DiscussionLocked: false,
37 Author: &gitlab.IssueAuthor{
38 ID: 1,
39 Name: "John Dev Wick",
40 Username: "jdwick",
41 },
42 CreatedAt: &timer,
43 }
44 api.UpdateIssue = func(client *gitlab.Client, projectID any, issueID int64, opts *gitlab.UpdateIssueOptions) (*gitlab.Issue, error) {
45 if projectID == "" || projectID == "WRONG_REPO" || projectID == "expected_err" || issueID != testIssue.ID {
46 return nil, fmt.Errorf("error expected")
47 }
48 if *opts.Title != "" {
49 testIssue.Title = *opts.Title
50 }
51 if *opts.Description != "" {
52 testIssue.Description = *opts.Description
53 }
54 if opts.AddLabels != nil {
55 testIssue.Labels = gitlab.Labels(*opts.AddLabels)
56 }
57 return testIssue, nil
58 }
60 testCases := []struct {
61 Name string
62 Issue string
63 ExpectedMsg []string
64 wantErr bool
65 }{
66 {
67 Name: "Issue Exists",
68 Issue: fmt.Sprintf(`-R %s/cli-automated-testing/test 1 -t "New Title" -d "A new description" --lock-discussion -l newLabel --unlabel bug`, glTestHost),
69 ExpectedMsg: []string{
70 "- Updating issue #1",
71 "✓ updated title to \"New Title\"",
72 "✓ locked discussion",
73 "✓ added labels newLabel",
74 "✓ removed labels bug",
75 "#1 New Title",
76 },
77 },
78 {
79 Name: "Issue Does Not Exist",
80 Issue: "0",
81 ExpectedMsg: []string{"- Updating issue #0", "error expected"},
82 wantErr: true,
83 },
84 {
85 Name: "Due date applied",
86 Issue: fmt.Sprintf(`-R %s/cli-automated-testing/test 1 -t "New Title" --due-date 2025-07-22`, glTestHost),
87 ExpectedMsg: []string{
88 "- Updating issue #1",
89 "✓ updated title to \"New Title\"",
90 "✓ added due date",
91 "#1 New Title",
92 },
93 },
94 }
96 cfg, err := config.Init()
97 require.NoError(t, err)
98 ios, _, stdout, stderr := cmdtest.TestIOStreams(cmdtest.WithTestIOStreamsAsTTY(true))
99 f := cmdutils.NewFactory(ios, false, cfg, api.BuildInfo{})
101 cmd := NewCmdUpdate(f)
102 cmdutils.EnableRepoOverride(cmd, f)
104 for _, tc := range testCases {
105 t.Run(tc.Name, func(t *testing.T) {
106 args, _ := shlex.Split(tc.Issue)
107 cmd.SetArgs(args)
108 cmd.SetOut(io.Discard)
109 cmd.SetErr(io.Discard)
111 _, err := cmd.ExecuteC()
112 if tc.wantErr {
113 require.Error(t, err)
114 return
115 } else {
116 require.NoError(t, err)
117 }
119 out := stripansi.Strip(stdout.String())
120 outErr := stripansi.Strip(stderr.String())
122 for _, msg := range tc.ExpectedMsg {
123 assert.Contains(t, out, msg)
124 assert.Contains(t, outErr, "")
125 }
126 })
127 }
129 api.UpdateIssue = oldUpdateIssue
130}
Diagnostics8 git calls · 323 ms
CallStatusSizeTime0323 ms
discover200185 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit10 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=10 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=8 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit8 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=8 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchtree:02001.8 KiB · hit8 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=8 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=8 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200492 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=492 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=409e7038e253494f94691a22a250deee77ba03bf git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=492 git.pkt.payload.max=465 git.sideband.band1.bytes=465 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=465 git.pack.trailer=c8a67aa26d573734cf0c8f302f8c1dd08e47d76aOpen pack map
fetchtree:0200211 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=211 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=223946acadcafdcc7d72618ed1be1c04a332ea22 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=211 git.pkt.payload.max=184 git.sideband.band1.bytes=184 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=184 git.pack.trailer=4892bf72a4513d7bc02bb1fb3a31f2c4f0883c30Open pack map
fetch2001.4 KiB298 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=298 git.response.bytes=1426 git.response.cache=MISS git.response.duration_ms=298 git.fetch.wants=fc0f3838d86e80807b74d5a19f8777f48041e075 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1426 git.pkt.payload.max=1399 git.sideband.band1.bytes=1399 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e29654a8172407
- Request
- 6d76a030…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format