GitLabgitlab-org

cli

main
ply8 git calls258 ms99 KiB6 cachedprotocol v2
132 lines4.6 KiBRaw
1//go:build !integration
3package create
5import (
6 "os"
7 "path/filepath"
8 "testing"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
12 "go.uber.org/mock/gomock"
14 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
15 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
17 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
20func writeAttachFixture(t *testing.T, name string) string {
21 t.Helper()
23 path := filepath.Join(t.TempDir(), name)
24 require.NoError(t, os.WriteFile(path, []byte("\x89PNG\r\n\x1a\nfake png body"), 0o600))
25 return path
28func expectProjectForAttach(testClient *gitlabtesting.TestClient) {
29 testClient.MockProjects.EXPECT().
30 GetProject("OWNER/REPO", gomock.Any()).
31 Return(&gitlab.Project{
32 ID: 37777023,
33 PathWithNamespace: "OWNER/REPO",
34 IssuesEnabled: true,
35 }, nil, nil)
38func TestIssueCreate_AttachAppendsReferenceToDescription(t *testing.T) {
39 path := writeAttachFixture(t, "screenshot.png")
41 testClient := gitlabtesting.NewTestClient(t)
42 expectProjectForAttach(testClient)
43 testClient.MockProjectMarkdownUploads.EXPECT().
44 UploadProjectMarkdown("OWNER/REPO", gomock.Any(), "screenshot.png", gomock.Any()).
45 Return(&gitlab.ProjectMarkdownUploadedFile{Markdown: "![screenshot](/uploads/abc/screenshot.png)"}, nil, nil)
47 var gotDescription *string
48 testClient.MockIssues.EXPECT().
49 CreateIssue("OWNER/REPO", gomock.Any()).
50 DoAndReturn(func(_ any, opts *gitlab.CreateIssueOptions, _ ...gitlab.RequestOptionFunc) (*gitlab.Issue, *gitlab.Response, error) {
51 gotDescription = opts.Description
52 return &gitlab.Issue{IID: 1, WebURL: "https://gitlab.com/OWNER/REPO/-/issues/1"}, nil, nil
53 })
55 exec := cmdtest.SetupCmdForTest(t, NewCmdCreate, false, cmdtest.WithGitLabClient(testClient.Client))
57 _, err := exec(`--title "Login button misaligned" --description "See below." --attach ` + path + ` --yes`)
58 require.NoError(t, err)
60 require.NotNil(t, gotDescription)
61 assert.Equal(t, "See below.\n\n![screenshot](/uploads/abc/screenshot.png)", *gotDescription)
64func TestIssueCreate_AttachSatisfiesNonInteractiveMode(t *testing.T) {
65 path := writeAttachFixture(t, "screenshot.png")
67 testClient := gitlabtesting.NewTestClient(t)
68 expectProjectForAttach(testClient)
69 testClient.MockProjectMarkdownUploads.EXPECT().
70 UploadProjectMarkdown("OWNER/REPO", gomock.Any(), "screenshot.png", gomock.Any()).
71 Return(&gitlab.ProjectMarkdownUploadedFile{Markdown: "![screenshot](/uploads/abc/screenshot.png)"}, nil, nil)
73 var gotDescription *string
74 testClient.MockIssues.EXPECT().
75 CreateIssue("OWNER/REPO", gomock.Any()).
76 DoAndReturn(func(_ any, opts *gitlab.CreateIssueOptions, _ ...gitlab.RequestOptionFunc) (*gitlab.Issue, *gitlab.Response, error) {
77 gotDescription = opts.Description
78 return &gitlab.Issue{IID: 1, WebURL: "https://gitlab.com/OWNER/REPO/-/issues/1"}, nil, nil
79 })
81 exec := cmdtest.SetupCmdForTest(t, NewCmdCreate, false, cmdtest.WithGitLabClient(testClient.Client))
83 _, err := exec(`--title "Login button misaligned" --attach ` + path)
84 require.NoError(t, err)
86 require.NotNil(t, gotDescription)
87 assert.Equal(t, "![screenshot](/uploads/abc/screenshot.png)", *gotDescription)
90func TestIssueCreate_NonInteractiveErrorMentionsAttach(t *testing.T) {
91 exec := cmdtest.SetupCmdForTest(t, NewCmdCreate, false)
93 _, err := exec(`--title "no body anywhere"`)
94 require.Error(t, err)
95 assert.Contains(t, err.Error(), "--attach")
98func TestIssueCreate_NoAttachLeavesTheDescriptionAlone(t *testing.T) {
99 testClient := gitlabtesting.NewTestClient(t)
100 expectProjectForAttach(testClient)
102 var gotDescription *string
103 testClient.MockIssues.EXPECT().
104 CreateIssue("OWNER/REPO", gomock.Any()).
105 DoAndReturn(func(_ any, opts *gitlab.CreateIssueOptions, _ ...gitlab.RequestOptionFunc) (*gitlab.Issue, *gitlab.Response, error) {
106 gotDescription = opts.Description
107 return &gitlab.Issue{IID: 1, WebURL: "https://gitlab.com/OWNER/REPO/-/issues/1"}, nil, nil
108 })
110 exec := cmdtest.SetupCmdForTest(t, NewCmdCreate, false, cmdtest.WithGitLabClient(testClient.Client))
112 _, err := exec(`--title "Login button misaligned" --description "See below." --yes`)
113 require.NoError(t, err)
115 require.NotNil(t, gotDescription)
116 assert.Equal(t, "See below.", *gotDescription)
119func TestGenerateIssueWebURL_IncludesAttachmentReferences(t *testing.T) {
120 opts := &options{
121 body: "See below.\n\n![screenshot](/uploads/abc/screenshot.png)",
122 Title: "Login button misaligned",
123 baseProject: &gitlab.Project{
124 ID: 101,
125 WebURL: "https://gitlab.example.com/gitlab-org/gitlab",
126 },
127 }
129 u, err := generateIssueWebURL(opts)
130 require.NoError(t, err)
131 assert.Contains(t, u, "%21%5Bscreenshot%5D%28%2Fuploads%2Fabc%2Fscreenshot.png%29")
Diagnostics8 git calls · 258 ms
CallStatusSizeTime0258 ms
discover200185 B2 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=HIT
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200492 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=492
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=409e7038e253494f94691a22a250deee77ba03bf
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=492
git.pkt.payload.max=465
git.sideband.band1.bytes=465
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=465
git.pack.trailer=c8a67aa26d573734cf0c8f302f8c1dd08e47d76a
Open pack map
fetchtree:0200241 B · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=241
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=65456ca49a78f4c6f0b98ffad089d9ea28940f53
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=241
git.pkt.payload.max=214
git.sideband.band1.bytes=214
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=214
git.pack.trailer=3c6055d4ff8dc803acc935ee10d6f6301f2e5c6b
Open pack map
fetch2001.2 KiB241 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=241
git.response.bytes=1267
git.response.cache=MISS
git.response.duration_ms=241
git.fetch.wants=b3105b64c7a221f9f8421c76782a5b1a28ecc99d
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1267
git.pkt.payload.max=1240
git.sideband.band1.bytes=1240
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e289dd580fbd4a
Request
4493b89a…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format