GitLabgitlab-org
cli
main
1//go:build !integration
3package add
5import (
6 "errors"
7 "testing"
8 "time"
10 "github.com/stretchr/testify/assert"
11 "github.com/stretchr/testify/require"
12 "go.uber.org/mock/gomock"
14 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
15 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
17 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
18)
20func Test_AddGPGKey(t *testing.T) {
21 type testCase struct {
22 Name string
23 ExpectedMsg []string
24 wantErr bool
25 cli string
26 stdin string
27 wantStderr string
28 setupMock func(tc *gitlabtesting.TestClient)
29 }
31 validGPGKey := &gitlab.GPGKey{
32 ID: 1,
33 Key: "-----BEGIN PGP PUBLIC KEY BLOCK-----\n\nmQENBFnZ...\n-----END PGP PUBLIC KEY BLOCK-----",
34 CreatedAt: new(time.Time{}),
35 }
37 testCases := []testCase{
38 // Success cases
39 {
40 Name: "Add GPG key from file",
41 ExpectedMsg: []string{"New GPG key added to your account."},
42 cli: "testdata/testkey.gpg",
43 setupMock: func(tc *gitlabtesting.TestClient) {
44 tc.MockUsers.EXPECT().AddGPGKey(gomock.Any()).Return(validGPGKey, nil, nil)
45 },
46 },
47 {
48 Name: "Add GPG key from stdin",
49 ExpectedMsg: []string{"New GPG key added to your account."},
50 cli: "",
51 stdin: "-----BEGIN PGP PUBLIC KEY BLOCK-----\n\nmQENBFnZ...\n-----END PGP PUBLIC KEY BLOCK-----",
52 setupMock: func(tc *gitlabtesting.TestClient) {
53 tc.MockUsers.EXPECT().AddGPGKey(gomock.Any()).Return(validGPGKey, nil, nil)
54 },
55 },
57 // File errors
58 {
59 Name: "Add GPG key with missing file",
60 cli: "nonexistent.gpg",
61 wantErr: true,
62 wantStderr: "nonexistent.gpg",
63 setupMock: func(tc *gitlabtesting.TestClient) {},
64 },
66 // API errors
67 {
68 Name: "Add GPG key with invalid key format",
69 cli: "testdata/testkey.gpg",
70 wantErr: true,
71 wantStderr: "Key is invalid",
72 setupMock: func(tc *gitlabtesting.TestClient) {
73 tc.MockUsers.EXPECT().AddGPGKey(gomock.Any()).Return(nil, nil, errors.New("Key is invalid"))
74 },
75 },
76 {
77 Name: "Add GPG key with duplicate key error",
78 cli: "testdata/testkey.gpg",
79 wantErr: true,
80 wantStderr: "Key has already been taken",
81 setupMock: func(tc *gitlabtesting.TestClient) {
82 tc.MockUsers.EXPECT().AddGPGKey(gomock.Any()).Return(nil, nil, errors.New("Key has already been taken"))
83 },
84 },
85 {
86 Name: "Add GPG key with unauthorized error",
87 cli: "testdata/testkey.gpg",
88 wantErr: true,
89 wantStderr: "401",
90 setupMock: func(tc *gitlabtesting.TestClient) {
91 tc.MockUsers.EXPECT().AddGPGKey(gomock.Any()).Return(nil, nil, errors.New("401 Unauthorized"))
92 },
93 },
94 {
95 Name: "Add GPG key with server error",
96 cli: "testdata/testkey.gpg",
97 wantErr: true,
98 wantStderr: "",
99 setupMock: func(tc *gitlabtesting.TestClient) {
100 tc.MockUsers.EXPECT().AddGPGKey(gomock.Any()).Return(nil, nil, errors.New("500 Internal Server Error"))
101 },
102 },
103 }
105 for _, tc := range testCases {
106 t.Run(tc.Name, func(t *testing.T) {
107 // GIVEN
108 testClient := gitlabtesting.NewTestClient(t)
109 tc.setupMock(testClient)
111 exec := cmdtest.SetupCmdForTest(t, NewCmdAdd, false,
112 cmdtest.WithStdin(tc.stdin),
113 cmdtest.WithGitLabClient(testClient.Client),
114 )
115 out, err := exec(tc.cli)
117 // THEN
118 if tc.wantErr {
119 require.Error(t, err)
120 assert.Contains(t, err.Error(), tc.wantStderr)
121 return
122 }
123 require.NoError(t, err)
124 for _, msg := range tc.ExpectedMsg {
125 assert.Contains(t, out.String(), msg)
126 }
127 })
128 }
129}
Diagnostics8 git calls · 219 ms
CallStatusSizeTime0219 ms
discover200185 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=185 git.server.agent=git/2.56.g1891de4-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=185 git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=59849 git.response.cache=HIT git.response.duration_ms=3 git.protocol.version=2 git.pkt.frames=731 git.pkt.data=730 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=59849 git.pkt.payload.max=143 git.ls_refs.count=730 git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=4273 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=combine:blob:none+tree:2 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=1 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4273 git.pkt.payload.max=4173 git.sideband.band1.bytes=4173 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=11 git.pack.bytes=4173 git.fetch.wide.objects=11 git.fetch.wide.extra_bytes=3930 git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=32926 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=22 git.pkt.data=20 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=32926 git.pkt.payload.max=32046 git.sideband.band1.bytes=32046 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=80 git.pack.bytes=32046 git.pack.ofs_delta=36 git.pack.ref_delta=0 git.pack.chain.max=2 git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91 git.pack.full=44Open pack map
fetchtree:02001.8 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=1857 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1857 git.pkt.payload.max=1830 git.sideband.band1.bytes=1830 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=1830 git.pack.trailer=fb03183b7909876778f740d196d7516811003517Open pack map
fetchtree:0200255 B · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=255 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=15af11a37aea07f02434cde734621d1e45404665 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=255 git.pkt.payload.max=228 git.sideband.band1.bytes=228 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=228 git.pack.trailer=6ff48c6a71457a5b44469aff62a04a7bff71d303Open pack map
fetchtree:0200167 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=167 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=4cced7f6bc34157bab0852d4bdfba2f29c1a17b1 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=167 git.pkt.payload.max=140 git.sideband.band1.bytes=140 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=140 git.pack.trailer=b5defb35ceaf22ea68ce8c3c551249182043a49bOpen pack map
fetch2001.1 KiB207 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=207 git.response.bytes=1095 git.response.cache=MISS git.response.duration_ms=207 git.fetch.wants=bc8b84b3fa101ec8a6218869d879e4979de25edb git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1095 git.pkt.payload.max=1068 git.sideband.band1.bytes=1068 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://gitlab.com/gitlab-org/cli
- Ref
- refs/heads/main
- Commit
- 0dd7574dce9e385c5c30540e6c15657adc6bdce9
- cf-ray
- a5e2f2b609ab7089
- Request
- 82c5e686…
- Protocol
- v2 · sha1
- Agent
- git/2.56.g1891de4-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format