GitLabgitlab-org

cli

main
ply9 git calls289 ms99 KiB6 cachedprotocol v2
114 lines3.9 KiBRaw
1//go:build !integration
3package serve
5import (
6 "errors"
7 "os"
8 "path/filepath"
9 "testing"
10 "time"
12 "github.com/MakeNowJust/heredoc/v2"
13 "github.com/stretchr/testify/assert"
14 "github.com/stretchr/testify/require"
15 "go.uber.org/mock/gomock"
17 "gitlab.com/gitlab-org/cli/internal/cmdutils"
18 "gitlab.com/gitlab-org/cli/internal/config"
19 "gitlab.com/gitlab-org/cli/internal/dependencyfirewall/session"
20 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
23func TestServeRequiresStateDir(t *testing.T) {
24 t.Parallel()
25 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
26 _, err := exec("")
27 assert.ErrorContains(t, err, `required flag(s) "state-dir" not set`)
30// Not parallel: it sets CI_PROJECT_DIR.
31func TestServeAnchorsTheCILogToTheProjectDir(t *testing.T) {
32 t.Setenv("CI_PROJECT_DIR", "/builds/group/project")
33 o := &options{}
34 require.NoError(t, o.complete())
35 assert.Equal(t, "/builds/group/project", o.baseDir)
38// Not parallel: it clears CI_PROJECT_DIR and changes the working directory.
39func TestServeAnchorsTheCILogToTheWorkingDirOutsideCI(t *testing.T) {
40 t.Setenv("CI_PROJECT_DIR", "")
41 dir := t.TempDir()
42 t.Chdir(dir)
43 o := &options{}
44 require.NoError(t, o.complete())
45 assert.Equal(t, dir, o.baseDir)
48// Not parallel: it clears CI_PROJECT_DIR and GITLAB_CI and changes the working
49// directory. Without the client_cert wiring the proxy starts and serve blocks
50// until it is signalled, so the timeout turns that into a failure.
51func TestServeFailsWhenClientCertForRepoHostCannotBeLoaded(t *testing.T) {
52 t.Setenv("CI_PROJECT_DIR", "")
53 t.Setenv("GITLAB_CI", "")
54 t.Chdir(t.TempDir())
56 dir := t.TempDir()
57 certPath := filepath.Join(dir, "client.pem")
58 keyPath := filepath.Join(dir, "client-key.pem")
59 require.NoError(t, os.WriteFile(certPath, []byte("not a certificate"), 0o600))
60 require.NoError(t, os.WriteFile(keyPath, []byte("not a key"), 0o600))
61 cfg := config.NewFromString(heredoc.Docf(`
62 hosts:
63 gitlab.example.com:
64 client_cert: %s
65 client_key: %s
66 `, certPath, keyPath))
67 stateDir := t.TempDir()
68 exec := cmdtest.SetupCmdForTest(t, NewCmd, false,
69 cmdtest.WithConfig(cfg),
70 cmdtest.WithBaseRepo("g", "p", "gitlab.example.com"),
71 )
73 done := make(chan error, 1)
74 go func() {
75 _, err := exec("--state-dir " + stateDir)
76 done <- err
77 }()
78 select {
79 case err := <-done:
80 require.ErrorContains(t, err, "failed to load client certificate")
81 case <-time.After(10 * time.Second):
82 t.Fatal("the job-level proxy started without the outbound proxy client certificate")
83 }
84 assert.NoFileExists(t, filepath.Join(stateDir, session.AddrFile), "the job-level proxy must not report ready")
87// Not parallel: it clears CI_PROJECT_DIR and changes the working directory.
88func TestServeBaseRepoErrorWithoutGitSaysGitIsRequired(t *testing.T) {
89 t.Setenv("CI_PROJECT_DIR", "")
90 t.Chdir(t.TempDir())
91 executor := cmdtest.NewMockExecutor(gomock.NewController(t))
92 executor.EXPECT().LookPath("git").Return("", errors.New("not found"))
93 exec := cmdtest.SetupCmdForTest(t, NewCmd, false,
94 cmdtest.WithExecutor(executor),
95 cmdtest.WithBaseRepoError(errors.New("no GitLab remote found")))
96 _, err := exec("--state-dir " + t.TempDir())
97 var xerr *cmdutils.ExitError
98 require.ErrorAs(t, err, &xerr)
99 assert.Contains(t, xerr.Details, "failed to resolve GitLab project")
100 assert.EqualError(t, err, "no GitLab remote found. git is required")
103// Not parallel: it clears CI_PROJECT_DIR and changes the working directory.
104func TestServeBaseRepoErrorWithGitInstalledHasNoGitHint(t *testing.T) {
105 t.Setenv("CI_PROJECT_DIR", "")
106 t.Chdir(t.TempDir())
107 executor := cmdtest.NewMockExecutor(gomock.NewController(t))
108 executor.EXPECT().LookPath("git").Return("/usr/bin/git", nil)
109 exec := cmdtest.SetupCmdForTest(t, NewCmd, false,
110 cmdtest.WithExecutor(executor),
111 cmdtest.WithBaseRepoError(errors.New("no GitLab remote found")))
112 _, err := exec("--state-dir " + t.TempDir())
113 assert.EqualError(t, err, "no GitLab remote found")
Diagnostics9 git calls · 289 ms
CallStatusSizeTime0289 ms
discover200185 B2 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=UPDATING
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:02001.8 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200650 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=650
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=cdbc4acb219224e81172d025f80739e1e383a784
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=650
git.pkt.payload.max=623
git.sideband.band1.bytes=623
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=623
git.pack.trailer=aabedefb11d4348efc4e1168413c6ec52cbf90d2
Open pack map
fetchtree:0200195 B · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=195
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=b26ad1838d5161708f3c9df74fdaebb3c5546fcb
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=195
git.pkt.payload.max=168
git.sideband.band1.bytes=168
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=168
git.pack.trailer=405c9835aff5fd29fec3c746d859efdbbac4687f
Open pack map
fetchtree:0200137 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=137
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=4ac2f63570b62c850ee344befd13b2653babfccb
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=137
git.pkt.payload.max=110
git.sideband.band1.bytes=110
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=110
git.pack.trailer=1a0f9c9df614f6bb246997c685dfceb7bffc7937
Open pack map
fetch2001.4 KiB272 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=272
git.response.bytes=1385
git.response.cache=MISS
git.response.duration_ms=272
git.fetch.wants=7fb925b6a6e4af45c78ce3ebde7fa817e1625617
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1385
git.pkt.payload.max=1358
git.sideband.band1.bytes=1358
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e307c0dd5415db
Request
f15c713a…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format