GitLabgitlab-org

cli

main
ply9 git calls40 ms99 KiB8 cachedprotocol v2
314 lines9.2 KiBRaw
1//go:build !integration
3package list
5import (
6 "fmt"
7 "testing"
9 "github.com/stretchr/testify/assert"
10 "github.com/stretchr/testify/require"
11 "go.uber.org/mock/gomock"
13 gitlab "gitlab.com/gitlab-org/api/client-go/v3"
14 gitlabtesting "gitlab.com/gitlab-org/api/client-go/v3/testing"
16 "gitlab.com/gitlab-org/cli/internal/cmdutils"
17 "gitlab.com/gitlab-org/cli/internal/testing/cmdtest"
20func Test_RepositoryList_Project(t *testing.T) {
21 t.Parallel()
23 testClient := gitlabtesting.NewTestClient(t)
24 testClient.MockContainerRegistry.EXPECT().
25 ListProjectRegistryRepositories("OWNER/REPO", gomock.Any()).
26 DoAndReturn(func(pid any, opt *gitlab.ListProjectRegistryRepositoriesOptions, options ...gitlab.RequestOptionFunc) ([]*gitlab.RegistryRepository, *gitlab.Response, error) {
27 assert.Equal(t, int64(2), opt.Page)
28 assert.Equal(t, int64(50), opt.PerPage)
29 assert.True(t, *opt.Tags)
30 assert.True(t, *opt.TagsCount)
32 return []*gitlab.RegistryRepository{
33 {
34 ID: 101,
35 Name: "app",
36 Path: "OWNER/REPO/app",
37 TagsCount: 2,
38 },
39 }, nil, nil
40 })
42 exec := cmdtest.SetupCmdForTest(
43 t,
44 NewCmd,
45 false,
46 cmdtest.WithGitLabClient(testClient.Client),
47 )
49 out, err := exec("--page 2 --per-page 50 --include-tags")
50 require.NoError(t, err)
51 assert.Contains(t, out.String(), "Showing 1 container registry repository on OWNER/REPO. (Page 2)")
52 assert.Contains(t, out.String(), "OWNER/REPO/app")
53 assert.NotContains(t, out.String(), "Status")
54 assert.Empty(t, out.Stderr())
57func Test_RepositoryList_ProjectCanSkipTagsCount(t *testing.T) {
58 t.Parallel()
60 testClient := gitlabtesting.NewTestClient(t)
61 testClient.MockContainerRegistry.EXPECT().
62 ListProjectRegistryRepositories("OWNER/REPO", gomock.Any()).
63 DoAndReturn(func(pid any, opt *gitlab.ListProjectRegistryRepositoriesOptions, options ...gitlab.RequestOptionFunc) ([]*gitlab.RegistryRepository, *gitlab.Response, error) {
64 assert.Nil(t, opt.TagsCount)
66 return []*gitlab.RegistryRepository{{ID: 101, Path: "OWNER/REPO/app"}}, nil, nil
67 })
69 exec := cmdtest.SetupCmdForTest(
70 t,
71 NewCmd,
72 false,
73 cmdtest.WithGitLabClient(testClient.Client),
74 )
76 out, err := exec("--include-tags-count=false")
77 require.NoError(t, err)
78 assert.Contains(t, out.String(), "OWNER/REPO/app")
79 assert.Empty(t, out.Stderr())
82func Test_RepositoryList_GroupJSON(t *testing.T) {
83 t.Parallel()
85 testClient := gitlabtesting.NewTestClient(t)
86 testClient.MockContainerRegistry.EXPECT().
87 ListGroupRegistryRepositories("gitlab-org", gomock.Any()).
88 Return([]*gitlab.RegistryRepository{{ID: 102, Path: "gitlab-org/cli"}}, nil, nil)
90 exec := cmdtest.SetupCmdForTest(
91 t,
92 NewCmd,
93 false,
94 cmdtest.WithGitLabClient(testClient.Client),
95 )
97 out, err := exec("--group gitlab-org --output json")
98 require.NoError(t, err)
99 assert.Contains(t, out.String(), `"id":102`)
100 assert.Contains(t, out.String(), `"path":"gitlab-org/cli"`)
101 assert.NotContains(t, out.String(), `"tags":null`)
102 assert.NotContains(t, out.String(), `"tags_count"`)
103 assert.Empty(t, out.Stderr())
106func Test_RepositoryList_GroupOmitsTagsCount(t *testing.T) {
107 t.Parallel()
109 testClient := gitlabtesting.NewTestClient(t)
110 testClient.MockContainerRegistry.EXPECT().
111 ListGroupRegistryRepositories("gitlab-org", gomock.Any()).
112 Return([]*gitlab.RegistryRepository{
113 {
114 ID: 102,
115 Path: "gitlab-org/cli",
116 },
117 }, nil, nil)
119 exec := cmdtest.SetupCmdForTest(
120 t,
121 NewCmd,
122 false,
123 cmdtest.WithGitLabClient(testClient.Client),
124 )
126 out, err := exec("--group gitlab-org")
127 require.NoError(t, err)
128 assert.Contains(t, out.String(), "gitlab-org/cli")
129 assert.NotContains(t, out.String(), "Tags")
130 assert.NotContains(t, out.String(), "\t0\t")
131 assert.Empty(t, out.Stderr())
134func Test_RepositoryList_JSONIncludesTagsWhenPresent(t *testing.T) {
135 t.Parallel()
137 testClient := gitlabtesting.NewTestClient(t)
138 testClient.MockContainerRegistry.EXPECT().
139 ListProjectRegistryRepositories("OWNER/REPO", gomock.Any()).
140 DoAndReturn(func(pid any, opt *gitlab.ListProjectRegistryRepositoriesOptions, options ...gitlab.RequestOptionFunc) ([]*gitlab.RegistryRepository, *gitlab.Response, error) {
141 assert.True(t, *opt.Tags)
143 return []*gitlab.RegistryRepository{
144 {
145 ID: 101,
146 Path: "OWNER/REPO/app",
147 Tags: []*gitlab.RegistryRepositoryTag{
148 {
149 Name: "latest",
150 Path: "OWNER/REPO/app:latest",
151 Location: "registry.gitlab.example.com/OWNER/REPO/app:latest",
152 },
153 },
154 },
155 }, nil, nil
156 })
158 exec := cmdtest.SetupCmdForTest(
159 t,
160 NewCmd,
161 false,
162 cmdtest.WithGitLabClient(testClient.Client),
163 )
165 out, err := exec("--include-tags --output json")
166 require.NoError(t, err)
167 assert.Contains(t, out.String(), `"tags":[{"name":"latest"`)
168 assert.Contains(t, out.String(), `"location":"registry.gitlab.example.com/OWNER/REPO/app:latest"`)
169 assert.NotContains(t, out.String(), `"revision":""`)
170 assert.NotContains(t, out.String(), `"short_revision":""`)
171 assert.NotContains(t, out.String(), `"digest":""`)
172 assert.NotContains(t, out.String(), `"total_size":0`)
173 assert.Empty(t, out.Stderr())
176func Test_RepositoryList_JSONIncludesTagDetailsWhenRequested(t *testing.T) {
177 t.Parallel()
179 testClient := gitlabtesting.NewTestClient(t)
180 testClient.MockContainerRegistry.EXPECT().
181 ListProjectRegistryRepositories("OWNER/REPO", gomock.Any()).
182 DoAndReturn(func(pid any, opt *gitlab.ListProjectRegistryRepositoriesOptions, options ...gitlab.RequestOptionFunc) ([]*gitlab.RegistryRepository, *gitlab.Response, error) {
183 assert.True(t, *opt.Tags)
185 return []*gitlab.RegistryRepository{
186 {
187 ID: 101,
188 Path: "OWNER/REPO/app",
189 Tags: []*gitlab.RegistryRepositoryTag{
190 {Name: "latest"},
191 },
192 },
193 }, nil, nil
194 })
195 testClient.MockContainerRegistry.EXPECT().
196 GetRegistryRepositoryTagDetail("OWNER/REPO", int64(101), "latest").
197 Return(&gitlab.RegistryRepositoryTag{
198 Name: "latest",
199 Path: "OWNER/REPO/app:latest",
200 Location: "registry.gitlab.example.com/OWNER/REPO/app:latest",
201 Revision: "abc123",
202 ShortRevision: "abc",
203 Digest: "sha256:abc",
204 TotalSize: 1024,
205 }, nil, nil)
207 exec := cmdtest.SetupCmdForTest(
208 t,
209 NewCmd,
210 false,
211 cmdtest.WithGitLabClient(testClient.Client),
212 )
214 out, err := exec("--include-tag-details --output json")
215 require.NoError(t, err)
216 assert.Contains(t, out.String(), `"revision":"abc123"`)
217 assert.Contains(t, out.String(), `"short_revision":"abc"`)
218 assert.Contains(t, out.String(), `"digest":"sha256:abc"`)
219 assert.Contains(t, out.String(), `"total_size":1024`)
220 assert.Empty(t, out.Stderr())
223func Test_RepositoryList_TagDetailsAPIError(t *testing.T) {
224 t.Parallel()
226 testClient := gitlabtesting.NewTestClient(t)
227 testClient.MockContainerRegistry.EXPECT().
228 ListProjectRegistryRepositories("OWNER/REPO", gomock.Any()).
229 Return([]*gitlab.RegistryRepository{
230 {
231 ID: 101,
232 Tags: []*gitlab.RegistryRepositoryTag{{Name: "latest"}},
233 },
234 }, nil, nil)
235 testClient.MockContainerRegistry.EXPECT().
236 GetRegistryRepositoryTagDetail("OWNER/REPO", int64(101), "latest").
237 Return(nil, nil, fmt.Errorf("api failed"))
239 exec := cmdtest.SetupCmdForTest(
240 t,
241 NewCmd,
242 false,
243 cmdtest.WithGitLabClient(testClient.Client),
244 )
246 _, err := exec("--include-tag-details --output json")
247 require.Error(t, err)
248 assert.Equal(t, "api failed", err.Error())
251func Test_RepositoryList_TagDetailsRejectsGroup(t *testing.T) {
252 t.Parallel()
254 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
256 _, err := exec("--group gitlab-org --include-tag-details --output json")
257 require.Error(t, err)
258 assert.Equal(t, "--include-tag-details is only available for project repositories", err.Error())
261func Test_RepositoryList_TagDetailsRequiresJSONOutput(t *testing.T) {
262 t.Parallel()
264 exec := cmdtest.SetupCmdForTest(t, NewCmd, false)
266 _, err := exec("--include-tag-details")
267 require.Error(t, err)
268 assert.Equal(t, "--include-tag-details requires --output json", err.Error())
271func Test_RepositoryList_EmptyResults(t *testing.T) {
272 t.Parallel()
274 testClient := gitlabtesting.NewTestClient(t)
275 testClient.MockContainerRegistry.EXPECT().
276 ListProjectRegistryRepositories("OWNER/REPO", gomock.Any()).
277 Return([]*gitlab.RegistryRepository{}, nil, nil)
279 exec := cmdtest.SetupCmdForTest(
280 t,
281 NewCmd,
282 false,
283 cmdtest.WithGitLabClient(testClient.Client),
284 )
286 out, err := exec("")
287 require.NoError(t, err)
288 assert.Contains(t, out.String(), "No container registry repositories available on OWNER/REPO.")
289 assert.NotContains(t, out.String(), "ID\tName\tPath")
290 assert.Empty(t, out.Stderr())
293func Test_RepositoryList_APIError(t *testing.T) {
294 t.Parallel()
296 testClient := gitlabtesting.NewTestClient(t)
297 testClient.MockContainerRegistry.EXPECT().
298 ListProjectRegistryRepositories("OWNER/REPO", gomock.Any()).
299 Return(nil, nil, fmt.Errorf("api failed"))
301 exec := cmdtest.SetupCmdForTest(
302 t,
303 NewCmd,
304 false,
305 cmdtest.WithGitLabClient(testClient.Client),
306 )
308 _, err := exec("")
309 require.Error(t, err)
310 assert.Equal(t, "api failed", err.Error())
311 var exitErr *cmdutils.ExitError
312 require.ErrorAs(t, err, &exitErr)
313 assert.Equal(t, "failed to list container registry repositories from OWNER/REPO; ensure OWNER/REPO exists and has container registry enabled, or specify the owning project with -R <project>.", exitErr.Details)
Diagnostics9 git calls · 40 ms
CallStatusSizeTime040 ms
discover200185 B3 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=3
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=3
git.response.bytes=59849
git.response.cache=HIT
git.response.duration_ms=3
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchtree:02001.8 KiB · hit7 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=7
git.response.bytes=1857
git.response.cache=HIT
git.response.duration_ms=7
git.fetch.filter=tree:0
git.fetch.wants=dce174ff8c632a19d17eea99c8a9b7c37fb2b592
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1857
git.pkt.payload.max=1830
git.sideband.band1.bytes=1830
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1830
git.pack.trailer=fb03183b7909876778f740d196d7516811003517
Open pack map
fetchtree:0200243 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=243
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=a517df7bd3c1e8ee5cd02bc33418664d7dab246f
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=243
git.pkt.payload.max=216
git.sideband.band1.bytes=216
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=216
git.pack.trailer=50fe37a7b0ca9579b3ab7da0b785d0006b143110
Open pack map
fetchtree:0200232 B · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=232
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=30b8a2dae1c295021612c17ef58cff022e6e1e20
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=232
git.pkt.payload.max=205
git.sideband.band1.bytes=205
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=205
git.pack.trailer=ccde92ca11c0d35d0efab2d7a5815798e7ee4f3f
Open pack map
fetchtree:0200135 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=135
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=d8f0a91cbefe0365725132fbe71e21d54dc35611
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=135
git.pkt.payload.max=108
git.sideband.band1.bytes=108
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=108
git.pack.trailer=34cb9131ea495de5116757226fe337233cfecaff
Open pack map
fetch2001.6 KiB · hit19 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=19
git.response.bytes=1600
git.response.cache=HIT
git.response.duration_ms=19
git.fetch.wants=d29b4a5ddbe9a2bba6dcf366c5e96f95d8ac160a
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1600
git.pkt.payload.max=1573
git.sideband.band1.bytes=1573
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e2ecdfdb5377be
Request
ce957c52…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format