GitLabgitlab-org

cli

main
ply6 git calls26 ms97 KiB5 cachedprotocol v2
99 lines2.4 KiBRaw
1//go:build !integration
3package cmdutils
5import (
6 "errors"
7 "io"
8 "strings"
9 "testing"
10 "testing/iotest"
11 "time"
13 "git.sr.ht/~timofurrer/ugh"
14 "github.com/stretchr/testify/assert"
15 "github.com/stretchr/testify/require"
17 "gitlab.com/gitlab-org/cli/internal/config"
18 "gitlab.com/gitlab-org/cli/internal/iostreams"
21func TestNoteBodyFromStdinOrEditor_ReadsStdin(t *testing.T) {
22 t.Parallel()
24 tests := []struct {
25 name string
26 stdin string
27 want string
28 }{
29 {
30 name: "trims surrounding whitespace",
31 stdin: "\n hello\n\n",
32 want: "hello",
33 },
34 {
35 name: "keeps inner blank lines and indentation",
36 stdin: "line one\n\n line two\n",
37 want: "line one\n\n line two",
38 },
39 {
40 name: "empty stdin returns an empty body",
41 stdin: "",
42 want: "",
43 },
44 {
45 name: "whitespace-only stdin returns an empty body",
46 stdin: " \n\t\n",
47 want: "",
48 },
49 }
51 for _, tc := range tests {
52 t.Run(tc.name, func(t *testing.T) {
53 t.Parallel()
55 ios := testIOStreamsWithStdin(tc.stdin)
56 cfg := func() config.Config { return config.NewFromString("editor: vi") }
58 note, err := NoteBodyFromStdinOrEditor(t.Context(), ios, cfg, "title", "help text")
59 require.NoError(t, err)
60 assert.Equal(t, tc.want, note)
61 })
62 }
65func TestNoteBodyFromStdinOrEditor_WrapsReadError(t *testing.T) {
66 t.Parallel()
68 readErr := errors.New("some read error")
70 ios := iostreams.New(
71 iostreams.WithStdin(io.NopCloser(iotest.ErrReader(readErr)), false),
72 iostreams.WithStdout(&strings.Builder{}, false),
73 iostreams.WithStderr(&strings.Builder{}, false),
74 )
75 cfg := func() config.Config { return config.NewFromString("editor: vi") }
77 body, err := NoteBodyFromStdinOrEditor(t.Context(), ios, cfg, "title", "help text")
79 require.Error(t, err)
80 require.ErrorIs(t, err, readErr)
81 assert.Contains(t, err.Error(), "failed to read from stdin")
82 assert.Empty(t, body)
85func TestNoteBodyFromStdinOrEditor_PromptsWithTitle(t *testing.T) {
86 // Not parallel: huh text inputs share global state.
88 u := ugh.New(t, ugh.WithTimeout(2*time.Second))
89 u.Expect(ugh.Input("Probe title:")).Do(ugh.Type("typed body"))
91 ios, cancel := testIOStreamsWithConsole(t, u)
92 defer cancel()
93 cfg := func() config.Config { return config.NewFromString("editor: vi") }
95 body, err := NoteBodyFromStdinOrEditor(t.Context(), ios, cfg, "Probe title:", "help text")
97 require.NoError(t, err)
98 assert.Equal(t, "typed body", body)
Diagnostics6 git calls · 26 ms
CallStatusSizeTime026 ms
discover200185 B3 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB · hit2 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=59849
git.response.cache=HIT
git.response.duration_ms=2
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchtree:02001.2 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=19
git.response.bytes=1238
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=c10f4b8b760c3fec7ed8ca85e428d5bc523f8e17
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1238
git.pkt.payload.max=1211
git.sideband.band1.bytes=1211
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=1211
git.pack.trailer=7373aa350f2a611db7d4116eb1450c92f18a27ca
Open pack map
fetch200962 B · hit19 ms
git.upload-pack fetch
http.response.status_code=200
git.response.bytes=962
git.response.cache=HIT
git.response.duration_ms=19
git.fetch.wants=d2e041df5236947d5ee082de9df6ba456a12a3ea
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=962
git.pkt.payload.max=935
git.sideband.band1.bytes=935
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e1c50638d7227c
Request
00b5a06b…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format