GitLabgitlab-org

cli

main
ply6 git calls61 ms96 KiB5 cachedprotocol v2
37 lines3.1 KiBRaw

Follow the reviewer and maintainer guide. Stop after the reviewer steps if you only want to review.

Become a reviewer

Become a maintainer

The CLI follows the handbook's accelerated maintainer onboarding for smaller projects. Apply when you feel confident in the codebase, for example after you've authored and reviewed a few merge requests. If you have strong Go experience, you may need fewer.

Remember that even when you are a maintainer, you can still request help from other maintainers if you come across an MR that you feel is too complex or requires a second opinion.

If you need assistance with any of the following steps, ask in the #f_cli Slack channel.

  • Create a merge request changing your team member entry to cli: maintainer (example), link this issue, assign it to your manager, and ask a CLI maintainer to approve.
  • Ask an Owner of the gitlab-cli-maintainers group to add you with the Maintainer role.
  • Request the access you need:
    • "GitLab CLI Vault" 1Password vault: contacts for community package maintainers
    • "GitLab.com Service - Platform Engineering - Code Review - gl" 1Password vault: service account for automated releases
    • gitlab-cli@gitlab.com email group: contact address for the Homebrew and Snap packages
  • Keep reviewing, start merging :metal:
1<!--
2 Update the title of this issue to: Maintainer Onboarding - [full name]
3-->
5Follow the [reviewer and maintainer guide](https://gitlab.com/gitlab-org/cli/-/blob/main/docs/maintainer.md). Stop after the reviewer
6steps if you only want to review.
8## Become a reviewer
10- [ ] Create a merge request adding `cli: reviewer` under `projects:` to [your team member entry](https://gitlab.com/gitlab-com/www-gitlab-com/-/blob/master/doc/team_database.md) ([example](https://gitlab.com/gitlab-com/www-gitlab-com/-/blob/3284a59d69e2b2ae9bb1fb8bc03b6be2d29aa6cb/data/team_members/person/d/dbickford.yml#L13-14)).
11- [ ] Join the `#f_cli` Slack channel.
12- [ ] Set up your local environment with [`CONTRIBUTING.md`](https://gitlab.com/gitlab-org/cli/-/blob/main/CONTRIBUTING.md).
13- [ ] Read [how to review merge requests](https://gitlab.com/gitlab-org/cli/-/blob/main/docs/maintainer.md#review-merge-requests).
14- [ ] Study the [preferred domain knowledge](https://gitlab.com/gitlab-org/cli/-/blob/main/docs/maintainer.md#preferred-domain-knowledge).
15- [ ] Open a merge request that improves the [documentation](https://gitlab.com/gitlab-org/cli/-/tree/main/docs) or this template, fixes a bug, or adds a small enhancement such as a new flag.
16- [ ] _Optional_: Pair with a current maintainer on a review.
17- [ ] _Optional_: Read the [code review page in the handbook](https://handbook.gitlab.com/handbook/engineering/workflow/code-review/) and the [code review guidelines](https://docs.gitlab.com/development/code_review/).
19## Become a maintainer
21The CLI follows the handbook's
22[accelerated maintainer onboarding for smaller projects](https://handbook.gitlab.com/handbook/engineering/workflow/code-review/#accelerated-maintainer-onboarding-for-smaller-projects).
23Apply when you feel confident in the codebase, for example after you've authored and
24reviewed a few merge requests. If you have strong Go experience, you may need fewer.
26Remember that even when you are a maintainer, you can still request help from other maintainers if you come across an MR
27that you feel is too complex or requires a second opinion.
29If you need assistance with any of the following steps, ask in the `#f_cli` Slack channel.
31- [ ] Create a merge request changing your team member entry to `cli: maintainer` ([example](https://gitlab.com/gitlab-com/www-gitlab-com/-/blob/3284a59d69e2b2ae9bb1fb8bc03b6be2d29aa6cb/data/team_members/person/j/jay_mccure.yml#L20-23)), link this issue, assign it to your manager, and ask a CLI maintainer to approve.
32- [ ] Ask an Owner of the [`gitlab-cli-maintainers`](https://gitlab.com/groups/gitlab-com/ai-engineering/ai-coding/teams/gitlab-cli-maintainers/-/group_members) group to add you with the Maintainer role.
33- [ ] Request the [access you need](https://gitlab.com/gitlab-org/cli/-/blob/main/docs/maintainer.md#access-you-need):
34 - [ ] "GitLab CLI Vault" 1Password vault: contacts for community package maintainers
35 - [ ] "GitLab.com Service - Platform Engineering - Code Review - gl" 1Password vault: service account for automated releases
36 - [ ] `gitlab-cli@gitlab.com` email group: contact address for the Homebrew and Snap packages
37- [ ] Keep reviewing, start merging :metal:
Diagnostics6 git calls · 61 ms
CallStatusSizeTime061 ms
discover200185 B3 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=4
git.response.bytes=185
git.server.agent=git/2.56.g1891de4-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=185
git.pkt.payload.max=35
ls-refs20058 KiB · hit3 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=3
git.response.bytes=59849
git.response.cache=HIT
git.response.duration_ms=3
git.protocol.version=2
git.pkt.frames=731
git.pkt.data=730
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=59849
git.pkt.payload.max=143
git.ls_refs.count=730
git.ls_refs.head=refs/heads/main
fetchcombine:blob:none+tree:2 · deepen 12004.2 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=4273
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=combine:blob:none+tree:2
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=1
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4273
git.pkt.payload.max=4173
git.sideband.band1.bytes=4173
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=11
git.pack.bytes=4173
git.fetch.wide.objects=11
git.fetch.wide.extra_bytes=3930
git.fetch.wide.blobs=0
fetchtree:0 · deepen 1020032 KiB · hit4 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=32926
git.response.cache=HIT
git.response.duration_ms=4
git.fetch.filter=tree:0
git.fetch.wants=0dd7574dce9e385c5c30540e6c15657adc6bdce9
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=22
git.pkt.data=20
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=32926
git.pkt.payload.max=32046
git.sideband.band1.bytes=32046
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=80
git.pack.bytes=32046
git.pack.ofs_delta=36
git.pack.ref_delta=0
git.pack.chain.max=2
git.pack.trailer=cb0bad5d7ffc514895d8b21c4dd470327f90bc91
git.pack.full=44
Open pack map
fetchtree:0200238 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=53
git.response.bytes=238
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=0c943e84e7165d598c2813539f254e7328e2c513
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=238
git.pkt.payload.max=211
git.sideband.band1.bytes=211
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=211
git.pack.trailer=02aa52d02e90d93e048e20297fb5033735e64944
Open pack map
fetch2001.3 KiB · hit53 ms
git.upload-pack fetch
http.response.status_code=200
git.response.bytes=1340
git.response.cache=HIT
git.response.duration_ms=53
git.fetch.wants=433d11e2ac1ff08325bd9268ad2df440a23a0835
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1340
git.pkt.payload.max=1313
git.sideband.band1.bytes=1313
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://gitlab.com/gitlab-org/cli
Ref
refs/heads/main
Commit
0dd7574dce9e385c5c30540e6c15657adc6bdce9
cf-ray
a5e286e9cb984af4
Request
1a2825d9…
Protocol
v2 · sha1
Agent
git/2.56.g1891de4-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format