GitHubivarvong
ply
main
1// Issue #141. pushTree had no total-bytes cap: three 48 MiB blobs reached about 440 MB RSS, and the
2// per-file cap still allowed them (each is under 64 MiB). The sum is refused in validateTreeSpec, before
3// buildTree, as limit_exceeded. One 64 MiB blob stays inside the cap, and git mktree hashes the same tree.
4import { test } from 'vitest';
5import assert from 'node:assert/strict';
6import { spawn } from 'node:child_process';
7import { LIMIT_OBJECT, LIMIT_OBJECT_OVERHEAD, LIMIT_PUSH_BYTES } from '../src/limits.js';
8import { gitBuf, tmpRoot } from './server.js';
10const MIB = 1024 * 1024;
11const THREE = 48 * MIB;
12// Measured with the bytes resident: one 64 MiB blob about 158 MB RSS, the three-blob refusal about 238 MB.
13// The uncapped push of the same three blobs was about 440 MB. Headroom for CI.
14const RSS_BOUND_MB = 320;
16const runChild = kind => new Promise((resolve, reject) => {
17 const child = spawn(process.execPath, [
18 '--max-old-space-size=128', '--import', './test/ts-resolve.mjs',
19 'test/push-budget-child.mjs', kind,
20 ], { stdio: ['ignore', 'pipe', 'pipe'] });
21 const out = [];
22 let err = '';
23 child.stdout.on('data', d => out.push(d));
24 child.stderr.on('data', d => { err += d; });
25 child.on('close', status => {
26 const text = Buffer.concat(out).toString();
27 let parsed = null;
28 try { parsed = JSON.parse(text); } catch { /* OOM prints no JSON */ }
29 resolve({ status, parsed, err, text });
30 });
31 child.on('error', reject);
32});
34test('one 64 MiB blob matches git mktree; three 48 MiB blobs are limit_exceeded under a 128 MiB heap', async () => {
35 const { root, cleanup } = tmpRoot();
36 try {
37 const one = await runChild('one');
38 const three = await runChild('three');
39 assert.equal(one.status, 0, one.err);
40 assert.equal(one.parsed?.status, 'ok', one.text || one.err);
41 assert.ok(one.parsed.rss < RSS_BOUND_MB, `one rss ${one.parsed.rss}`);
42 gitBuf(root, ['init']);
43 const blob = Buffer.alloc(LIMIT_OBJECT, 7);
44 const oid = gitBuf(root, ['hash-object', '-w', '--stdin'], blob).toString().trim();
45 const tree = gitBuf(root, ['mktree'], Buffer.from(`100644 blob ${oid}\tbig.bin\n`)).toString().trim();
46 assert.equal(one.parsed.blob, oid);
47 assert.equal(one.parsed.root, tree);
49 assert.equal(three.status, 0, three.err);
50 assert.equal(three.parsed?.status, 'err', three.text || three.err);
51 assert.equal(three.parsed.code, 'limit_exceeded');
52 assert.equal(three.parsed.what, 'push bytes');
53 // each file charges LIMIT_OBJECT_OVERHEAD beyond its bytes (#142)
54 assert.equal(three.parsed.got, (THREE + LIMIT_OBJECT_OVERHEAD) * 3);
55 assert.equal(three.parsed.max, LIMIT_PUSH_BYTES);
56 assert.ok(THREE * 3 > LIMIT_PUSH_BYTES);
57 assert.ok(three.parsed.rss < RSS_BOUND_MB, `three rss ${three.parsed.rss}`);
58 } finally {
59 cleanup();
60 }
61});
Diagnostics6 git calls · 117 ms
CallStatusSizeTime0117 ms
discover200191 B3 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=3 git.response.bytes=191 git.server.agent=git/github-9922ec520325-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=191 git.pkt.payload.max=36
ls-refs20012 KiB87 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=82 git.response.bytes=11990 git.response.cache=EXPIRED git.response.duration_ms=87 git.protocol.version=2 git.pkt.frames=152 git.pkt.data=151 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=11990 git.pkt.payload.max=122 git.ls_refs.count=151 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 102004.2 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4347 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=19912563f540228593df0c489082e5e2508e21e4 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4347 git.pkt.payload.max=4247 git.sideband.band1.bytes=4247 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=10 git.pack.bytes=4247 git.pack.ofs_delta=0 git.pack.ref_delta=0 git.pack.chain.max=0 git.pack.trailer=a6caf8e129bea82c9bae4cbc7c130c9205add400 git.pack.full=10Open pack map
fetchtree:0200919 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=919 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=800d30ba8923860bfc460ca884b7f9ba22083588 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=919 git.pkt.payload.max=892 git.sideband.band1.bytes=892 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=892 git.pack.trailer=5323b9266eea5ded637285d1c5320699f12be76eOpen pack map
fetchtree:02005.6 KiB · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=5724 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=58fabb6768b3f737ee9cd8bac647bdc27405fb4d git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=5724 git.pkt.payload.max=5697 git.sideband.band1.bytes=5697 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=5697 git.pack.trailer=be7e0453974a5fe832f9065a33bb7e3434c10e9bOpen pack map
fetch2001.3 KiB · hit21 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=21 git.response.bytes=1290 git.response.cache=HIT git.response.duration_ms=21 git.fetch.wants=cd9b716a22553d65e2bdeb116220ff3a0042f976 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1290 git.pkt.payload.max=1263 git.sideband.band1.bytes=1263 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://github.com/ivarvong/ply
- Ref
- refs/heads/main
- Commit
- 19912563f540228593df0c489082e5e2508e21e4
- cf-ray
- a5e2b8a5fdc0cf33
- Request
- 08d7c89b…
- Protocol
- v2 · sha1
- Agent
- git/github-9922ec520325-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format