GitHubivarvong
ply
main
1// A real ERR pkt-line (errors.err-pkt-line): git http-backend's upload-pack answers a fetch of an id it does not hold
2// with `ERR upload-pack: not our ref <id>`. ply reports it as remote_error, reason not_our_ref; the bytes are
3// captured as the server wrote them, so the test also shows the server sent ERR (not only that ply reads injected ones).
4import { test, beforeAll as before, afterAll as after } from 'vitest';
5import assert from 'node:assert/strict';
6import { createHash } from 'node:crypto';
7import { mkdirSync, writeFileSync } from 'node:fs';
8import { join } from 'node:path';
9import { git, tmpRoot, makeBareRepo, startGitServer, initRepo } from './server.js';
10import { createTransport } from '../src/http.js';
11import { fetchPack } from '../src/fetchpack.js';
12import { unwrap } from './unwrap.js';
14let root, cleanup, srv;
15before(async () => {
16 ({ root, cleanup } = tmpRoot());
17 srv = await startGitServer(root);
18 const work = join(root, 'source');
19 mkdirSync(work);
20 initRepo(work);
21 writeFileSync(join(work, 'a.txt'), 'err\n');
22 git(work, ['add', '.']);
23 git(work, ['-c', 'user.name=a', '-c', 'user.email=a@x', 'commit', '-q', '-m', 'one']);
24 const bare = makeBareRepo(root, 'e');
25 git(work, ['push', '-q', bare, 'HEAD:refs/heads/main']);
26});
27after(async () => { await srv.close(); cleanup(); });
29test('real git ERR on a fetch of an id no one holds: the bytes carry ERR, ply says remote_error not_our_ref', async () => {
30 const phantom = createHash('sha1').update('err-pkt-git phantom').digest('hex');
31 const answers = [];
32 const fetchImpl = async (url, init) => {
33 const r = await fetch(url, init);
34 if (!String(url).endsWith('/git-upload-pack')) return r;
35 const bytes = new Uint8Array(await r.arrayBuffer());
36 answers.push(new TextDecoder().decode(bytes));
37 return new Response(bytes, { status: r.status, headers: r.headers });
38 };
39 const r = await fetchPack(unwrap(createTransport(`${srv.url}/e.git`, { fetchImpl })), { wants: [phantom] });
40 assert.ok(answers.some(a => a.includes(`ERR upload-pack: not our ref ${phantom}`)), JSON.stringify(answers));
41 assert.equal(r.ok, false);
42 assert.equal(r.error.code, 'remote_error', JSON.stringify(r.error));
43 assert.equal(r.error.reason, 'not_our_ref');
44}, 30_000);
Diagnostics6 git calls · 95 ms
CallStatusSizeTime095 ms
discover200191 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=191 git.server.agent=git/github-9922ec520325-Linux git.server.object_format=sha1 git.server.caps=agent ls-refs fetch server-option object-format git.server.fetch=shallow wait-for-done filter git.protocol.version=2 git.pkt.frames=9 git.pkt.data=7 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=191 git.pkt.payload.max=36
ls-refs20012 KiB · hit2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=11990 git.response.cache=HIT git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=152 git.pkt.data=151 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=11990 git.pkt.payload.max=122 git.ls_refs.count=151 git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 102004.2 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=3 git.response.bytes=4347 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=19912563f540228593df0c489082e5e2508e21e4 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=7 git.pkt.data=5 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=4347 git.pkt.payload.max=4247 git.sideband.band1.bytes=4247 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=10 git.pack.bytes=4247 git.pack.ofs_delta=0 git.pack.ref_delta=0 git.pack.chain.max=0 git.pack.trailer=a6caf8e129bea82c9bae4cbc7c130c9205add400 git.pack.full=10Open pack map
fetchtree:0200919 B · hit3 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=919 git.response.cache=HIT git.response.duration_ms=3 git.fetch.filter=tree:0 git.fetch.wants=800d30ba8923860bfc460ca884b7f9ba22083588 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=919 git.pkt.payload.max=892 git.sideband.band1.bytes=892 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=892 git.pack.trailer=5323b9266eea5ded637285d1c5320699f12be76eOpen pack map
fetchtree:02005.6 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=86 git.response.bytes=5724 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=tree:0 git.fetch.wants=58fabb6768b3f737ee9cd8bac647bdc27405fb4d git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=5724 git.pkt.payload.max=5697 git.sideband.band1.bytes=5697 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=1 git.pack.bytes=5697 git.pack.trailer=be7e0453974a5fe832f9065a33bb7e3434c10e9bOpen pack map
fetch2001.1 KiB86 ms
git.upload-pack fetch http.response.status_code=200 git.response.bytes=1099 git.response.cache=MISS git.response.duration_ms=86 git.fetch.wants=3dbd1ffc289742a0bfad36c51f8a770a27829ed6 git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=4 git.pkt.data=3 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1099 git.pkt.payload.max=1072 git.sideband.band1.bytes=1072 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://github.com/ivarvong/ply
- Ref
- refs/heads/main
- Commit
- 19912563f540228593df0c489082e5e2508e21e4
- cf-ray
- a5e15694d8e290ce
- Request
- 7ef2d883…
- Protocol
- v2 · sha1
- Agent
- git/github-9922ec520325-Linux
- Filter
- advertised
- Fetch
- shallow wait-for-done filter
- Capabilities
- agent ls-refs fetch server-option object-format