GitHubivarvong

ply

main
ply6 git calls218 ms24 KiB4 cachedprotocol v2
68 lines4.5 KiBRaw
1// K concurrent writers on one repo, each editing its own file, retrying on cas_conflict.
2// Property: every edit lands exactly once, history is linear, the ref is a CAS chain, nothing else changes.
3import { test } from 'vitest';
4import assert from 'node:assert/strict';
5import { join } from 'node:path';
6import { mkdirSync } from 'node:fs';
7import { git, tmpRoot, makeBareRepo, startGitServer, commitFiles, fsckProblems, initRepo } from './server.js';
8import { editFile } from '../src/edit.js';
9import { Tracer, arrayExporter, flattenLine } from '../src/otel.js';
10import { unwrapAsync } from './unwrap.js';
12test('concurrent CAS writers converge; conflicts are observed and retried, never lost', async () => {
13 const { root, cleanup } = tmpRoot();
14 const srv = await startGitServer(root);
15 try {
16 const bare = makeBareRepo(root, 'cc');
17 const work = join(root, 'w'); mkdirSync(work); initRepo(work);
18 const K = 6, ROUNDS = 3;
19 const files = Object.fromEntries(Array.from({ length: K }, (_, i) => [`dir${i % 2}/f${i}.txt`, `v0 marker${i} end\n`]));
20 const base = commitFiles(work, bare, files, 'seed');
21 const exporter = arrayExporter();
22 const tracer = new Tracer({ exporter });
23 const attempts = [];
24 const writer = async i => {
25 const cache = new Map();
26 for (let r = 1; r <= ROUNDS; r++) {
27 for (let tries = 0; ; tries++) {
28 try {
29 const res = await unwrapAsync(editFile(`${srv.url}/cc.git`, { path: `dir${i % 2}/f${i}.txt`, find: `v${r - 1} marker${i}`, replace: `v${r} marker${i}`, author: { name: `w${i}`, email: `w${i}@x` }, message: `w${i} r${r}` }, { tracer, cache }));
30 attempts.push({ i, r, tries, ok: true, res }); break;
31 } catch (e) {
32 if (e.code !== 'cas_conflict') throw e;
33 attempts.push({ i, r, tries, ok: false });
34 if (tries > 50) throw new Error('livelock');
35 }
36 }
37 }
38 };
39 await Promise.all(Array.from({ length: K }, (_, i) => writer(i)));
40 // all edits landed
41 for (let i = 0; i < K; i++) assert.equal(git(bare, ['cat-file', '-p', `main:dir${i % 2}/f${i}.txt`]), `v${ROUNDS} marker${i} end\n`);
42 // linear history: exactly K*ROUNDS commits above base, each with one parent, each touching exactly one file
43 const log = git(bare, ['rev-list', '--first-parent', `${base}..main`]).trim().split('\n');
44 assert.equal(log.length, K * ROUNDS);
45 for (const c of log) {
46 assert.equal(git(bare, ['rev-list', '--parents', '-n1', c]).trim().split(' ').length, 2);
47 assert.equal(git(bare, ['diff-tree', '--no-commit-id', '--name-only', '-r', c]).trim().split('\n').length, 1);
48 }
49 assert.deepEqual(fsckProblems(bare), []); // losers' packs were unpacked before the CAS failed: dangling by design
50 // conflicts were real: with 6 writers racing, at least one cas_conflict must have occurred and been retried
51 // editFile redoes a cas_conflict once internally (attempt 1, span-linked); what the caller sees is only the conflicts
52 // that lost twice. Every lost CAS, internal or surfaced, is one failed receive-pack span and one failed git.edit root.
53 const surfaced = attempts.filter(a => !a.ok).length;
54 const spans = exporter.lines.flatMap(flattenLine);
55 const ngSpans = spans.filter(s => s.name === 'git.receive-pack' && s.attrs['git.push.ok'] === false);
56 const lostRoots = spans.filter(s => s.name === 'git.edit' && s.attrs['git.edit.outcome'] === 'cas_conflict');
57 const retried = spans.filter(s => s.name === 'git.edit' && s.attrs['git.edit.attempt'] === 1);
58 assert.equal(ngSpans.length, lostRoots.length, 'every lost CAS is a failed receive-pack span and a failed root');
59 assert.equal(retried.length, lostRoots.filter(s => s.attrs['git.edit.attempt'] === 0).length, 'every attempt-0 loss was retried once');
60 assert.ok(retried.every(s => s.links.length === 1), 'retries link to the attempt they retry');
61 assert.equal(surfaced, lostRoots.filter(s => s.attrs['git.edit.attempt'] === 1).length, 'callers see only double losses');
62 const conflicts = ngSpans.length;
63 assert.ok(ngSpans.every(s => /failed to update ref|fetch first|non-fast-forward|lock|incorrect old value provided/.test(s.attrs['git.push.ng.reason'])), ngSpans.map(s => s.attrs['git.push.ng.reason']).join('|'));
64 assert.ok(conflicts > 0, 'expected at least one CAS conflict under contention');
65 // successful pushes == landed commits
66 assert.equal(spans.filter(s => s.name === 'git.receive-pack' && s.attrs['git.push.ok'] === true).length, K * ROUNDS);
67 } finally { await srv.close(); cleanup(); }
68});
Diagnostics6 git calls · 218 ms
CallStatusSizeTime0218 ms
discover200191 B2 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=2
git.response.bytes=191
git.server.agent=git/github-9922ec520325-Linux
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch server-option object-format
git.server.fetch=shallow wait-for-done filter
git.protocol.version=2
git.pkt.frames=9
git.pkt.data=7
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=191
git.pkt.payload.max=36
ls-refs20012 KiB · hit3 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=3
git.response.bytes=11990
git.response.cache=HIT
git.response.duration_ms=3
git.protocol.version=2
git.pkt.frames=152
git.pkt.data=151
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=11990
git.pkt.payload.max=122
git.ls_refs.count=151
git.ls_refs.head=refs/heads/main
fetchtree:0 · deepen 102004.2 KiB · hit3 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=3
git.response.bytes=4347
git.response.cache=HIT
git.response.duration_ms=3
git.fetch.filter=tree:0
git.fetch.wants=19912563f540228593df0c489082e5e2508e21e4
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=7
git.pkt.data=5
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=4347
git.pkt.payload.max=4247
git.sideband.band1.bytes=4247
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=10
git.pack.bytes=4247
git.pack.ofs_delta=0
git.pack.ref_delta=0
git.pack.chain.max=0
git.pack.trailer=a6caf8e129bea82c9bae4cbc7c130c9205add400
git.pack.full=10
Open pack map
fetchtree:0200919 B · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=919
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=800d30ba8923860bfc460ca884b7f9ba22083588
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=919
git.pkt.payload.max=892
git.sideband.band1.bytes=892
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=892
git.pack.trailer=5323b9266eea5ded637285d1c5320699f12be76e
Open pack map
fetchtree:02005.6 KiB · hit2 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=2
git.response.bytes=5724
git.response.cache=HIT
git.response.duration_ms=2
git.fetch.filter=tree:0
git.fetch.wants=58fabb6768b3f737ee9cd8bac647bdc27405fb4d
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=5724
git.pkt.payload.max=5697
git.sideband.band1.bytes=5697
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=1
git.pack.bytes=5697
git.pack.trailer=be7e0453974a5fe832f9065a33bb7e3434c10e9b
Open pack map
fetch2001.8 KiB208 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=207
git.response.bytes=1893
git.response.cache=MISS
git.response.duration_ms=208
git.fetch.wants=d5de3fda9f490694ec4c31c6d3cace3a48de0c4a
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=4
git.pkt.data=3
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=1893
git.pkt.payload.max=1866
git.sideband.band1.bytes=1866
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://github.com/ivarvong/ply
Ref
refs/heads/main
Commit
19912563f540228593df0c489082e5e2508e21e4
cf-ray
a5e2af733981e6b0
Request
50e3c434…
Protocol
v2 · sha1
Agent
git/github-9922ec520325-Linux
Filter
advertised
Fetch
shallow wait-for-done filter
Capabilities
agent ls-refs fetch server-option object-format