main
1// The built declarations compile for the consumers ply names as supported, with skipLibCheck false: a Node service
2// (lib ES2022 + @types/node, no DOM lib) on each supported @types/node major, a browser bundle (lib DOM) and a Worker
3// (@cloudflare/workers-types). tsc is the judge and the expected value is its own: zero `error TS` lines over a file
4// that imports every subpath export in package.json and a file that uses the signer and pack-cache types with the
5// consumer's own platform key. Before the first fix the Node consumer got 5 errors inside node_modules/ply
6// (TextEncoder, TextDecoder, Cache, CryptoKey, CryptoKeyPair: DOM-lib type names @types/node declares only as values or
7// not at all); after it, @types/node 20 and 22 still failed on sign.d.ts (they declare no global `CryptoKey` value;
8// 24 does), which a gate holding only the repo's own @types/node 24 could not see.
9// scripts/dist-check.mjs holds the build and the configs (npm run check:dist runs the same thing in CI).
10import { test, beforeAll as before, afterAll as after } from 'vitest';
11import assert from 'node:assert/strict';
12import { buildConsumer, compileVariant, VARIANTS, SUBPATHS } from '../scripts/dist-check.mjs';
14let consumer;
15before(() => { consumer = buildConsumer(); }, 300_000);
16after(() => { if (consumer) consumer.cleanup(); });
18test('package.json exports the root and 19 subpaths, three of them Node only', () => {
19 // counted by hand from package.json "exports"; a new subpath must be added here on purpose
20 assert.equal(SUBPATHS.length, 20);
21 assert.deepEqual(SUBPATHS.filter(name => name.endsWith('-node')), ['ply/tree-node', 'ply/checkout-node', 'ply/repo-node']);
22});
24// Written by hand, not read from the script: the consumers README names. @types/node 20 is the engines floor
25// (package.json "engines": node >=20), 22 is the Node CI runs, 24 is the repo's own @types/node. The major is checked
26// against the version of the package the compile really ran against, so an alias pointing at the wrong major, or a
27// variant dropped from the script, fails here.
28const EXPECTED = [
29 { name: 'node20', types: '@types/node', major: 20, subpaths: 20 },
30 { name: 'node22', types: '@types/node', major: 22, subpaths: 20 },
31 { name: 'node24', types: '@types/node', major: 24, subpaths: 20 },
32 { name: 'dom', types: '', major: 0, subpaths: 17 },
33 { name: 'workers', types: '@cloudflare/workers-types', major: 5, subpaths: 17 },
34];
36test('the variants are Node on @types/node 20, 22 and 24, DOM and Workers', () => {
37 assert.deepEqual(VARIANTS.map(variant => variant.name), EXPECTED.map(expected => expected.name));
38});
40for (const expected of EXPECTED) {
41 test(`dist d.ts compiles for a ${expected.name} consumer, skipLibCheck false, and no variant is skipped`, () => {
42 const variant = VARIANTS.find(candidate => candidate.name === expected.name);
43 assert.ok(variant, `no ${expected.name} variant in scripts/dist-check.mjs`);
44 assert.equal(variant.subpaths.length, expected.subpaths);
45 const { errors, provided } = compileVariant(consumer, variant);
46 assert.deepEqual(errors, []);
47 // what the compile ran against: exactly the one type package, at the expected major
48 const majors = Object.fromEntries(Object.entries(provided).map(([name, version]) => [name, Number(version.split('.')[0])]));
49 assert.deepEqual(majors, expected.types === '' ? {} : { [expected.types]: expected.major });
50 }, 300_000);
51}
53test('a variant whose type package is not installed is an error, never a skip', () => {
54 const { errors } = compileVariant(consumer, { name: 'absent', lib: ['es2022'], types: ['node'], provides: { '@types/node': 'types-node-not-installed' }, subpaths: SUBPATHS, use: '' });
55 assert.deepEqual(errors, ['absent: node_modules/types-node-not-installed is not installed (run npm ci); this variant is never skipped']);
56});
Diagnostics4 git calls · 366 ms
CallStatusSizeTime0366 ms
discover200152 B2 ms
git.upload-pack discover http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=152 git.server.agent=gitty/1.0 git.server.object_format=sha1 git.server.caps=agent ls-refs fetch object-format git.server.fetch=shallow filter sideband-all git.protocol.version=2 git.pkt.frames=8 git.pkt.data=6 git.pkt.flush=2 git.pkt.delim=0 git.pkt.bytes=152 git.pkt.payload.max=34
ls-refs200145 B · hit2 ms
git.upload-pack ls-refs http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=ls-refs git.upstream.dur_ms=2 git.response.bytes=145 git.response.cache=HIT git.response.duration_ms=2 git.protocol.version=2 git.pkt.frames=3 git.pkt.data=2 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=145 git.pkt.payload.max=76 git.ls_refs.count=2 git.ls_refs.head=refs/heads/main
fetchblob:none · deepen 1020038 KiB · hit2 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=2 git.response.bytes=38434 git.response.cache=HIT git.response.duration_ms=2 git.fetch.filter=blob:none git.fetch.filter.requested=tree:0 git.fetch.filter.fallback=blob:none git.fetch.filter.learned=false git.fetch.wants=19912563f540228593df0c489082e5e2508e21e4 git.fetch.haves.count=0 git.fetch.deepen=10 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=6 git.pkt.data=4 git.pkt.flush=1 git.pkt.delim=1 git.pkt.bytes=38434 git.pkt.payload.max=38339 git.sideband.band1.bytes=38338 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0 git.pack.objects=63 git.pack.bytes=38338 git.pack.ofs_delta=0 git.pack.ref_delta=8 git.pack.chain.max=8 git.pack.trailer=0bc36ab7adf82d3109177f11f1ea93f1ce071f77 git.pack.full=55Open pack map
fetch2001.6 KiB362 ms
git.upload-pack fetch http.response.status_code=200 git.upstream.cf_ray=- git.upstream.phase=fetch git.upstream.dur_ms=362 git.response.bytes=1689 git.response.cache=MISS git.response.duration_ms=362 git.fetch.wants=734eb4cf0003df940473089665c5b80bef768c8f git.fetch.haves.count=0 git.fetch.deepen=0 git.fetch.thin_pack=false git.fetch.ofs_delta=true git.protocol.version=2 git.pkt.frames=3 git.pkt.data=2 git.pkt.flush=1 git.pkt.delim=0 git.pkt.bytes=1689 git.pkt.payload.max=1668 git.sideband.band1.bytes=1667 git.sideband.band2.bytes=0 git.sideband.band3.bytes=0
Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.
- Remote
- https://5ad2236b39de4c8bd8f6270ea63f3ea9.artifacts.cloudflare.net/git/public-v0/ply.git
- Ref
- refs/heads/main
- Commit
- 19912563f540228593df0c489082e5e2508e21e4
- cf-ray
- a5e2be212cd5cfc3
- Request
- 14c24b8c…
- Protocol
- v2 · sha1
- Agent
- gitty/1.0
- Filter
- advertised
- Fetch
- shallow filter sideband-all
- Capabilities
- agent ls-refs fetch object-format