Artifactspublic-v0

curl

master
ply4 git calls327 ms288 KiB2 cachedprotocol v2
Victor Hugo31c911e
peer: use the given proxy port, fall back to the documented default···

Since bc40e09f63 the proxy port is read with CURLU_NO_DEFAULT_PORT, which drops an explicit port when it matches the default port of the proxy URL's scheme. A proxy string without a scheme is guessed as http, so "--socks5 host:80" ended up connecting to port 1080, and an explicit port lost against CURLOPT_PROXYPORT when it happened to be the scheme default.

The fallback also became the scheme's default port, so a plain HTTP proxy without a port used 80 instead of the documented 1080.

Use the port as given, otherwise CURLOPT_PROXYPORT, or 443 for https default, or 1080 for all others as default, like before.

Extend unit test 2413 to verify.

Follow-up to bc40e09f63.

Fixes https://github.com/curl/curl/issues/23681 Closes https://github.com/curl/curl/pull/23682

                              _   _ ____  _
                          ___| | | |  _ \| |
                         / __| | | | |_) | |
                        | (__| |_| |  _ <| |___
                         \___|\___/|_| \_\_____|

README

Curl is a command line tool for transferring data specified with URL syntax. Find out how to use curl by reading the curl.1 man page or the MANUAL document. Find out how to install Curl by reading the INSTALL document.

libcurl is the library curl is using to do its job. It is readily available to be used by your software. Read the libcurl.3 man page to learn how.

You find answers to the most frequent questions we get in the FAQ.md document.

Study the COPYING file for distribution terms.

Those documents and more can be found in the docs/ directory.

CONTACT

If you have problems, questions, ideas or suggestions, please contact us by posting to a suitable mailing list. See https://curl.se/mail/

All contributors to the project are listed in the THANKS document.

WEBSITE

Visit the curl website for the latest news and downloads:

https://curl.se/

GIT

To download the latest source code off the GIT server, do this:

git clone https://github.com/curl/curl

(you get a directory named curl, filled with the source code)

SECURITY PROBLEMS

Report suspected security problems privately and not in public.

https://curl.se/dev/vuln-disclosure.html

Recent commits10
Diagnostics4 git calls · 327 ms
CallStatusSizeTime0327 ms
discover200152 B22 ms
git.upload-pack discover
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=22
git.response.bytes=152
git.server.agent=gitty/1.0
git.server.object_format=sha1
git.server.caps=agent ls-refs fetch object-format
git.server.fetch=shallow filter sideband-all
git.protocol.version=2
git.pkt.frames=8
git.pkt.data=6
git.pkt.flush=2
git.pkt.delim=0
git.pkt.bytes=152
git.pkt.payload.max=34
ls-refs200149 B250 ms
git.upload-pack ls-refs
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=ls-refs
git.upstream.dur_ms=228
git.response.bytes=149
git.response.cache=EXPIRED
git.response.duration_ms=228
git.protocol.version=2
git.pkt.frames=3
git.pkt.data=2
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=149
git.pkt.payload.max=78
git.ls_refs.count=2
git.ls_refs.head=refs/heads/master
fetchblob:none · deepen 10200287 KiB · hit45 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=18
git.response.bytes=293470
git.response.cache=HIT
git.response.duration_ms=45
git.fetch.filter=blob:none
git.fetch.filter.requested=tree:0
git.fetch.filter.fallback=blob:none
git.fetch.filter.learned=false
git.fetch.wants=31c911efe5652725e930f4d2e60c9060e5f6646d
git.fetch.haves.count=0
git.fetch.deepen=10
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=10
git.pkt.data=8
git.pkt.flush=1
git.pkt.delim=1
git.pkt.bytes=293470
git.pkt.payload.max=65516
git.sideband.band1.bytes=293354
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0
git.pack.objects=87
git.pack.bytes=293354
git.pack.ofs_delta=0
git.pack.ref_delta=1
git.pack.chain.max=1
git.pack.trailer=6a646bcda6740bab42e321b51998b52ea15146c0
git.pack.full=86
Open pack map
fetch200791 B · hit32 ms
git.upload-pack fetch
http.response.status_code=200
git.upstream.cf_ray=-
git.upstream.phase=fetch
git.upstream.dur_ms=31
git.response.bytes=791
git.response.cache=HIT
git.response.duration_ms=32
git.fetch.wants=bc04a79dbc5e82b67abf0d1c46b5d139063cfa37
git.fetch.haves.count=0
git.fetch.deepen=0
git.fetch.thin_pack=false
git.fetch.ofs_delta=true
git.protocol.version=2
git.pkt.frames=3
git.pkt.data=2
git.pkt.flush=1
git.pkt.delim=0
git.pkt.bytes=791
git.pkt.payload.max=770
git.sideband.band1.bytes=769
git.sideband.band2.bytes=0
git.sideband.band3.bytes=0

Each row is one HTTP round trip ply made to the git server for this page, on one timeline. discover asks what the server speaks, ls-refs lists branch tips, fetch brings objects by id. A hit was served by Workers Cache. Tap a row for its wire details.

Remote
https://5ad2236b39de4c8bd8f6270ea63f3ea9.artifacts.cloudflare.net/git/public-v0/curl.git
Ref
refs/heads/master
Commit
31c911efe5652725e930f4d2e60c9060e5f6646d
cf-ray
a5e0f8157a9e332c
Request
854ce54b…
Protocol
v2 · sha1
Agent
gitty/1.0
Filter
advertised
Fetch
shallow filter sideband-all
Capabilities
agent ls-refs fetch object-format